Re: [PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-25 Thread via GitHub


yihua merged PR #11294:
URL: https://github.com/apache/hudi/pull/11294


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-25 Thread via GitHub


yihua commented on PR #11294:
URL: https://github.com/apache/hudi/pull/11294#issuecomment-2131022454

   Azure CI is green.
   https://github.com/apache/hudi/assets/2497195/cda55415-e410-476f-adc1-9a20591ec8c7";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-24 Thread via GitHub


yihua commented on PR #11294:
URL: https://github.com/apache/hudi/pull/11294#issuecomment-2130870938

   New run after resolving conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-24 Thread via GitHub


yihua commented on PR #11294:
URL: https://github.com/apache/hudi/pull/11294#issuecomment-2130752865

   Azure CI manually triggered: 
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=24051


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-24 Thread via GitHub


yihua commented on PR #11294:
URL: https://github.com/apache/hudi/pull/11294#issuecomment-2130746129

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-24 Thread via GitHub


yihua merged PR #11293:
URL: https://github.com/apache/hudi/pull/11293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-24 Thread via GitHub


yihua commented on PR #11293:
URL: https://github.com/apache/hudi/pull/11293#issuecomment-2130745935

   Azure CI is green.
   https://github.com/apache/hudi/assets/2497195/84505240-ebee-4406-847d-8623e08791b7";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-24 Thread via GitHub


hudi-bot commented on PR #11294:
URL: https://github.com/apache/hudi/pull/11294#issuecomment-2130605099

   
   ## CI report:
   
   * 03e9ba49998b64fca42b47fcd33e3c103f120ac1 UNKNOWN
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-24 Thread via GitHub


hudi-bot commented on PR #11293:
URL: https://github.com/apache/hudi/pull/11293#issuecomment-2130604858

   
   ## CI report:
   
   * 82c8061f78034840ed5e121c88201f47d2b562e4 UNKNOWN
   * 4e2ad1de59f01f16cb69ed49cce26c715e6aaf7a UNKNOWN
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-24 Thread via GitHub


hudi-bot commented on PR #11293:
URL: https://github.com/apache/hudi/pull/11293#issuecomment-2130589172

   
   ## CI report:
   
   * 82c8061f78034840ed5e121c88201f47d2b562e4 UNKNOWN
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-24 Thread via GitHub


yihua opened a new pull request, #11294:
URL: https://github.com/apache/hudi/pull/11294

   ### Change Logs
   
   PR targeting master: https://github.com/apache/hudi/pull/11293
   This PR targets `branch-0.x` with the same changes for 0.x releases.
   
   This PR reverts the changes in `DFSPathSelector`, subclasses, and 
`UtilHelpers.readConfig` API so they still use Hadoop classes, given they are 
used in Spark and utilities classes, to avoid behavior change and breaking API 
change.
   
   ### Impact
   
   As above, makes upgrade easier.
   
   ### Risk level
   
   none
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig [hudi]

2024-05-24 Thread via GitHub


yihua opened a new pull request, #11293:
URL: https://github.com/apache/hudi/pull/11293

   ### Change Logs
   
   This PR reverts the changes in `DFSPathSelector`, subclasses, and 
`UtilHelpers.readConfig` API so they still use Hadoop classes, given they are 
used in Spark and utilities classes, to avoid behavior change and breaking API 
change.
   
   ### Impact
   
   As above, makes upgrade easier.
   
   ### Risk level
   
   none
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org