Re: [PR] [HUDI-7844] Fix HoodieSparkSqlTestBase to throw error upon test failure [hudi]

2024-06-08 Thread via GitHub


codope merged PR #11416:
URL: https://github.com/apache/hudi/pull/11416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7844] Fix HoodieSparkSqlTestBase to throw error upon test failure [hudi]

2024-06-08 Thread via GitHub


hudi-bot commented on PR #11416:
URL: https://github.com/apache/hudi/pull/11416#issuecomment-2156018029

   
   ## CI report:
   
   * 8235d366753038068a1145757fe539e8db4298e3 Azure: 
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24294)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7844] Fix HoodieSparkSqlTestBase to throw error upon test failure [hudi]

2024-06-08 Thread via GitHub


hudi-bot commented on PR #11416:
URL: https://github.com/apache/hudi/pull/11416#issuecomment-2155996582

   
   ## CI report:
   
   * 70f8a79214fcd176dd275faf56bb789d4db60f7f Azure: 
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24292)
 
   * 8235d366753038068a1145757fe539e8db4298e3 Azure: 
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24294)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7844] Fix HoodieSparkSqlTestBase to throw error upon test failure [hudi]

2024-06-08 Thread via GitHub


hudi-bot commented on PR #11416:
URL: https://github.com/apache/hudi/pull/11416#issuecomment-2155983361

   
   ## CI report:
   
   * 70f8a79214fcd176dd275faf56bb789d4db60f7f Azure: 
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24292)
 
   * 8235d366753038068a1145757fe539e8db4298e3 UNKNOWN
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7844] Fix HoodieSparkSqlTestBase to throw error upon test failure [hudi]

2024-06-08 Thread via GitHub


codope commented on code in PR #11416:
URL: https://github.com/apache/hudi/pull/11416#discussion_r1632020201


##
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/command/index/TestFunctionalIndex.scala:
##
@@ -35,9 +35,9 @@ import org.apache.spark.sql.catalyst.parser.ParserInterface
 import org.apache.spark.sql.hudi.command.{CreateIndexCommand, 
ShowIndexesCommand}
 import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase
 import org.junit.jupiter.api.Assertions.{assertEquals, assertTrue}
-import org.junit.jupiter.api.Tag
+import org.scalatest.Ignore
 
-@Tag("functional")
+@Ignore

Review Comment:
   note: moved this class out of functional package and disabled temporarily. 
More details in HUDI-7835. TL;DR need to check why this test is attempted twice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7844] Fix HoodieSparkSqlTestBase to throw error upon test failure [hudi]

2024-06-08 Thread via GitHub


hudi-bot commented on PR #11416:
URL: https://github.com/apache/hudi/pull/11416#issuecomment-2155855408

   
   ## CI report:
   
   * 70f8a79214fcd176dd275faf56bb789d4db60f7f Azure: 
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24292)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7844] Fix HoodieSparkSqlTestBase to throw error upon test failure [hudi]

2024-06-07 Thread via GitHub


hudi-bot commented on PR #11416:
URL: https://github.com/apache/hudi/pull/11416#issuecomment-2155836211

   
   ## CI report:
   
   * 70f8a79214fcd176dd275faf56bb789d4db60f7f Azure: 
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24292)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7844] Fix HoodieSparkSqlTestBase to throw error upon test failure [hudi]

2024-06-07 Thread via GitHub


hudi-bot commented on PR #11416:
URL: https://github.com/apache/hudi/pull/11416#issuecomment-2155833908

   
   ## CI report:
   
   * 70f8a79214fcd176dd275faf56bb789d4db60f7f UNKNOWN
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [HUDI-7844] Fix HoodieSparkSqlTestBase to throw error upon test failure [hudi]

2024-06-07 Thread via GitHub


yihua opened a new pull request, #11416:
URL: https://github.com/apache/hudi/pull/11416

   ### Change Logs
   
   PR #11162 introduces the changes that make `HoodieSparkSqlTestBase` to 
swallow test failures.  This PR reverts the changes so that test failures are 
surfaced locally and in CI.
   
   ### Impact
   
   Makes sure test failures are surfaced in CI.
   
   ### Risk level
   
   none
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org