[jira] [Comment Edited] (HUDI-2150) Rename/Restructure configs for better modularity

2021-07-13 Thread Vinoth Chandar (Jira)


[ 
https://issues.apache.org/jira/browse/HUDI-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380201#comment-17380201
 ] 

Vinoth Chandar edited comment on HUDI-2150 at 7/13/21, 10:12 PM:
-

Generalize for other base file formats?

 
{code:java}
public static final ConfigProperty PARQUET_FILE_MAX_BYTES = 
ConfigProperty
 .key("hoodie.parquet.max.file.size"){code}
{code:java}
public static final ConfigProperty PARQUET_COMPRESSION_RATIO = 
ConfigProperty
 .key("hoodie.parquet.compression.ratio")
 .defaultValue(String.valueOf(0.1)){code}


was (Author: vc):
Generalize for other base file formats?

 
{code:java}
public static final ConfigProperty PARQUET_COMPRESSION_RATIO = 
ConfigProperty
 .key("hoodie.parquet.compression.ratio")
 .defaultValue(String.valueOf(0.1)){code}

> Rename/Restructure configs for better modularity
> 
>
> Key: HUDI-2150
> URL: https://issues.apache.org/jira/browse/HUDI-2150
> Project: Apache Hudi
>  Issue Type: Sub-task
>  Components: Code Cleanup
>Reporter: Vinoth Chandar
>Assignee: Vinoth Chandar
>Priority: Major
>
> Given we have a framework now, that can capture configs and even their 
> alternatives well, time to clean things up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HUDI-2150) Rename/Restructure configs for better modularity

2021-07-12 Thread Vinoth Chandar (Jira)


[ 
https://issues.apache.org/jira/browse/HUDI-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379561#comment-17379561
 ] 

Vinoth Chandar edited comment on HUDI-2150 at 7/13/21, 5:57 AM:


Cleaner related configs to be moved out of HoodieCompactionConfig into its own 
HoodieCleanConfig. 

 

Archival related configs to be moved out of HoodieCompactionConfig into its own 
HoodieArchivalConfig.


was (Author: vc):
Cleaner related configs to be moved out of HoodieCompactionConfig into its own 
HoodieCleanConfig

> Rename/Restructure configs for better modularity
> 
>
> Key: HUDI-2150
> URL: https://issues.apache.org/jira/browse/HUDI-2150
> Project: Apache Hudi
>  Issue Type: Sub-task
>  Components: Code Cleanup
>Reporter: Vinoth Chandar
>Assignee: Vinoth Chandar
>Priority: Major
>
> Given we have a framework now, that can capture configs and even their 
> alternatives well, time to clean things up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)