[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438022#comment-17438022 ] sivabalan narayanan commented on HUDI-1939: --- Synced up with [~xushiyan] on this. downgrading from "release blocker" as we need more work to be done and is not very critical. > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Major > Labels: pull-request-available > Fix For: 0.10.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397026#comment-17397026 ] ASF GitHub Bot commented on HUDI-1939: -- xushiyan merged pull request #3430: URL: https://github.com/apache/hudi/pull/3430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395795#comment-17395795 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3430: URL: https://github.com/apache/hudi/pull/3430#issuecomment-894739039 ## CI report: * 98c1426675f6ff7ddec587e13d1190e76bce1b45 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1542) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1544) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395771#comment-17395771 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * f471e96ca6b96060e7663666a1c16ecaa48b9b11 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=999) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395627#comment-17395627 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3430: URL: https://github.com/apache/hudi/pull/3430#issuecomment-894739039 ## CI report: * 98c1426675f6ff7ddec587e13d1190e76bce1b45 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1542) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1544) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395607#comment-17395607 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * f471e96ca6b96060e7663666a1c16ecaa48b9b11 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=999) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395493#comment-17395493 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3430: URL: https://github.com/apache/hudi/pull/3430#issuecomment-894739039 ## CI report: * 98c1426675f6ff7ddec587e13d1190e76bce1b45 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1542) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1544) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395490#comment-17395490 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3430: URL: https://github.com/apache/hudi/pull/3430#issuecomment-894739039 ## CI report: * 98c1426675f6ff7ddec587e13d1190e76bce1b45 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1542) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1544) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395489#comment-17395489 ] ASF GitHub Bot commented on HUDI-1939: -- xushiyan commented on pull request #3430: URL: https://github.com/apache/hudi/pull/3430#issuecomment-894763710 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395459#comment-17395459 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3430: URL: https://github.com/apache/hudi/pull/3430#issuecomment-894739039 ## CI report: * 98c1426675f6ff7ddec587e13d1190e76bce1b45 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1542) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395456#comment-17395456 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3430: URL: https://github.com/apache/hudi/pull/3430#issuecomment-894739039 ## CI report: * 98c1426675f6ff7ddec587e13d1190e76bce1b45 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1542) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395454#comment-17395454 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot commented on pull request #3430: URL: https://github.com/apache/hudi/pull/3430#issuecomment-894739039 ## CI report: * 98c1426675f6ff7ddec587e13d1190e76bce1b45 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[
https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395453#comment-17395453
]
ASF GitHub Bot commented on HUDI-1939:
--
xushiyan commented on a change in pull request #3430:
URL: https://github.com/apache/hudi/pull/3430#discussion_r684710285
##
File path:
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java
##
@@ -122,117 +116,6 @@ public void teardown() throws Exception {
HiveTestUtil.clear();
}
- /**
- * Testing converting array types to Hive field declaration strings.
- *
- * Refer to the Parquet-113 spec:
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists
- */
- @Test
- public void testSchemaConvertArray() throws IOException {
Review comment:
this and 2 tests below already moved to
org.apache.hudi.hive.util.TestHiveSchemaUtil. These were added back due to auto
merge during rebase probably.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Replace joda-time api to new jdk8 time api
> --
>
> Key: HUDI-1939
> URL: https://issues.apache.org/jira/browse/HUDI-1939
> Project: Apache Hudi
> Issue Type: Improvement
>Reporter: Xuedong Luan
>Assignee: Xuedong Luan
>Priority: Minor
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> remove the usage of joda-time api and use the new jdk8 time api
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395452#comment-17395452 ] ASF GitHub Bot commented on HUDI-1939: -- xushiyan opened a new pull request #3430: URL: https://github.com/apache/hudi/pull/3430 - Replace joda time API with java.time. - Remove repeated tests that were ported to org.apache.hudi.hive.util.TestHiveSchemaUtil - ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary doc changes done or have another open PR - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386095#comment-17386095 ] ASF GitHub Bot commented on HUDI-1939: -- pratyakshsharma commented on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-885496934 will circle back on this today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382773#comment-17382773 ] ASF GitHub Bot commented on HUDI-1939: -- xushiyan edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-869225643 - [x] fix UT failures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[
https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382771#comment-17382771
]
ASF GitHub Bot commented on HUDI-1939:
--
xushiyan commented on a change in pull request #3003:
URL: https://github.com/apache/hudi/pull/3003#discussion_r671803228
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/parser/HoodieDateTimeParserImpl.java
##
@@ -51,22 +47,21 @@ private DateTimeFormatter getInputDateFormatter() {
throw new
IllegalArgumentException(Config.TIMESTAMP_INPUT_DATE_FORMAT_PROP + "
configuration is required");
}
-DateTimeFormatter formatter = new DateTimeFormatterBuilder()
-.append(
-null,
-Arrays.stream(
-
this.configInputDateFormatList.split(super.configInputDateFormatDelimiter))
- .map(String::trim)
- .map(DateTimeFormat::forPattern)
- .map(DateTimeFormatter::getParser)
- .toArray(DateTimeParser[]::new))
+DateTimeFormatterBuilder formatterBuilder = new DateTimeFormatterBuilder();
+
Arrays.stream(this.configInputDateFormatList.split(super.configInputDateFormatDelimiter))
+.map(String::trim)
+.map(DateTimeFormatter::ofPattern)
+.forEach(formatterBuilder::appendOptional);
+DateTimeFormatter formatter = formatterBuilder
+.parseDefaulting(ChronoField.HOUR_OF_DAY, 0)
+.parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0)
+.parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0)
.toFormatter();
if (this.inputDateTimeZone != null) {
formatter = formatter.withZone(this.inputDateTimeZone);
} else {
- formatter = formatter.withOffsetParsed();
+ formatter = formatter.withZone(ZoneId.systemDefault());
Review comment:
this is not fully compatible change: joda has a feature to infer
timezone from input string but java time does not. so it supplies system
default timezone.
##
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestTimestampBasedKeyGenerator.java
##
@@ -223,9 +223,9 @@ public void
test_ExpectsMatch_SingleInputFormat_ISO8601WithMsZ_OutputTimezoneAsU
baseRecord.put("createTime", "2020-04-01T13:01:33.428Z");
properties = this.getBaseKeyConfig(
"DATE_STRING",
-"-MM-dd'T'HH:mm:ss.SSSZ",
-"",
+"-MM-dd'T'HH:mm:ss.SSSX",
"",
+"GMT",
Review comment:
as commented above, since using java time will by default give system
default timezone, we need to set the timezone specifically to make sure it
matches with input data's timezone `Z`
##
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestTimestampBasedKeyGenerator.java
##
@@ -331,11 +331,11 @@ public void
test_ExpectsMatch_MultipleInputFormats_ISO8601WithMsZ_OutputTimezone
baseRecord.put("createTime", "2020-04-01T13:01:33.123Z");
properties = this.getBaseKeyConfig(
"DATE_STRING",
-"-MM-dd'T'HH:mm:ssZ,-MM-dd'T'HH:mm:ss.SSSZ",
-"",
+"-MM-dd'T'HH:mm:ssX,-MM-dd'T'HH:mm:ss.SSSX",
"",
+"GMT",
"MMddHH",
-"EST");
+"EST5EDT");
Review comment:
timezone `EST` has daylight savings issue; use `EST5EDT` to handle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Replace joda-time api to new jdk8 time api
> --
>
> Key: HUDI-1939
> URL: https://issues.apache.org/jira/browse/HUDI-1939
> Project: Apache Hudi
> Issue Type: Improvement
>Reporter: Xuedong Luan
>Assignee: Xuedong Luan
>Priority: Minor
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> remove the usage of joda-time api and use the new jdk8 time api
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382761#comment-17382761 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * f471e96ca6b96060e7663666a1c16ecaa48b9b11 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=999) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382760#comment-17382760 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382759#comment-17382759 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f471e96) into [master](https://codecov.io/gh/apache/hudi/commit/572a2144124b90b2dbef8183ee19a95b21de2716?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (572a214) will **decrease** coverage by `20.32%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3003 +/- ## = - Coverage 47.83% 27.50% -20.33% + Complexity 5565 1302 -4263 = Files 936 386 -550 Lines 4166315379-26284 Branches 4197 1344 -2853 = - Hits 19929 4230-15699 + Misses1996010844 -9116 + Partials 1774 305 -1469 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `20.91% <0.00%> (-13.62%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <0.00%> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `59.77% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...apache/hudi/index/hbase/SparkHoodieHBaseIndex.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvaGJhc2UvU3BhcmtIb29kaWVIQmFzZUluZGV4LmphdmE=) | `15.16% <0.00%> (ø)` | | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/ap
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382756#comment-17382756 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f471e96) into [master](https://codecov.io/gh/apache/hudi/commit/572a2144124b90b2dbef8183ee19a95b21de2716?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (572a214) will **decrease** coverage by `31.79%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3003 +/- ## = - Coverage 47.83% 16.03% -31.80% + Complexity 5565 503 -5062 = Files 936 284 -652 Lines 4166311871-29792 Branches 4197 987 -3210 = - Hits 19929 1904-18025 + Misses19960 9803-10157 + Partials 1774 164 -1610 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.53%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <0.00%> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `59.77% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValueExtractor.java]
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382751#comment-17382751 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f471e96) into [master](https://codecov.io/gh/apache/hudi/commit/572a2144124b90b2dbef8183ee19a95b21de2716?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (572a214) will **decrease** coverage by `45.01%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3003 +/- ## - Coverage 47.83% 2.82% -45.02% + Complexity 5565 85 -5480 Files 936 284 -652 Lines 41663 11871-29792 Branches 4197 987 -3210 - Hits 19929 335-19594 + Misses19960 11510 -8450 + Partials 1774 26 -1748 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.53%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <0.00%> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `8.99% <ø> (-50.78%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValueExtractor.
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382749#comment-17382749 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * f379c7e27ab0411d245479d9b1df6c4049ec1acb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=997) * f471e96ca6b96060e7663666a1c16ecaa48b9b11 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=999) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382748#comment-17382748 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * f379c7e27ab0411d245479d9b1df6c4049ec1acb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=997) * f471e96ca6b96060e7663666a1c16ecaa48b9b11 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382722#comment-17382722 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * f379c7e27ab0411d245479d9b1df6c4049ec1acb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=997) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382720#comment-17382720 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f379c7e) into [master](https://codecov.io/gh/apache/hudi/commit/572a2144124b90b2dbef8183ee19a95b21de2716?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (572a214) will **decrease** coverage by `31.79%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3003 +/- ## = - Coverage 47.83% 16.03% -31.80% + Complexity 5565 503 -5062 = Files 936 284 -652 Lines 4166311871-29792 Branches 4197 987 -3210 = - Hits 19929 1904-18025 + Misses19960 9803-10157 + Partials 1774 164 -1610 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.53%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <0.00%> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `59.77% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValueExtractor.java]
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382719#comment-17382719 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 60bcec514ada242a91750f377aeff3b719770c6b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=996) * f379c7e27ab0411d245479d9b1df6c4049ec1acb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=997) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382718#comment-17382718 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f379c7e) into [master](https://codecov.io/gh/apache/hudi/commit/572a2144124b90b2dbef8183ee19a95b21de2716?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (572a214) will **decrease** coverage by `45.01%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3003 +/- ## - Coverage 47.83% 2.82% -45.02% + Complexity 5565 85 -5480 Files 936 284 -652 Lines 41663 11871-29792 Branches 4197 987 -3210 - Hits 19929 335-19594 + Misses19960 11510 -8450 + Partials 1774 26 -1748 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.53%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <0.00%> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `8.99% <ø> (-50.78%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValueExtractor.
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382717#comment-17382717 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 60bcec514ada242a91750f377aeff3b719770c6b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=996) * f379c7e27ab0411d245479d9b1df6c4049ec1acb UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382716#comment-17382716 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 60bcec514ada242a91750f377aeff3b719770c6b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=996) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382710#comment-17382710 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * ada54b27a07b6d79c8177ce7bf8f9384f95400c5 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=994) * 60bcec514ada242a91750f377aeff3b719770c6b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=996) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382705#comment-17382705 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ada54b2) into [master](https://codecov.io/gh/apache/hudi/commit/572a2144124b90b2dbef8183ee19a95b21de2716?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (572a214) will **decrease** coverage by `31.79%`. > The diff coverage is `0.00%`. > :exclamation: Current head ada54b2 differs from pull request most recent head 60bcec5. Consider uploading reports for the commit 60bcec5 to get more accurate results [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3003 +/- ## = - Coverage 47.83% 16.04% -31.80% + Complexity 5565 503 -5062 = Files 936 284 -652 Lines 4166311870-29793 Branches 4197 987 -3210 = - Hits 19929 1904-18025 + Misses19960 9802-10158 + Partials 1774 164 -1610 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.53%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <0.00%> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `59.77% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hp
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382703#comment-17382703 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * ada54b27a07b6d79c8177ce7bf8f9384f95400c5 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=994) * 60bcec514ada242a91750f377aeff3b719770c6b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382702#comment-17382702 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 276f960d6a7c49fcd231b54c093e41bb9ff59e52 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=993) * ada54b27a07b6d79c8177ce7bf8f9384f95400c5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=994) * 60bcec514ada242a91750f377aeff3b719770c6b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382701#comment-17382701 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ada54b2) into [master](https://codecov.io/gh/apache/hudi/commit/572a2144124b90b2dbef8183ee19a95b21de2716?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (572a214) will **decrease** coverage by `45.01%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3003 +/- ## - Coverage 47.83% 2.82% -45.02% + Complexity 5565 85 -5480 Files 936 284 -652 Lines 41663 11870-29793 Branches 4197 987 -3210 - Hits 19929 335-19594 + Misses19960 11509 -8451 + Partials 1774 26 -1748 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.53%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <0.00%> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `8.99% <ø> (-50.78%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValueExtractor.
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382699#comment-17382699 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 276f960d6a7c49fcd231b54c093e41bb9ff59e52 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=993) * ada54b27a07b6d79c8177ce7bf8f9384f95400c5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=994) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382697#comment-17382697 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 276f960d6a7c49fcd231b54c093e41bb9ff59e52 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=993) * ada54b27a07b6d79c8177ce7bf8f9384f95400c5 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382690#comment-17382690 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 276f960d6a7c49fcd231b54c093e41bb9ff59e52 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=993) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382689#comment-17382689 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (276f960) into [master](https://codecov.io/gh/apache/hudi/commit/572a2144124b90b2dbef8183ee19a95b21de2716?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (572a214) will **decrease** coverage by `31.79%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3003 +/- ## = - Coverage 47.83% 16.03% -31.80% + Complexity 5565 503 -5062 = Files 936 284 -652 Lines 4166311871-29792 Branches 4197 987 -3210 = - Hits 19929 1904-18025 + Misses19960 9803-10157 + Partials 1774 164 -1610 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.53%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <0.00%> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `59.77% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValueExtractor.java]
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382688#comment-17382688 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (276f960) into [master](https://codecov.io/gh/apache/hudi/commit/572a2144124b90b2dbef8183ee19a95b21de2716?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (572a214) will **decrease** coverage by `45.01%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3003 +/- ## - Coverage 47.83% 2.82% -45.02% + Complexity 5565 85 -5480 Files 936 284 -652 Lines 41663 11871-29792 Branches 4197 987 -3210 - Hits 19929 335-19594 + Misses19960 11510 -8450 + Partials 1774 26 -1748 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.53%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <0.00%> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `8.99% <ø> (-50.78%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValueExtractor.
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382687#comment-17382687 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 94f395cd1cb8bb1c34d9d4d78420ceb718bd1195 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=719) * 276f960d6a7c49fcd231b54c093e41bb9ff59e52 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=993) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382686#comment-17382686 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 94f395cd1cb8bb1c34d9d4d78420ceb718bd1195 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=719) * 276f960d6a7c49fcd231b54c093e41bb9ff59e52 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377147#comment-17377147 ] ASF GitHub Bot commented on HUDI-1939: -- xushiyan commented on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-876185797 Sure @vinothchandar I did see that but haven't dive deeper. What I meant is either @leoluan2009 or I could spare some time these 2 days trying to land this sooner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377127#comment-17377127 ] ASF GitHub Bot commented on HUDI-1939: -- vinothchandar commented on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-876175319 SQL tests ``` [31m org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 27.0 failed 1 times, most recent failure: Lost task 0.0 in stage 27.0 (TID 25, localhost, executor driver): java.time.temporal.UnsupportedTemporalTypeException: Unsupported field: YearOfEra[0m [31mat java.time.Instant.getLong(Instant.java:603)[0m [31mat java.time.format.DateTimePrintContext.getValue(DateTimePrintContext.java:298)[0m [31mat java.time.format.DateTimeFormatterBuilder$NumberPrinterParser.format(DateTimeFormatterBuilder.java:2540)[0m [31mat java.time.format.DateTimeFormatterBuilder$CompositePrinterParser.format(DateTimeFormatterBuilder.java:2179)[0m [31mat java.time.format.DateTimeFormatter.formatTo(DateTimeFormatter.java:1746)[0m [31mat java.time.format.DateTimeFormatter.format(DateTimeFormatter.java:1720)[0m [31mat org.apache.spark.sql.hudi.command.SqlKeyGenerator$$anonfun$getPartitionPath$1.apply(SqlKeyGenerator.scala:67)[0m [31mat org.apache.spark.sql.hudi.command.SqlKeyGenerator$$anonfun$getPartitionPath$1.apply(SqlKeyGenerator.scala:53)[0m [31mat scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)[0m [31mat scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)[0m [31mat scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)[0m [31mat scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:186)[0m [31mat scala.collection.TraversableLike$class.map(TraversableLike.scala:234)[0m [31mat scala.collection.mutable.ArrayOps$ofRef.map(ArrayOps.scala:186)[0m [31mat org.apache.spark.sql.hudi.command.SqlKeyGenerator.getPartitionPath(SqlKeyGenerator.scala:53)[0m [31mat org.apache.hudi.keygen.BaseKeyGenerator.getKey(BaseKeyGenerator.java:62)[0m [31mat org.apache.hudi.HoodieSparkSqlWriter$$anonfun$1.apply(HoodieSparkSqlWriter.scala:167)[0m [31mat org.apache.hudi.HoodieSparkSqlWriter$$anonfun$1.apply(HoodieSparkSqlWriter.scala:159)[0m ``` and the following seem to fail? ``` [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestTimestampBasedKeyGenerator.test_ExpectsMatch_MultipleInputFormats_ISO8601NoMsWithOffset_OutputTimezoneAsUTC:304 » HoodieKeyGenerator [ERROR] TestTimestampBasedKeyGenerator.test_ExpectsMatch_MultipleInputFormats_ISO8601NoMsZ_OutputTimezoneAsUTC:286 » HoodieKeyGenerator [ERROR] TestTimestampBasedKeyGenerator.test_ExpectsMatch_MultipleInputFormats_ISO8601WithMsWithOffset_OutputTimezoneAsUTC:322 » HoodieKeyGenerator [ERROR] TestTimestampBasedKeyGenerator.test_ExpectsMatch_MultipleInputFormats_ISO8601WithMsZ_OutputTimezoneAsEST:340 » HoodieKeyGenerator [ERROR] TestTimestampBasedKeyGenerator.test_ExpectsMatch_MultipleInputFormats_ISO8601WithMsZ_OutputTimezoneAsUTC:268 » HoodieKeyGenerator [ERROR] TestTimestampBasedKeyGenerator.test_ExpectsMatch_SingleInputFormat_ISO8601WithMsZ_OutputTimezoneAsUTC:232 » HoodieKeyGenerator [ERROR] TestTimestampBasedKeyGenerator.test_ExpectsMatch_SingleInputFormats_ISO8601WithMsZ_OutputTimezoneAsInputDateTimeZone:250 » HoodieKeyGenerator ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377114#comment-17377114 ] ASF GitHub Bot commented on HUDI-1939: -- xushiyan commented on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-876165251 @vinothchandar there is some failed test cases due to some in equivalent API migration. @leoluan2009 im helping move this faster as I'd like to get this resolved before I migrate the hive sync test case which conflicts with this change. Would you also look into the failed UT please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375632#comment-17375632 ] ASF GitHub Bot commented on HUDI-1939: -- vinothchandar commented on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-874366128 @leoluan2009 @xushiyan is this ready for review? In principle, using a java API is better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375561#comment-17375561 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375545#comment-17375545 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375068#comment-17375068 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 94f395cd1cb8bb1c34d9d4d78420ceb718bd1195 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=719) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375058#comment-17375058 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94f395c) into [master](https://codecov.io/gh/apache/hudi/commit/650c4455c600b0346fed8b5b6aa4cc0bf3452e8c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (650c445) will **decrease** coverage by `32.10%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3003 +/- ## = - Coverage 47.54% 15.44% -32.11% + Complexity 5457 479 -4978 = Files 923 280 -643 Lines 4106411583-29481 Branches 4120 950 -3170 = - Hits 19525 1789-17736 + Misses19803 9636-10167 + Partials 1736 158 -1578 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.59%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `5.28% <0.00%> (-49.20%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `58.05% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValu
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375051#comment-17375051 ] ASF GitHub Bot commented on HUDI-1939: -- vinothchandar commented on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-874366128 @leoluan2009 @xushiyan is this ready for review? In principle, using a java API is better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375050#comment-17375050 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94f395c) into [master](https://codecov.io/gh/apache/hudi/commit/650c4455c600b0346fed8b5b6aa4cc0bf3452e8c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (650c445) will **decrease** coverage by `44.66%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3003 +/- ## - Coverage 47.54% 2.88% -44.67% + Complexity 5457 82 -5375 Files 923 280 -643 Lines 41064 11583-29481 Branches 4120 950 -3170 - Hits 19525 334-19191 + Misses19803 11223 -8580 + Partials 1736 26 -1710 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.59%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `5.28% <0.00%> (-49.20%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `9.31% <ø> (-48.72%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValueExtractor.
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375049#comment-17375049 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 25db5fe6198b1e771c45920a6bf6d677c2d20325 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=716) * 94f395cd1cb8bb1c34d9d4d78420ceb718bd1195 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=719) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375048#comment-17375048 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 25db5fe6198b1e771c45920a6bf6d677c2d20325 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=716) * 94f395cd1cb8bb1c34d9d4d78420ceb718bd1195 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375035#comment-17375035 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * 25db5fe6198b1e771c45920a6bf6d677c2d20325 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=716) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375015#comment-17375015 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25db5fe) into [master](https://codecov.io/gh/apache/hudi/commit/650c4455c600b0346fed8b5b6aa4cc0bf3452e8c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (650c445) will **decrease** coverage by `32.10%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3003 +/- ## = - Coverage 47.54% 15.44% -32.11% + Complexity 5457 479 -4978 = Files 923 280 -643 Lines 4106411583-29481 Branches 4120 950 -3170 = - Hits 19525 1789-17736 + Misses19803 9636-10167 + Partials 1736 158 -1578 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.59%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `5.28% <0.00%> (-49.20%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `58.05% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValu
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375010#comment-17375010 ] ASF GitHub Bot commented on HUDI-1939: -- codecov-commenter edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-849682114 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3003](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25db5fe) into [master](https://codecov.io/gh/apache/hudi/commit/650c4455c600b0346fed8b5b6aa4cc0bf3452e8c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (650c445) will **decrease** coverage by `44.66%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3003 +/- ## - Coverage 47.54% 2.88% -44.67% + Complexity 5457 82 -5375 Files 923 280 -643 Lines 41064 11583-29481 Branches 4120 950 -3170 - Hits 19525 334-19191 + Misses19803 11223 -8580 + Partials 1736 26 -1710 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.59%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `5.28% <0.00%> (-49.20%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `9.31% <ø> (-48.72%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/keygen/TimestampBasedAvroKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9UaW1lc3RhbXBCYXNlZEF2cm9LZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-20.26%)` | :arrow_down: | | [...di/keygen/parser/AbstractHoodieDateTimeParser.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvQWJzdHJhY3RIb29kaWVEYXRlVGltZVBhcnNlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9wYXJzZXIvSG9vZGllRGF0ZVRpbWVQYXJzZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-20.00%)` | :arrow_down: | | [...i/hive/SlashEncodedDayPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkRGF5UGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [.../hive/SlashEncodedHourPartitionValueExtractor.
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375008#comment-17375008 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * d526a0f36f8a33f9f6fb75631bc05133dfdfa3ac Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=465) * 25db5fe6198b1e771c45920a6bf6d677c2d20325 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=716) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375006#comment-17375006 ] ASF GitHub Bot commented on HUDI-1939: -- hudi-bot edited a comment on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-862614384 ## CI report: * d526a0f36f8a33f9f6fb75631bc05133dfdfa3ac Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=465) * 25db5fe6198b1e771c45920a6bf6d677c2d20325 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Assignee: Xuedong Luan >Priority: Minor > Labels: pull-request-available > Fix For: 0.9.0 > > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-1939) Replace joda-time api to new jdk8 time api
[ https://issues.apache.org/jira/browse/HUDI-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362366#comment-17362366 ] Raymond Xu commented on HUDI-1939: -- Some previous related discussion https://lists.apache.org/thread.html/ra0bccb431ee61f7580851560e0aa36f2ed81b5e30c3cfef84f33aaad%40%3Cdev.hudi.apache.org%3E > Replace joda-time api to new jdk8 time api > -- > > Key: HUDI-1939 > URL: https://issues.apache.org/jira/browse/HUDI-1939 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Xuedong Luan >Priority: Minor > Labels: pull-request-available > > remove the usage of joda-time api and use the new jdk8 time api -- This message was sent by Atlassian Jira (v8.3.4#803005)
