[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388468#comment-17388468 ] ASF GitHub Bot commented on HUDI-2044: -- nsivabalan merged pull request #3318: URL: https://github.com/apache/hudi/pull/3318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388373#comment-17388373 ] ASF GitHub Bot commented on HUDI-2044: -- hudi-bot edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884006684 ## CI report: * 7a127f223d36925b4e400f8ef3b98bafee5b5544 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1205) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388356#comment-17388356 ] ASF GitHub Bot commented on HUDI-2044: -- hudi-bot edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884006684 ## CI report: * 9c810f152b2504659f0559f4f68d732911198811 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1083) * 7a127f223d36925b4e400f8ef3b98bafee5b5544 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1205) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388355#comment-17388355 ] ASF GitHub Bot commented on HUDI-2044: -- hudi-bot edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884006684 ## CI report: * 9c810f152b2504659f0559f4f68d732911198811 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1083) * 7a127f223d36925b4e400f8ef3b98bafee5b5544 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17387608#comment-17387608 ] ASF GitHub Bot commented on HUDI-2044: -- nsivabalan commented on a change in pull request #3318: URL: https://github.com/apache/hudi/pull/3318#discussion_r676902279 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/SpillableMapBasedFileSystemView.java ## @@ -63,6 +67,9 @@ public SpillableMapBasedFileSystemView(HoodieTableMetaClient metaClient, HoodieT this.maxMemoryForReplaceFileGroups = config.getMaxMemoryForReplacedFileGroups(); this.maxMemoryForClusteringFileGroups = config.getMaxMemoryForPendingClusteringFileGroups(); this.baseStoreDir = config.getSpillableDir(); +HoodieCommonConfig commonConfig = HoodieCommonConfig.newBuilder().fromProperties(config.getProps()).build(); Review comment: Do you think we should pass this config from the caller itself. Basically whereever we create/instantiate FileSystemViewStorageConfig, should also create/instantiate HoodieCommonConfig and pass it along. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385153#comment-17385153 ] ASF GitHub Bot commented on HUDI-2044: -- codecov-commenter edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884133172 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#3318](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9c810f1) into [master](https://codecov.io/gh/apache/hudi/commit/d58a8348dc729c83c60025fc8dbed3ecec28578b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d58a834) will **decrease** coverage by `0.01%`. > The diff coverage is `65.62%`. [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3318/graphs/tree.svg?width=650=150=pr=VTTXabwbs2_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3318 +/- ## - Coverage 45.66% 45.65% -0.02% + Complexity 5600 5597 -3 Files 999 1000 +1 Lines 4378143825 +44 Branches 4403 4403 + Hits 1999320007 +14 - Misses2200422034 +30 Partials 1784 1784 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `40.02% <100.00%> (+0.05%)` | :arrow_up: | | hudiclient | `34.54% <50.00%> (-0.01%)` | :arrow_down: | | hudicommon | `48.66% <66.66%> (+0.01%)` | :arrow_up: | | hudiflink | `59.67% <100.00%> (+0.01%)` | :arrow_up: | | hudihadoopmr | `52.10% <100.00%> (+0.08%)` | :arrow_up: | | hudiintegtest | `0.00% <0.00%> (ø)` | | | hudisparkdatasource | `67.10% <ø> (-0.31%)` | :arrow_down: | | hudisync | `55.97% <ø> (ø)` | | | huditimelineservice | `64.07% <ø> (ø)` | | | hudiutilities | `59.87% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ain/java/org/apache/hudi/io/HoodieMergeHandle.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...metadata/HoodieMetadataMergedLogRecordScanner.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllTWV0YWRhdGFNZXJnZWRMb2dSZWNvcmRTY2FubmVyLmphdmE=) | `0.00% <0.00%> (ø)` | | |
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385151#comment-17385151 ] ASF GitHub Bot commented on HUDI-2044: -- codecov-commenter edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884133172 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#3318](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9c810f1) into [master](https://codecov.io/gh/apache/hudi/commit/d58a8348dc729c83c60025fc8dbed3ecec28578b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d58a834) will **decrease** coverage by `17.96%`. > The diff coverage is `50.00%`. [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3318/graphs/tree.svg?width=650=150=pr=VTTXabwbs2_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3318 +/- ## = - Coverage 45.66% 27.70% -17.97% + Complexity 5600 1325 -4275 = Files 999 390 -609 Lines 4378115580-28201 Branches 4403 1381 -3022 = - Hits 19993 4316-15677 + Misses2200410940-11064 + Partials 1784 324 -1460 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `21.24% <50.00%> (-13.31%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudiintegtest | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <ø> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `59.87% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-43.38%)` | :arrow_down: | | [...ain/java/org/apache/hudi/io/HoodieMergeHandle.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...er/SparkExecuteClusteringCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NsdXN0ZXIvU3BhcmtFeGVjdXRlQ2x1c3RlcmluZ0NvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `89.62% <100.00%> (+0.19%)` | :arrow_up: | | [.../compact/HoodieSparkMergeOnReadTableCompactor.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllU3BhcmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | `94.59% <100.00%> (+0.09%)` | :arrow_up: | |
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385145#comment-17385145 ] ASF GitHub Bot commented on HUDI-2044: -- codecov-commenter edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884133172 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#3318](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9c810f1) into [master](https://codecov.io/gh/apache/hudi/commit/d58a8348dc729c83c60025fc8dbed3ecec28578b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d58a834) will **decrease** coverage by `29.55%`. > The diff coverage is `0.00%`. [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3318/graphs/tree.svg?width=650=150=pr=VTTXabwbs2_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3318 +/- ## = - Coverage 45.66% 16.10% -29.56% + Complexity 5600 505 -5095 = Files 999 284 -715 Lines 4378111870-31911 Branches 4403 986 -3417 = - Hits 19993 1912-18081 + Misses22004 9794-12210 + Partials 1784 164 -1620 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.56%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudiintegtest | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <ø> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `59.87% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-43.38%)` | :arrow_down: | | [...ain/java/org/apache/hudi/io/HoodieMergeHandle.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...main/java/org/apache/hudi/metrics/HoodieGauge.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldHJpY3MvSG9vZGllR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [.../org/apache/hudi/hive/NonPartitionedExtractor.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvTm9uUGFydGl0aW9uZWRFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldHJpY3MvTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | |
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385121#comment-17385121 ] ASF GitHub Bot commented on HUDI-2044: -- hudi-bot edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884006684 ## CI report: * 9c810f152b2504659f0559f4f68d732911198811 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1083) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385101#comment-17385101 ] ASF GitHub Bot commented on HUDI-2044: -- hudi-bot edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884006684 ## CI report: * ac05c5b12e684b878bcb43a46a88d1fb468128f7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1073) * 9c810f152b2504659f0559f4f68d732911198811 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1083) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385100#comment-17385100 ] ASF GitHub Bot commented on HUDI-2044: -- hudi-bot edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884006684 ## CI report: * ac05c5b12e684b878bcb43a46a88d1fb468128f7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1073) * 9c810f152b2504659f0559f4f68d732911198811 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384872#comment-17384872 ] ASF GitHub Bot commented on HUDI-2044: -- codecov-commenter edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884133172 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#3318](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ac05c5b) into [master](https://codecov.io/gh/apache/hudi/commit/d58a8348dc729c83c60025fc8dbed3ecec28578b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d58a834) will **decrease** coverage by `17.96%`. > The diff coverage is `40.00%`. [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3318/graphs/tree.svg?width=650=150=pr=VTTXabwbs2_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3318 +/- ## = - Coverage 45.66% 27.69% -17.97% + Complexity 5600 1325 -4275 = Files 999 390 -609 Lines 4378115582-28199 Branches 4403 1381 -3022 = - Hits 19993 4316-15677 + Misses2200410942-11062 + Partials 1784 324 -1460 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `21.24% <40.00%> (-13.32%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudiintegtest | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <ø> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `59.87% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-43.38%)` | :arrow_down: | | [...ain/java/org/apache/hudi/io/HoodieMergeHandle.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...er/SparkExecuteClusteringCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NsdXN0ZXIvU3BhcmtFeGVjdXRlQ2x1c3RlcmluZ0NvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `89.62% <100.00%> (+0.19%)` | :arrow_up: | | [.../compact/HoodieSparkMergeOnReadTableCompactor.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllU3BhcmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | `94.59% <100.00%> (+0.09%)` | :arrow_up: | |
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384849#comment-17384849 ] ASF GitHub Bot commented on HUDI-2044: -- codecov-commenter commented on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884133172 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#3318](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ac05c5b) into [master](https://codecov.io/gh/apache/hudi/commit/d58a8348dc729c83c60025fc8dbed3ecec28578b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d58a834) will **decrease** coverage by `42.84%`. > The diff coverage is `0.00%`. [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3318/graphs/tree.svg?width=650=150=pr=VTTXabwbs2_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3318 +/- ## - Coverage 45.66% 2.82% -42.85% + Complexity 5600 85 -5515 Files 999 284 -715 Lines 43781 11872-31909 Branches 4403 986 -3417 - Hits 19993 335-19658 + Misses22004 11511-10493 + Partials 1784 26 -1758 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `0.00% <0.00%> (-34.56%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudiintegtest | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <ø> (-51.10%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `8.97% <ø> (-50.91%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-43.38%)` | :arrow_down: | | [...ain/java/org/apache/hudi/io/HoodieMergeHandle.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZU1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/3318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | |
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384774#comment-17384774 ] ASF GitHub Bot commented on HUDI-2044: -- hudi-bot edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884006684 ## CI report: * ac05c5b12e684b878bcb43a46a88d1fb468128f7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1073) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384744#comment-17384744 ] ASF GitHub Bot commented on HUDI-2044: -- hudi-bot edited a comment on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884006684 ## CI report: * ac05c5b12e684b878bcb43a46a88d1fb468128f7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1073) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384742#comment-17384742 ] ASF GitHub Bot commented on HUDI-2044: -- hudi-bot commented on pull request #3318: URL: https://github.com/apache/hudi/pull/3318#issuecomment-884006684 ## CI report: * ac05c5b12e684b878bcb43a46a88d1fb468128f7 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > Labels: pull-request-available > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2044) Extend support for rockDB and compression for Spillable map to all consumers of ExternalSpillableMap
[ https://issues.apache.org/jira/browse/HUDI-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384741#comment-17384741 ] ASF GitHub Bot commented on HUDI-2044: -- rmahindra123 opened a new pull request #3318: URL: https://github.com/apache/hudi/pull/3318 ## What is the purpose of the pull request HUDI-2028 ( #3112, #3117, #3194) implemented rockDb support and compression for bit cask map for External Spillable map and integrated with the HoodieMergeHandle This PR extends the integration of these two features to other consumers, such as SpillableFileSystem and HoodieMergedLogRecordScanner etc. ## Brief change log - Moved configs to HoodieCommonConfig that is a newly created class for common configs - Integrated with SpillableFileSystem and HoodieMergedLogRecordScanner. ## Verify this pull request Added unit tests/ functional tests for different integration points -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Extend support for rockDB and compression for Spillable map to all consumers > of ExternalSpillableMap > > > Key: HUDI-2044 > URL: https://issues.apache.org/jira/browse/HUDI-2044 > Project: Apache Hudi > Issue Type: Improvement >Reporter: Rajesh Mahindra >Assignee: Rajesh Mahindra >Priority: Major > > # HUDI-2028 only implements rockDb support for Spillable map in > HoodieMergeHandle since we are blocked on the configuration refactor PR to > land > # This ticket will track the implementation to extend rocksDB (and > compression for bit cask) support for Spoilable Map to all consumers of > ExternalSpillableMap.java -- This message was sent by Atlassian Jira (v8.3.4#803005)