[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385289#comment-17385289 ] ASF GitHub Bot commented on HUDI-2204: -- garyli1019 commented on pull request #3316: URL: https://github.com/apache/hudi/pull/3316#issuecomment-884689249 Is this change already covered by the existing tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add marker files for flink writer > - > > Key: HUDI-2204 > URL: https://issues.apache.org/jira/browse/HUDI-2204 > Project: Apache Hudi > Issue Type: Improvement > Components: Flink Integration >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385266#comment-17385266 ] ASF GitHub Bot commented on HUDI-2204: -- danny0405 merged pull request #3316: URL: https://github.com/apache/hudi/pull/3316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add marker files for flink writer > - > > Key: HUDI-2204 > URL: https://issues.apache.org/jira/browse/HUDI-2204 > Project: Apache Hudi > Issue Type: Improvement > Components: Flink Integration >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385244#comment-17385244 ] ASF GitHub Bot commented on HUDI-2204: -- yuzhaojing commented on pull request #3316: URL: https://github.com/apache/hudi/pull/3316#issuecomment-884645405 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add marker files for flink writer > - > > Key: HUDI-2204 > URL: https://issues.apache.org/jira/browse/HUDI-2204 > Project: Apache Hudi > Issue Type: Improvement > Components: Flink Integration >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384914#comment-17384914 ] ASF GitHub Bot commented on HUDI-2204: -- codecov-commenter edited a comment on pull request #3316: URL: https://github.com/apache/hudi/pull/3316#issuecomment-884063606 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#3316](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (af1208b) into [master](https://codecov.io/gh/apache/hudi/commit/858e84b5b2f1c5fbd4266922b494ad0d16f5b92a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (858e84b) will **decrease** coverage by `2.15%`. > The diff coverage is `7.14%`. [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3316/graphs/tree.svg?width=650=150=pr=VTTXabwbs2_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3316 +/- ## - Coverage 47.76% 45.61% -2.16% + Complexity 5596 5593 -3 Files 938 999 +61 Lines 4182843782+1954 Branches 4212 4400 +188 - Hits 1998019971 -9 - Misses2006522028+1963 Partials 1783 1783 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `39.97% <ø> (ø)` | | | hudiclient | `34.50% <7.14%> (-0.06%)` | :arrow_down: | | hudicommon | `48.63% <ø> (-0.02%)` | :arrow_down: | | hudiflink | `59.65% <ø> (ø)` | | | hudihadoopmr | `52.02% <ø> (ø)` | | | hudiintegtest | `0.00% <ø> (?)` | | | hudisparkdatasource | `67.04% <ø> (ø)` | | | hudisync | `55.97% <ø> (ø)` | | | huditimelineservice | `64.07% <ø> (ø)` | | | hudiutilities | `59.87% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ain/java/org/apache/hudi/io/FlinkCreateHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtDcmVhdGVIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...org/apache/hudi/io/FlinkMergeAndReplaceHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUFuZFJlcGxhY2VIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...apache/hudi/table/HoodieFlinkCopyOnWriteTable.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtDb3B5T25Xcml0ZVRhYmxlLmphdmE=) | `6.52% <ø> (+0.63%)` | :arrow_up: | |
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384902#comment-17384902 ] ASF GitHub Bot commented on HUDI-2204: -- codecov-commenter edited a comment on pull request #3316: URL: https://github.com/apache/hudi/pull/3316#issuecomment-884063606 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#3316](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (af1208b) into [master](https://codecov.io/gh/apache/hudi/commit/858e84b5b2f1c5fbd4266922b494ad0d16f5b92a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (858e84b) will **decrease** coverage by `3.90%`. > The diff coverage is `7.14%`. [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3316/graphs/tree.svg?width=650=150=pr=VTTXabwbs2_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3316 +/- ## - Coverage 47.76% 43.86% -3.91% + Complexity 5596 4776 -820 Files 938 893 -45 Lines 4182840076-1752 Branches 4212 4005 -207 - Hits 1998017578-2402 - Misses2006520874 +809 + Partials 1783 1624 -159 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `39.97% <ø> (ø)` | | | hudiclient | `22.99% <7.14%> (-11.56%)` | :arrow_down: | | hudicommon | `48.63% <ø> (-0.02%)` | :arrow_down: | | hudiflink | `59.65% <ø> (ø)` | | | hudihadoopmr | `52.02% <ø> (ø)` | | | hudiintegtest | `0.00% <ø> (?)` | | | hudisparkdatasource | `67.04% <ø> (ø)` | | | hudisync | `55.97% <ø> (ø)` | | | huditimelineservice | `64.07% <ø> (ø)` | | | hudiutilities | `59.87% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ain/java/org/apache/hudi/io/FlinkCreateHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtDcmVhdGVIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...org/apache/hudi/io/FlinkMergeAndReplaceHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUFuZFJlcGxhY2VIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...apache/hudi/table/HoodieFlinkCopyOnWriteTable.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtDb3B5T25Xcml0ZVRhYmxlLmphdmE=) | `6.52% <ø> (+0.63%)` | :arrow_up: | |
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384813#comment-17384813 ] ASF GitHub Bot commented on HUDI-2204: -- danny0405 closed pull request #3316: URL: https://github.com/apache/hudi/pull/3316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add marker files for flink writer > - > > Key: HUDI-2204 > URL: https://issues.apache.org/jira/browse/HUDI-2204 > Project: Apache Hudi > Issue Type: Improvement > Components: Flink Integration >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384814#comment-17384814 ] ASF GitHub Bot commented on HUDI-2204: -- danny0405 opened a new pull request #3316: URL: https://github.com/apache/hudi/pull/3316 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the pull request *(For example: This pull request adds quick-start document.)* ## Brief change log *(for example:)* - *Modify AnnotationLocation checkstyle rule in checkstyle.xml* ## Verify this pull request *(Please pick either of the following options)* This pull request is a trivial rework / code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end.* - *Added HoodieClientWriteTest to verify the change.* - *Manually verified the change by running a job locally.* ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary doc changes done or have another open PR - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add marker files for flink writer > - > > Key: HUDI-2204 > URL: https://issues.apache.org/jira/browse/HUDI-2204 > Project: Apache Hudi > Issue Type: Improvement > Components: Flink Integration >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384806#comment-17384806 ] ASF GitHub Bot commented on HUDI-2204: -- codecov-commenter commented on pull request #3316: URL: https://github.com/apache/hudi/pull/3316#issuecomment-884063606 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#3316](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (af1208b) into [master](https://codecov.io/gh/apache/hudi/commit/858e84b5b2f1c5fbd4266922b494ad0d16f5b92a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (858e84b) will **decrease** coverage by `10.38%`. > The diff coverage is `7.14%`. [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3316/graphs/tree.svg?width=650=150=pr=VTTXabwbs2_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3316 +/- ## = - Coverage 47.76% 37.38% -10.39% + Complexity 5596 3446 -2150 = Files 938 787 -151 Lines 4182833361 -8467 Branches 4212 3264 -948 = - Hits 1998012472 -7508 + Misses2006519735 -330 + Partials 1783 1154 -629 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `39.97% <ø> (ø)` | | | hudiclient | `22.99% <7.14%> (-11.56%)` | :arrow_down: | | hudicommon | `48.63% <ø> (-0.02%)` | :arrow_down: | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudiintegtest | `0.00% <ø> (?)` | | | hudisparkdatasource | `67.04% <ø> (ø)` | | | hudisync | `55.97% <ø> (ø)` | | | huditimelineservice | `64.07% <ø> (ø)` | | | hudiutilities | `7.88% <ø> (-52.00%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ain/java/org/apache/hudi/io/FlinkCreateHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtDcmVhdGVIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...org/apache/hudi/io/FlinkMergeAndReplaceHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUFuZFJlcGxhY2VIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...apache/hudi/table/HoodieFlinkCopyOnWriteTable.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtDb3B5T25Xcml0ZVRhYmxlLmphdmE=) | `6.52% <ø> (+0.63%)` | :arrow_up: | |
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384807#comment-17384807 ] ASF GitHub Bot commented on HUDI-2204: -- codecov-commenter edited a comment on pull request #3316: URL: https://github.com/apache/hudi/pull/3316#issuecomment-884063606 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#3316](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (af1208b) into [master](https://codecov.io/gh/apache/hudi/commit/858e84b5b2f1c5fbd4266922b494ad0d16f5b92a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (858e84b) will **decrease** coverage by `7.33%`. > The diff coverage is `7.14%`. [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3316/graphs/tree.svg?width=650=150=pr=VTTXabwbs2_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#3316 +/- ## - Coverage 47.76% 40.43% -7.34% + Complexity 5596 4336-1260 Files 938 885 -53 Lines 4182839351-2477 Branches 4212 3947 -265 - Hits 1998015910-4070 - Misses2006521960+1895 + Partials 1783 1481 -302 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `39.97% <ø> (ø)` | | | hudiclient | `22.99% <7.14%> (-11.56%)` | :arrow_down: | | hudicommon | `48.63% <ø> (-0.02%)` | :arrow_down: | | hudiflink | `59.65% <ø> (ø)` | | | hudihadoopmr | `52.02% <ø> (ø)` | | | hudiintegtest | `0.00% <ø> (?)` | | | hudisparkdatasource | `67.04% <ø> (ø)` | | | hudisync | `55.97% <ø> (ø)` | | | huditimelineservice | `64.07% <ø> (ø)` | | | hudiutilities | `7.88% <ø> (-52.00%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3316?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ain/java/org/apache/hudi/io/FlinkCreateHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtDcmVhdGVIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...org/apache/hudi/io/FlinkMergeAndReplaceHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUFuZFJlcGxhY2VIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...main/java/org/apache/hudi/io/FlinkMergeHandle.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vRmxpbmtNZXJnZUhhbmRsZS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...apache/hudi/table/HoodieFlinkCopyOnWriteTable.java](https://codecov.io/gh/apache/hudi/pull/3316/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtDb3B5T25Xcml0ZVRhYmxlLmphdmE=) | `6.52% <ø> (+0.63%)` | :arrow_up: | |
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384726#comment-17384726 ] ASF GitHub Bot commented on HUDI-2204: -- hudi-bot edited a comment on pull request #3316: URL: https://github.com/apache/hudi/pull/3316#issuecomment-883947729 ## CI report: * af1208b95c176426fd0d1adf78392e57c23ae522 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1069) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add marker files for flink writer > - > > Key: HUDI-2204 > URL: https://issues.apache.org/jira/browse/HUDI-2204 > Project: Apache Hudi > Issue Type: Improvement > Components: Flink Integration >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384706#comment-17384706 ] ASF GitHub Bot commented on HUDI-2204: -- hudi-bot edited a comment on pull request #3316: URL: https://github.com/apache/hudi/pull/3316#issuecomment-883947729 ## CI report: * af1208b95c176426fd0d1adf78392e57c23ae522 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1069) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add marker files for flink writer > - > > Key: HUDI-2204 > URL: https://issues.apache.org/jira/browse/HUDI-2204 > Project: Apache Hudi > Issue Type: Improvement > Components: Flink Integration >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384703#comment-17384703 ] ASF GitHub Bot commented on HUDI-2204: -- hudi-bot commented on pull request #3316: URL: https://github.com/apache/hudi/pull/3316#issuecomment-883947729 ## CI report: * af1208b95c176426fd0d1adf78392e57c23ae522 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add marker files for flink writer > - > > Key: HUDI-2204 > URL: https://issues.apache.org/jira/browse/HUDI-2204 > Project: Apache Hudi > Issue Type: Improvement > Components: Flink Integration >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2204) Add marker files for flink writer
[ https://issues.apache.org/jira/browse/HUDI-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384702#comment-17384702 ] ASF GitHub Bot commented on HUDI-2204: -- danny0405 opened a new pull request #3316: URL: https://github.com/apache/hudi/pull/3316 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the pull request *(For example: This pull request adds quick-start document.)* ## Brief change log *(for example:)* - *Modify AnnotationLocation checkstyle rule in checkstyle.xml* ## Verify this pull request *(Please pick either of the following options)* This pull request is a trivial rework / code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end.* - *Added HoodieClientWriteTest to verify the change.* - *Manually verified the change by running a job locally.* ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary doc changes done or have another open PR - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add marker files for flink writer > - > > Key: HUDI-2204 > URL: https://issues.apache.org/jira/browse/HUDI-2204 > Project: Apache Hudi > Issue Type: Improvement > Components: Flink Integration >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)