[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[ https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411561#comment-17411561 ] ASF GitHub Bot commented on HUDI-2248: -- vinothchandar commented on pull request #3364: URL: https://github.com/apache/hudi/pull/3364#issuecomment-914657649 @jsbali gentle ping on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to shutdown local metastore client > - > > Key: HUDI-2248 > URL: https://issues.apache.org/jira/browse/HUDI-2248 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Jagmeet Bali >Priority: Minor > Labels: pull-request-available > > https://github.com/apache/hudi/issues/3187 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[
https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396934#comment-17396934
]
ASF GitHub Bot commented on HUDI-2248:
--
vinothchandar commented on a change in pull request #3364:
URL: https://github.com/apache/hudi/pull/3364#discussion_r686376968
##
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##
@@ -295,7 +295,7 @@ public void close() {
try {
ddlExecutor.close();
if (client != null) {
-client.close();
+Hive.closeCurrent();
client = null;
Review comment:
@jsbali do you plan to update this PR with the other fixes as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to shutdown local metastore client
> -
>
> Key: HUDI-2248
> URL: https://issues.apache.org/jira/browse/HUDI-2248
> Project: Apache Hudi
> Issue Type: New Feature
>Reporter: Jagmeet Bali
>Priority: Minor
> Labels: pull-request-available
>
> https://github.com/apache/hudi/issues/3187
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[ https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395796#comment-17395796 ] ASF GitHub Bot commented on HUDI-2248: -- hudi-bot edited a comment on pull request #3364: URL: https://github.com/apache/hudi/pull/3364#issuecomment-888212752 ## CI report: * 4478e888fd500a04ba27b2d76fbadbf92dce16de Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1222) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to shutdown local metastore client > - > > Key: HUDI-2248 > URL: https://issues.apache.org/jira/browse/HUDI-2248 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Jagmeet Bali >Priority: Minor > Labels: pull-request-available > > https://github.com/apache/hudi/issues/3187 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[ https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395628#comment-17395628 ] ASF GitHub Bot commented on HUDI-2248: -- hudi-bot edited a comment on pull request #3364: URL: https://github.com/apache/hudi/pull/3364#issuecomment-888212752 ## CI report: * 4478e888fd500a04ba27b2d76fbadbf92dce16de Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1222) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to shutdown local metastore client > - > > Key: HUDI-2248 > URL: https://issues.apache.org/jira/browse/HUDI-2248 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Jagmeet Bali >Priority: Minor > Labels: pull-request-available > > https://github.com/apache/hudi/issues/3187 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[
https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391194#comment-17391194
]
ASF GitHub Bot commented on HUDI-2248:
--
jsbali commented on a change in pull request #3364:
URL: https://github.com/apache/hudi/pull/3364#discussion_r680533347
##
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##
@@ -295,7 +295,7 @@ public void close() {
try {
ddlExecutor.close();
if (client != null) {
-client.close();
+Hive.closeCurrent();
client = null;
Review comment:
Sure @yanghua will take a look and fix those as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to shutdown local metastore client
> -
>
> Key: HUDI-2248
> URL: https://issues.apache.org/jira/browse/HUDI-2248
> Project: Apache Hudi
> Issue Type: New Feature
>Reporter: Jagmeet Bali
>Priority: Minor
> Labels: pull-request-available
>
> https://github.com/apache/hudi/issues/3187
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[
https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390842#comment-17390842
]
ASF GitHub Bot commented on HUDI-2248:
--
yanghua commented on a change in pull request #3364:
URL: https://github.com/apache/hudi/pull/3364#discussion_r680292542
##
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##
@@ -295,7 +295,7 @@ public void close() {
try {
ddlExecutor.close();
if (client != null) {
-client.close();
+Hive.closeCurrent();
client = null;
Review comment:
@jsbali I just quickly search the whole project, it seems there are
still other cases that call the `close` method directly. Can you fix them
passingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to shutdown local metastore client
> -
>
> Key: HUDI-2248
> URL: https://issues.apache.org/jira/browse/HUDI-2248
> Project: Apache Hudi
> Issue Type: New Feature
>Reporter: Jagmeet Bali
>Priority: Minor
> Labels: pull-request-available
>
> https://github.com/apache/hudi/issues/3187
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[
https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390218#comment-17390218
]
ASF GitHub Bot commented on HUDI-2248:
--
danny0405 commented on a change in pull request #3364:
URL: https://github.com/apache/hudi/pull/3364#discussion_r679567759
##
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##
@@ -295,7 +295,7 @@ public void close() {
try {
ddlExecutor.close();
if (client != null) {
-client.close();
+Hive.closeCurrent();
client = null;
Review comment:
Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to shutdown local metastore client
> -
>
> Key: HUDI-2248
> URL: https://issues.apache.org/jira/browse/HUDI-2248
> Project: Apache Hudi
> Issue Type: New Feature
>Reporter: Jagmeet Bali
>Priority: Minor
> Labels: pull-request-available
>
> https://github.com/apache/hudi/issues/3187
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[
https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390181#comment-17390181
]
ASF GitHub Bot commented on HUDI-2248:
--
jsbali commented on a change in pull request #3364:
URL: https://github.com/apache/hudi/pull/3364#discussion_r679515765
##
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##
@@ -295,7 +295,7 @@ public void close() {
try {
ddlExecutor.close();
if (client != null) {
-client.close();
+Hive.closeCurrent();
client = null;
Review comment:
We get a new hms client as follows
`Hive.get(configuration).getMSC(); `
which creates the client and saves it in a ThreadLocal map as well.
So if we ask for hms client at multiple places then close can only be called
on the client only once.
So we resort to
`Hive.closeCurrent()`
which first checks in the ThreadLocal map and if the client is there, then
only tries to close it. So further invocations don't throw exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to shutdown local metastore client
> -
>
> Key: HUDI-2248
> URL: https://issues.apache.org/jira/browse/HUDI-2248
> Project: Apache Hudi
> Issue Type: New Feature
>Reporter: Jagmeet Bali
>Priority: Minor
> Labels: pull-request-available
>
> https://github.com/apache/hudi/issues/3187
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[ https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388729#comment-17388729 ] ASF GitHub Bot commented on HUDI-2248: -- hudi-bot edited a comment on pull request #3364: URL: https://github.com/apache/hudi/pull/3364#issuecomment-888212752 ## CI report: * 4478e888fd500a04ba27b2d76fbadbf92dce16de Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1222) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to shutdown local metastore client > - > > Key: HUDI-2248 > URL: https://issues.apache.org/jira/browse/HUDI-2248 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Jagmeet Bali >Priority: Minor > Labels: pull-request-available > > https://github.com/apache/hudi/issues/3187 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[
https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388728#comment-17388728
]
ASF GitHub Bot commented on HUDI-2248:
--
danny0405 commented on a change in pull request #3364:
URL: https://github.com/apache/hudi/pull/3364#discussion_r678228208
##
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##
@@ -295,7 +295,7 @@ public void close() {
try {
ddlExecutor.close();
if (client != null) {
-client.close();
+Hive.closeCurrent();
client = null;
Review comment:
What's the difference ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to shutdown local metastore client
> -
>
> Key: HUDI-2248
> URL: https://issues.apache.org/jira/browse/HUDI-2248
> Project: Apache Hudi
> Issue Type: New Feature
>Reporter: Jagmeet Bali
>Priority: Minor
> Labels: pull-request-available
>
> https://github.com/apache/hudi/issues/3187
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[ https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388685#comment-17388685 ] ASF GitHub Bot commented on HUDI-2248: -- hudi-bot edited a comment on pull request #3364: URL: https://github.com/apache/hudi/pull/3364#issuecomment-888212752 ## CI report: * 4478e888fd500a04ba27b2d76fbadbf92dce16de Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1222) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to shutdown local metastore client > - > > Key: HUDI-2248 > URL: https://issues.apache.org/jira/browse/HUDI-2248 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Jagmeet Bali >Priority: Minor > Labels: pull-request-available > > https://github.com/apache/hudi/issues/3187 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[ https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388684#comment-17388684 ] ASF GitHub Bot commented on HUDI-2248: -- hudi-bot commented on pull request #3364: URL: https://github.com/apache/hudi/pull/3364#issuecomment-888212752 ## CI report: * 4478e888fd500a04ba27b2d76fbadbf92dce16de UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to shutdown local metastore client > - > > Key: HUDI-2248 > URL: https://issues.apache.org/jira/browse/HUDI-2248 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Jagmeet Bali >Priority: Minor > Labels: pull-request-available > > https://github.com/apache/hudi/issues/3187 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2248) Unable to shutdown local metastore client
[ https://issues.apache.org/jira/browse/HUDI-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388683#comment-17388683 ] ASF GitHub Bot commented on HUDI-2248: -- jsbali opened a new pull request #3364: URL: https://github.com/apache/hudi/pull/3364 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the pull request *(For example: This pull request adds quick-start document.)* ## Brief change log *(for example:)* - *Modify AnnotationLocation checkstyle rule in checkstyle.xml* ## Verify this pull request *(Please pick either of the following options)* This pull request is a trivial rework / code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end.* - *Added HoodieClientWriteTest to verify the change.* - *Manually verified the change by running a job locally.* ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary doc changes done or have another open PR - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unable to shutdown local metastore client > - > > Key: HUDI-2248 > URL: https://issues.apache.org/jira/browse/HUDI-2248 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Jagmeet Bali >Priority: Minor > > https://github.com/apache/hudi/issues/3187 -- This message was sent by Atlassian Jira (v8.3.4#803005)
