[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[ https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391988#comment-17391988 ] ASF GitHub Bot commented on HUDI-2269: -- danny0405 merged pull request #3384: URL: https://github.com/apache/hudi/pull/3384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Release the disk map resource for flink streaming reader > > > Key: HUDI-2269 > URL: https://issues.apache.org/jira/browse/HUDI-2269 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[
https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391978#comment-17391978
]
ASF GitHub Bot commented on HUDI-2269:
--
danny0405 commented on a change in pull request #3384:
URL: https://github.com/apache/hudi/pull/3384#discussion_r681450750
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##
@@ -357,7 +357,6 @@ public void write(GenericRecord oldRecord) {
}
}
- keyToNewRecords.clear();
((ExternalSpillableMap) keyToNewRecords).close();
Review comment:
The `close` method already release the `inMemoryMap` so that we can
remove the invocation of `clear`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Release the disk map resource for flink streaming reader
>
>
> Key: HUDI-2269
> URL: https://issues.apache.org/jira/browse/HUDI-2269
> Project: Apache Hudi
> Issue Type: New Feature
>Reporter: Danny Chen
>Assignee: Danny Chen
>Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[ https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391976#comment-17391976 ] ASF GitHub Bot commented on HUDI-2269: -- yuzhaojing commented on pull request #3384: URL: https://github.com/apache/hudi/pull/3384#issuecomment-891545559 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Release the disk map resource for flink streaming reader > > > Key: HUDI-2269 > URL: https://issues.apache.org/jira/browse/HUDI-2269 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[ https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391972#comment-17391972 ] ASF GitHub Bot commented on HUDI-2269: -- hudi-bot edited a comment on pull request #3384: URL: https://github.com/apache/hudi/pull/3384#issuecomment-891490405 ## CI report: * a0c0fafbb757b6cd0874e7887cd2ce03360ffcea UNKNOWN * b6089f36dd4506f79a64bd4f0ec74135e632801d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1314) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Release the disk map resource for flink streaming reader > > > Key: HUDI-2269 > URL: https://issues.apache.org/jira/browse/HUDI-2269 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[ https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391943#comment-17391943 ] ASF GitHub Bot commented on HUDI-2269: -- hudi-bot edited a comment on pull request #3384: URL: https://github.com/apache/hudi/pull/3384#issuecomment-891490405 ## CI report: * 271a1306778f9d3c5dc24324d57686b529dbde7f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1311) * a0c0fafbb757b6cd0874e7887cd2ce03360ffcea UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Release the disk map resource for flink streaming reader > > > Key: HUDI-2269 > URL: https://issues.apache.org/jira/browse/HUDI-2269 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[ https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391953#comment-17391953 ] ASF GitHub Bot commented on HUDI-2269: -- hudi-bot edited a comment on pull request #3384: URL: https://github.com/apache/hudi/pull/3384#issuecomment-891490405 ## CI report: * 271a1306778f9d3c5dc24324d57686b529dbde7f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1311) * a0c0fafbb757b6cd0874e7887cd2ce03360ffcea UNKNOWN * b6089f36dd4506f79a64bd4f0ec74135e632801d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1314) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Release the disk map resource for flink streaming reader > > > Key: HUDI-2269 > URL: https://issues.apache.org/jira/browse/HUDI-2269 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[ https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391949#comment-17391949 ] ASF GitHub Bot commented on HUDI-2269: -- hudi-bot edited a comment on pull request #3384: URL: https://github.com/apache/hudi/pull/3384#issuecomment-891490405 ## CI report: * 271a1306778f9d3c5dc24324d57686b529dbde7f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1311) * a0c0fafbb757b6cd0874e7887cd2ce03360ffcea UNKNOWN * b6089f36dd4506f79a64bd4f0ec74135e632801d UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Release the disk map resource for flink streaming reader > > > Key: HUDI-2269 > URL: https://issues.apache.org/jira/browse/HUDI-2269 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[ https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391944#comment-17391944 ] ASF GitHub Bot commented on HUDI-2269: -- hudi-bot edited a comment on pull request #3384: URL: https://github.com/apache/hudi/pull/3384#issuecomment-891490405 ## CI report: * 271a1306778f9d3c5dc24324d57686b529dbde7f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1311) * a0c0fafbb757b6cd0874e7887cd2ce03360ffcea UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Release the disk map resource for flink streaming reader > > > Key: HUDI-2269 > URL: https://issues.apache.org/jira/browse/HUDI-2269 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[ https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391925#comment-17391925 ] ASF GitHub Bot commented on HUDI-2269: -- hudi-bot edited a comment on pull request #3384: URL: https://github.com/apache/hudi/pull/3384#issuecomment-891490405 ## CI report: * 271a1306778f9d3c5dc24324d57686b529dbde7f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1311) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Release the disk map resource for flink streaming reader > > > Key: HUDI-2269 > URL: https://issues.apache.org/jira/browse/HUDI-2269 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[ https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391923#comment-17391923 ] ASF GitHub Bot commented on HUDI-2269: -- hudi-bot commented on pull request #3384: URL: https://github.com/apache/hudi/pull/3384#issuecomment-891490405 ## CI report: * 271a1306778f9d3c5dc24324d57686b529dbde7f UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis` re-run the last Travis build - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Release the disk map resource for flink streaming reader > > > Key: HUDI-2269 > URL: https://issues.apache.org/jira/browse/HUDI-2269 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-2269) Release the disk map resource for flink streaming reader
[ https://issues.apache.org/jira/browse/HUDI-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391919#comment-17391919 ] ASF GitHub Bot commented on HUDI-2269: -- danny0405 opened a new pull request #3384: URL: https://github.com/apache/hudi/pull/3384 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the pull request *(For example: This pull request adds quick-start document.)* ## Brief change log *(for example:)* - *Modify AnnotationLocation checkstyle rule in checkstyle.xml* ## Verify this pull request *(Please pick either of the following options)* This pull request is a trivial rework / code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end.* - *Added HoodieClientWriteTest to verify the change.* - *Manually verified the change by running a job locally.* ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary doc changes done or have another open PR - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Release the disk map resource for flink streaming reader > > > Key: HUDI-2269 > URL: https://issues.apache.org/jira/browse/HUDI-2269 > Project: Apache Hudi > Issue Type: New Feature >Reporter: Danny Chen >Assignee: Danny Chen >Priority: Major > Fix For: 0.9.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
