Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
codope merged PR #10970: URL: https://github.com/apache/hudi/pull/10970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
wombatu-kun commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2048912318 @codope all comments are fixed, tests pass, PR is ready to be merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2048908454 ## CI report: * fca1f1be665d9aff53a9d755fccfc52d0535eccd Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23183) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2048840362 ## CI report: * 8ab6f394dd71631fd7be5d8ef6fcceb7ac89e584 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23172) * fca1f1be665d9aff53a9d755fccfc52d0535eccd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23183) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2048835453 ## CI report: * 8ab6f394dd71631fd7be5d8ef6fcceb7ac89e584 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23172) * fca1f1be665d9aff53a9d755fccfc52d0535eccd UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2047880233 ## CI report: * 8ab6f394dd71631fd7be5d8ef6fcceb7ac89e584 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23172) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2047863708 ## CI report: * 8ab6f394dd71631fd7be5d8ef6fcceb7ac89e584 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23172) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
wombatu-kun commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2047788583 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2047755640 ## CI report: * 8ab6f394dd71631fd7be5d8ef6fcceb7ac89e584 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23172) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2047595637 ## CI report: * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) * 8ab6f394dd71631fd7be5d8ef6fcceb7ac89e584 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23172) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2047572876 ## CI report: * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) * 8ab6f394dd71631fd7be5d8ef6fcceb7ac89e584 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046915753 ## CI report: * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046898402 ## CI report: * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
wombatu-kun commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046784206 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046531797 ## CI report: * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046526783 ## CI report: * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
wombatu-kun commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046522508 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046521306 ## CI report: * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046491796 ## CI report: * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
wombatu-kun commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046489546 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046487469 ## CI report: * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046353603 ## CI report: * a1a3769da4ed0f516a25cf5f030bf4eafb1a74f1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23163) * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046308222 ## CI report: * 1b65081255315b4c5129b2d5ccea4c097ca15649 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23137) * a1a3769da4ed0f516a25cf5f030bf4eafb1a74f1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23163) * dbceeac96d98d8b87a3a771650d59554480cca16 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23165) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046302372 ## CI report: * 1b65081255315b4c5129b2d5ccea4c097ca15649 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23137) * a1a3769da4ed0f516a25cf5f030bf4eafb1a74f1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23163) * dbceeac96d98d8b87a3a771650d59554480cca16 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046256409 ## CI report: * 1b65081255315b4c5129b2d5ccea4c097ca15649 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23137) * a1a3769da4ed0f516a25cf5f030bf4eafb1a74f1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23163) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046251558 ## CI report: * 1b65081255315b4c5129b2d5ccea4c097ca15649 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23137) * a1a3769da4ed0f516a25cf5f030bf4eafb1a74f1 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
wombatu-kun commented on code in PR #10970:
URL: https://github.com/apache/hudi/pull/10970#discussion_r1558520013
##
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:
##
@@ -101,43 +107,85 @@ private void mockResponse(int statusCode) {
}
@Test
- public void sendPayloadShouldLogWhenRequestFailed() throws IOException {
+ void sendPayloadShouldLogWhenRequestFailed() throws IOException {
when(httpClient.execute(any())).thenThrow(IOException.class);
HoodieWriteCommitHttpCallbackClient hoodieWriteCommitCallBackHttpClient =
-new HoodieWriteCommitHttpCallbackClient("fake_api_key", "fake_url",
httpClient);
-hoodieWriteCommitCallBackHttpClient.send("{}");
+new HoodieWriteCommitHttpCallbackClient(FAKE_API_KEY, FAKE_URL,
httpClient, null);
+hoodieWriteCommitCallBackHttpClient.send(CALLBACK_MSG);
verify(appender).append(logCaptor.capture());
assertEquals("Failed to send callback.",
logCaptor.getValue().getMessage().getFormattedMessage());
assertEquals(Level.WARN, logCaptor.getValue().getLevel());
}
@Test
- public void sendPayloadShouldLogUnsuccessfulSending() {
+ void sendPayloadShouldLogUnsuccessfulSending() {
mockResponse(401);
when(httpResponse.toString()).thenReturn("unauthorized");
HoodieWriteCommitHttpCallbackClient hoodieWriteCommitCallBackHttpClient =
-new HoodieWriteCommitHttpCallbackClient("fake_api_key", "fake_url",
httpClient);
-hoodieWriteCommitCallBackHttpClient.send("{}");
+new HoodieWriteCommitHttpCallbackClient(FAKE_API_KEY, FAKE_URL,
httpClient, null);
+hoodieWriteCommitCallBackHttpClient.send(CALLBACK_MSG);
verify(appender).append(logCaptor.capture());
assertEquals("Failed to send callback message. Response was unauthorized",
logCaptor.getValue().getMessage().getFormattedMessage());
assertEquals(Level.WARN, logCaptor.getValue().getLevel());
}
@Test
- public void sendPayloadShouldLogSuccessfulSending() {
+ void sendPayloadShouldLogSuccessfulSending() {
mockResponse(202);
+Map customHeaders = new HashMap<>();
+customHeaders.put("key1", "val1");
+customHeaders.put("key2", "val2");
HoodieWriteCommitHttpCallbackClient hoodieWriteCommitCallBackHttpClient =
-new HoodieWriteCommitHttpCallbackClient("fake_api_key", "fake_url",
httpClient);
-hoodieWriteCommitCallBackHttpClient.send("{}");
+new HoodieWriteCommitHttpCallbackClient(FAKE_API_KEY, FAKE_URL,
httpClient, customHeaders);
+hoodieWriteCommitCallBackHttpClient.send(CALLBACK_MSG);
verify(appender).append(logCaptor.capture());
-
assertTrue(logCaptor.getValue().getMessage().getFormattedMessage().startsWith("Sent
Callback data"));
+
assertTrue(logCaptor.getValue().getMessage().getFormattedMessage().startsWith("Sent
Callback data with 2 custom headers"));
assertEquals(Level.INFO, logCaptor.getValue().getLevel());
}
+ @Test
+ void testParsingCustomHeaders() {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
wombatu-kun commented on code in PR #10970:
URL: https://github.com/apache/hudi/pull/10970#discussion_r1558519043
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/callback/client/http/HoodieWriteCommitHttpCallbackClient.java:
##
@@ -43,36 +48,42 @@ public class HoodieWriteCommitHttpCallbackClient implements
Closeable {
private static final Logger LOG =
LoggerFactory.getLogger(HoodieWriteCommitHttpCallbackClient.class);
public static final String HEADER_KEY_API_KEY = "HUDI-CALLBACK-KEY";
+ public static final String HEADERS_DELIMITER = ";";
+ public static final String HEADERS_KV_DELIMITER = ":";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
wombatu-kun commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2046239954 > Thanks for adding this. Left a couple of minor comments. May I know what usecase prompted to add this capability? The usecase is from this issue: https://github.com/apache/hudi/issues/8834 "API require HTTP basic authentication, which means we must provide a username and password." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
codope commented on code in PR #10970:
URL: https://github.com/apache/hudi/pull/10970#discussion_r1557488353
##
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:
##
@@ -101,43 +107,85 @@ private void mockResponse(int statusCode) {
}
@Test
- public void sendPayloadShouldLogWhenRequestFailed() throws IOException {
+ void sendPayloadShouldLogWhenRequestFailed() throws IOException {
when(httpClient.execute(any())).thenThrow(IOException.class);
HoodieWriteCommitHttpCallbackClient hoodieWriteCommitCallBackHttpClient =
-new HoodieWriteCommitHttpCallbackClient("fake_api_key", "fake_url",
httpClient);
-hoodieWriteCommitCallBackHttpClient.send("{}");
+new HoodieWriteCommitHttpCallbackClient(FAKE_API_KEY, FAKE_URL,
httpClient, null);
+hoodieWriteCommitCallBackHttpClient.send(CALLBACK_MSG);
verify(appender).append(logCaptor.capture());
assertEquals("Failed to send callback.",
logCaptor.getValue().getMessage().getFormattedMessage());
assertEquals(Level.WARN, logCaptor.getValue().getLevel());
}
@Test
- public void sendPayloadShouldLogUnsuccessfulSending() {
+ void sendPayloadShouldLogUnsuccessfulSending() {
mockResponse(401);
when(httpResponse.toString()).thenReturn("unauthorized");
HoodieWriteCommitHttpCallbackClient hoodieWriteCommitCallBackHttpClient =
-new HoodieWriteCommitHttpCallbackClient("fake_api_key", "fake_url",
httpClient);
-hoodieWriteCommitCallBackHttpClient.send("{}");
+new HoodieWriteCommitHttpCallbackClient(FAKE_API_KEY, FAKE_URL,
httpClient, null);
+hoodieWriteCommitCallBackHttpClient.send(CALLBACK_MSG);
verify(appender).append(logCaptor.capture());
assertEquals("Failed to send callback message. Response was unauthorized",
logCaptor.getValue().getMessage().getFormattedMessage());
assertEquals(Level.WARN, logCaptor.getValue().getLevel());
}
@Test
- public void sendPayloadShouldLogSuccessfulSending() {
+ void sendPayloadShouldLogSuccessfulSending() {
mockResponse(202);
+Map customHeaders = new HashMap<>();
+customHeaders.put("key1", "val1");
+customHeaders.put("key2", "val2");
HoodieWriteCommitHttpCallbackClient hoodieWriteCommitCallBackHttpClient =
-new HoodieWriteCommitHttpCallbackClient("fake_api_key", "fake_url",
httpClient);
-hoodieWriteCommitCallBackHttpClient.send("{}");
+new HoodieWriteCommitHttpCallbackClient(FAKE_API_KEY, FAKE_URL,
httpClient, customHeaders);
+hoodieWriteCommitCallBackHttpClient.send(CALLBACK_MSG);
verify(appender).append(logCaptor.capture());
-
assertTrue(logCaptor.getValue().getMessage().getFormattedMessage().startsWith("Sent
Callback data"));
+
assertTrue(logCaptor.getValue().getMessage().getFormattedMessage().startsWith("Sent
Callback data with 2 custom headers"));
assertEquals(Level.INFO, logCaptor.getValue().getLevel());
}
+ @Test
+ void testParsingCustomHeaders() {
Review Comment:
let's also test some negative scenarios when customer header is null/empty.
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/callback/client/http/HoodieWriteCommitHttpCallbackClient.java:
##
@@ -43,36 +48,42 @@ public class HoodieWriteCommitHttpCallbackClient implements
Closeable {
private static final Logger LOG =
LoggerFactory.getLogger(HoodieWriteCommitHttpCallbackClient.class);
public static final String HEADER_KEY_API_KEY = "HUDI-CALLBACK-KEY";
+ public static final String HEADERS_DELIMITER = ";";
+ public static final String HEADERS_KV_DELIMITER = ":";
Review Comment:
Can these be private or package-protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2041536022 ## CI report: * 1b65081255315b4c5129b2d5ccea4c097ca15649 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23137) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2041508051 ## CI report: * 1b65081255315b4c5129b2d5ccea4c097ca15649 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23137) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6441] Passing custom Headers with Hudi Callback URL [hudi]
hudi-bot commented on PR #10970: URL: https://github.com/apache/hudi/pull/10970#issuecomment-2041505684 ## CI report: * 1b65081255315b4c5129b2d5ccea4c097ca15649 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
