Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
danny0405 merged PR #9836: URL: https://github.com/apache/hudi/pull/9836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
wecharyu commented on PR #9836: URL: https://github.com/apache/hudi/pull/9836#issuecomment-1765583468 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
hudi-bot commented on PR #9836: URL: https://github.com/apache/hudi/pull/9836#issuecomment-1759954273 ## CI report: * c19e0177a8ab98a26370cc238c20b72bfb4abd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20307) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
hudi-bot commented on PR #9836: URL: https://github.com/apache/hudi/pull/9836#issuecomment-1759762568 ## CI report: * ec64b99d8525d88a1844e434000d83d06e74fe75 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20246) * c19e0177a8ab98a26370cc238c20b72bfb4abd7c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20307) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
hudi-bot commented on PR #9836: URL: https://github.com/apache/hudi/pull/9836#issuecomment-1759744758 ## CI report: * ec64b99d8525d88a1844e434000d83d06e74fe75 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20246) * c19e0177a8ab98a26370cc238c20b72bfb4abd7c UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
wecharyu commented on code in PR #9836:
URL: https://github.com/apache/hudi/pull/9836#discussion_r1356846519
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieOptionConfig.scala:
##
@@ -199,7 +184,7 @@ object HoodieOptionConfig {
// extract primaryKey, preCombineField, type options
def extractSqlOptions(options: Map[String, String]): Map[String, String] = {
-val sqlOptions = mapTableConfigsToSqlOptions(options)
+val sqlOptions = mapHoodieOptionsToSqlOptions(options)
Review Comment:
Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
boneanxs commented on code in PR #9836:
URL: https://github.com/apache/hudi/pull/9836#discussion_r1354717038
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieOptionConfig.scala:
##
@@ -199,7 +184,7 @@ object HoodieOptionConfig {
// extract primaryKey, preCombineField, type options
def extractSqlOptions(options: Map[String, String]): Map[String, String] = {
-val sqlOptions = mapTableConfigsToSqlOptions(options)
+val sqlOptions = mapHoodieOptionsToSqlOptions(options)
Review Comment:
`mapHoodieConfigsToSqlOptions` should be more accurate?
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieOptionConfig.scala:
##
@@ -169,22 +170,6 @@ object HoodieOptionConfig {
.toMap
}
- /**
- * Get the table type from the table options.
- * @param options
- * @return
- */
- def getTableType(options: Map[String, String]): String = {
Review Comment:
No need to delete this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
danny0405 commented on PR #9836: URL: https://github.com/apache/hudi/pull/9836#issuecomment-1756648590 @boneanxs Do you have intreast to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
hudi-bot commented on PR #9836: URL: https://github.com/apache/hudi/pull/9836#issuecomment-1752817066 ## CI report: * ec64b99d8525d88a1844e434000d83d06e74fe75 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20246) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
hudi-bot commented on PR #9836: URL: https://github.com/apache/hudi/pull/9836#issuecomment-1752744004 ## CI report: * ec64b99d8525d88a1844e434000d83d06e74fe75 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20246) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-6924] Fix hoodie table config not wok in table properties [hudi]
hudi-bot commented on PR #9836: URL: https://github.com/apache/hudi/pull/9836#issuecomment-1752661843 ## CI report: * ec64b99d8525d88a1844e434000d83d06e74fe75 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
