Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-12 Thread via GitHub


pt657407064 commented on code in PR #10973:
URL: https://github.com/apache/hudi/pull/10973#discussion_r1563160252


##
hudi-cli/src/main/resources/application.yml:
##
@@ -20,4 +20,7 @@ spring:
   shell:
 history:
   enabled: true
-  name: hoodie-cmd.log
\ No newline at end of file
+  name: hoodie-cmd.log
+command:
+  version:
+template: "classpath:version.txt"

Review Comment:
   CI issue has been fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-11 Thread via GitHub


hudi-bot commented on PR #10973:
URL: https://github.com/apache/hudi/pull/10973#issuecomment-2050862535

   
   ## CI report:
   
   * fac97b368a646aeddcc7e6728d7228f75f30bd82 Azure: 
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23204)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-11 Thread via GitHub


hudi-bot commented on PR #10973:
URL: https://github.com/apache/hudi/pull/10973#issuecomment-2050814856

   
   ## CI report:
   
   * e093cc8dec1a4aab10e29aad164569dbfd3a1667 Azure: 
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23203)
 
   * fac97b368a646aeddcc7e6728d7228f75f30bd82 Azure: 
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23204)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-11 Thread via GitHub


hudi-bot commented on PR #10973:
URL: https://github.com/apache/hudi/pull/10973#issuecomment-2050765806

   
   ## CI report:
   
   *  Unknown: [CANCELED](TBD) 
   * e093cc8dec1a4aab10e29aad164569dbfd3a1667 Azure: 
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23203)
 
   * fac97b368a646aeddcc7e6728d7228f75f30bd82 Azure: 
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23204)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-11 Thread via GitHub


hudi-bot commented on PR #10973:
URL: https://github.com/apache/hudi/pull/10973#issuecomment-2050729563

   
   ## CI report:
   
   *  Unknown: [CANCELED](TBD) 
   * e093cc8dec1a4aab10e29aad164569dbfd3a1667 Azure: 
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23203)
 
   * fac97b368a646aeddcc7e6728d7228f75f30bd82 UNKNOWN
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-11 Thread via GitHub


hudi-bot commented on PR #10973:
URL: https://github.com/apache/hudi/pull/10973#issuecomment-2050723861

   
   ## CI report:
   
   *  Unknown: [CANCELED](TBD) 
   * e093cc8dec1a4aab10e29aad164569dbfd3a1667 UNKNOWN
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-11 Thread via GitHub


pt657407064 commented on code in PR #10973:
URL: https://github.com/apache/hudi/pull/10973#discussion_r1561855940


##
hudi-cli/src/main/resources/application.yml:
##
@@ -20,4 +20,7 @@ spring:
   shell:
 history:
   enabled: true
-  name: hoodie-cmd.log
\ No newline at end of file
+  name: hoodie-cmd.log
+command:
+  version:
+template: "classpath:version.txt"

Review Comment:
   just fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-11 Thread via GitHub


pt657407064 commented on PR #10973:
URL: https://github.com/apache/hudi/pull/10973#issuecomment-2050718867

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-11 Thread via GitHub


pt657407064 commented on code in PR #10973:
URL: https://github.com/apache/hudi/pull/10973#discussion_r1561855940


##
hudi-cli/src/main/resources/application.yml:
##
@@ -20,4 +20,7 @@ spring:
   shell:
 history:
   enabled: true
-  name: hoodie-cmd.log
\ No newline at end of file
+  name: hoodie-cmd.log
+command:
+  version:
+template: "classpath:version.txt"

Review Comment:
   just fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-09 Thread via GitHub


codope commented on code in PR #10973:
URL: https://github.com/apache/hudi/pull/10973#discussion_r1557489927


##
hudi-cli/src/main/resources/application.yml:
##
@@ -20,4 +20,7 @@ spring:
   shell:
 history:
   enabled: true
-  name: hoodie-cmd.log
\ No newline at end of file
+  name: hoodie-cmd.log
+command:
+  version:
+template: "classpath:version.txt"

Review Comment:
   nit: newline



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-07 Thread via GitHub


danny0405 commented on PR #10973:
URL: https://github.com/apache/hudi/pull/10973#issuecomment-2041837537

   Can you check the CI failures?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-07 Thread via GitHub


pt657407064 commented on code in PR #10973:
URL: https://github.com/apache/hudi/pull/10973#discussion_r1555183250


##
hudi-cli/src/main/resources/application.yml:
##
@@ -20,4 +20,7 @@ spring:
   shell:
 history:
   enabled: true
-  name: hoodie-cmd.log
\ No newline at end of file
+  name: hoodie-cmd.log
+command:
+  version:
+template: "classpath:version.txt"

Review Comment:
   It was working until this file got removed since the hudi released 0.11.1. 
https://github.com/apache/hudi/blob/release-0.11.0/hudi-cli/src/main/java/org/apache/hudi/cli/HoodieSplashScreen.java#L60



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-07 Thread via GitHub


pt657407064 commented on code in PR #10973:
URL: https://github.com/apache/hudi/pull/10973#discussion_r1555183250


##
hudi-cli/src/main/resources/application.yml:
##
@@ -20,4 +20,7 @@ spring:
   shell:
 history:
   enabled: true
-  name: hoodie-cmd.log
\ No newline at end of file
+  name: hoodie-cmd.log
+command:
+  version:
+template: "classpath:version.txt"

Review Comment:
   It was working until this file got removed from the hudi released. 
https://github.com/apache/hudi/blob/release-0.11.0/hudi-cli/src/main/java/org/apache/hudi/cli/HoodieSplashScreen.java#L60



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-07 Thread via GitHub


pt657407064 commented on code in PR #10973:
URL: https://github.com/apache/hudi/pull/10973#discussion_r1555181705


##
hudi-cli/src/main/resources/application.yml:
##
@@ -20,4 +20,7 @@ spring:
   shell:
 history:
   enabled: true
-  name: hoodie-cmd.log
\ No newline at end of file
+  name: hoodie-cmd.log
+command:
+  version:
+template: "classpath:version.txt"

Review Comment:
   Yes, The `version` command in hudi CLI is not showing the current Hudi 
version. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-07 Thread via GitHub


pt657407064 commented on code in PR #10973:
URL: https://github.com/apache/hudi/pull/10973#discussion_r1555181705


##
hudi-cli/src/main/resources/application.yml:
##
@@ -20,4 +20,7 @@ spring:
   shell:
 history:
   enabled: true
-  name: hoodie-cmd.log
\ No newline at end of file
+  name: hoodie-cmd.log
+command:
+  version:
+template: "classpath:version.txt"

Review Comment:
   The version command in CLI is not showing the current Hudi version. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-07 Thread via GitHub


hudi-bot commented on PR #10973:
URL: https://github.com/apache/hudi/pull/10973#issuecomment-2041758041

   
   ## CI report:
   
   * 6827a922b5eae447c97a294cc9f5f9520761bb10 Azure: 
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23139)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-07 Thread via GitHub


danny0405 commented on code in PR #10973:
URL: https://github.com/apache/hudi/pull/10973#discussion_r1555154882


##
hudi-cli/src/main/resources/application.yml:
##
@@ -20,4 +20,7 @@ spring:
   shell:
 history:
   enabled: true
-  name: hoodie-cmd.log
\ No newline at end of file
+  name: hoodie-cmd.log
+command:
+  version:
+template: "classpath:version.txt"

Review Comment:
   Not very familiar with the Spring stuff, are we fixing the spring cmd?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-07 Thread via GitHub


hudi-bot commented on PR #10973:
URL: https://github.com/apache/hudi/pull/10973#issuecomment-2041711400

   
   ## CI report:
   
   * 6827a922b5eae447c97a294cc9f5f9520761bb10 Azure: 
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23139)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MINOR] Hudi CLI 'version' command output empty string [hudi]

2024-04-07 Thread via GitHub


hudi-bot commented on PR #10973:
URL: https://github.com/apache/hudi/pull/10973#issuecomment-2041705454

   
   ## CI report:
   
   * 6827a922b5eae447c97a294cc9f5f9520761bb10 UNKNOWN
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org