Jenkins build is back to stable : Karaf » karaf-decanter-master #33

[Apache Jenkins Server]

See 

[GitHub] [karaf] amusarra commented on pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

amusarra commented on pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#issuecomment-679420050


   I wanted to contribute as a user of Apache Karaf that develops OSGi 
solutions that also run on ARM architectures, see Raspberry Pi. Just yesterday 
I published an article about it [Raspberry Pi: How to run Apache Karaf 4.2 
Docker 
Container](https://bit.ly/raspberrypi-how-to-run-apache-karaf-docker-container)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475799636



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   @skitt and @jbonofre I just installed the Apache Karaf image for ARM 
based on `adoptopenjdk: 11-jre-hotspot` image on my Raspberry Pi and it works 
fine. The image I built is this 
[amusarra/karaf:4.2.9-dev](https://hub.docker.com/layers/amusarra/karaf/4.2.9-dev/images/sha256-8de5205d81263099628cf7659cdd8c648bd13b12cf9cc036f46d9426992927b5?context=explore)
   
   Let me know if you have any doubts, in case I commit the dockerfile and 
update the README.
   
   Thanks.
   
   
![image](https://user-images.githubusercontent.com/708110/91079519-6f700b80-e644-11ea-86fe-aecb0f031be6.png)
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475799636



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   @skitt and @jbonofre I just installed the Apache Karaf `adoptopenjdk: 
11-jre-hotspot` based on image for ARM on my Raspberry Pi and it works fine. 
The image I built is this 
[amusarra/karaf:4.2.9-dev](https://hub.docker.com/layers/amusarra/karaf/4.2.9-dev/images/sha256-8de5205d81263099628cf7659cdd8c648bd13b12cf9cc036f46d9426992927b5?context=explore)
   
   Let me know if you have any doubts, in case I commit the dockerfile and 
update the README.
   
   Thanks.
   
   
![image](https://user-images.githubusercontent.com/708110/91079519-6f700b80-e644-11ea-86fe-aecb0f031be6.png)
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475799636



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   @skitt and @jbonofre I just installed the `adoptopenjdk: 11-jre-hotspot` 
based Apache Karaf image for ARM on my Raspberry Pi and it works fine. The 
image I built is this 
[amusarra/karaf:4.2.9-dev](https://hub.docker.com/layers/amusarra/karaf/4.2.9-dev/images/sha256-8de5205d81263099628cf7659cdd8c648bd13b12cf9cc036f46d9426992927b5?context=explore)
   
   Let me know if you have any doubts, in case I commit the dockerfile and 
update the README.
   
   Thanks.
   
   
![image](https://user-images.githubusercontent.com/708110/91079519-6f700b80-e644-11ea-86fe-aecb0f031be6.png)
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] skitt commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

skitt commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475791747



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   That would be great, thanks!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475771634



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   OK. Then I'll update to `adoptopenjdk:11-jre-hotspot` and do a test on 
arm (on my Raspberry Pi) to make sure everything works. OK?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] skitt commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

skitt commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475756112



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   `adoptopenjdk:11-jre-hotspot` would be better: they provide Windows 
builds too, and by referencing `11-jre-hotspot` instead of `...-bionic`, if the 
Linux-based 11 images switch to a base other than Bionic we’ll still get 
updates.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475746554



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   Could this image be used adoptopenjdk: 11-jre-hotspot-bionic? I saw that 
it also includes ARM architectures and the image is up to date. What are you 
saying? Could I try this one?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475733066



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   Unfortunately the 8-jre alpine version for ARM does not work well on ARM 
devices because it uses OpenJDK Zero. Of version 11 I only found this image 
which also works on ARM devices. Since the original dockerfile referred to 
OpenJDK I did not take into consideration other images such as adoptopenjdk 
ones.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] skitt commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

skitt commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475724499



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   I’m not objecting to the choice of version, but to the choice of image. 
The 8-jre images are still maintained, and were last updated 12 days ago, with 
a recent [build of 
OpenJDK](https://blog.adoptopenjdk.net/2020/07/adoptopenjdk-8u265-available/); 
the 11-ea-28-slim images haven’t been touched for two years and have known 
security issues.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] jbonofre commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

jbonofre commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475723140



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   The problem is not about the version (11 is fine and good idea) it's 
more the ea-28-slim which is a early access image. Please consider to use 
11-jre (LTS).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475721520



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   I put version 11 also supported by Karaf. If you consider first there 
was version 8!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] skitt commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)

[GitBox]

skitt commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475715549



##
File path: assemblies/docker/Dockerfile
##
@@ -16,7 +16,7 @@
 # limitations under the License.
 

 
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim

Review comment:
   This is an obsolete, early-access image; please don’t use that.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Jenkins build is back to stable : Karaf » karaf-cave-master #32

[Apache Jenkins Server]

See