Re: [PR] fix a typo in javadoc [karaf]
dsqrt4 commented on PR #1786: URL: https://github.com/apache/karaf/pull/1786#issuecomment-1773706675 No problem of course. Thank you for your time. 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix a typo in javadoc [karaf]
jbonofre merged PR #1786: URL: https://github.com/apache/karaf/pull/1786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix a typo in javadoc [karaf]
jbonofre commented on PR #1786: URL: https://github.com/apache/karaf/pull/1786#issuecomment-1773383486 Thanks. I think I was wrong or misunderstood the change. Sorry about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix a typo in javadoc [karaf]
dsqrt4 opened a new pull request, #1786: URL: https://github.com/apache/karaf/pull/1786 This same change was made by @Brimstedt in #127 years ago, but was reverted by @jbonofre arguing it was correct before. However I tripped over this recently so I tried glanced over the implementation and saw that [CommandExtension](https://github.com/apache/karaf/blob/karaf-4.4.4/shell/core/src/main/java/org/apache/karaf/shell/impl/action/osgi/CommandExtension.java#L181-L194) only looks for fields annotated with `@Reference`, so I don't see how anything would be injected into a field that has been annotated with `@Service`. Also (as Brimstedt mentioned) `@Service` isn't even applicable to fields, only to types. All things considered, I still think this is a typo, so I'd like this change to be considered once more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
