This is an automated email from the ASF dual-hosted git repository. abukor pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push: new 49d2bc9ed [alter_table-test] Increase assertion timeout 49d2bc9ed is described below commit 49d2bc9ed51307cd9b258681cb64a92ef1cf07a5 Author: Ádám Bakai <aba...@cloudera.com> AuthorDate: Tue Apr 23 12:53:02 2024 +0200 [alter_table-test] Increase assertion timeout On ubuntu 22.04 release build, AlterReplicationFactorWhileWriting test failed with timeout. So timeout was increased to 60 seconds. Change-Id: Ifc51365a798569c22e680eb3e7723a5f330d43c5 Reviewed-on: http://gerrit.cloudera.org:8080/21347 Tested-by: Kudu Jenkins Reviewed-by: Attila Bukor <abu...@apache.org> --- src/kudu/integration-tests/alter_table-test.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/kudu/integration-tests/alter_table-test.cc b/src/kudu/integration-tests/alter_table-test.cc index 509f954f6..d4884579e 100644 --- a/src/kudu/integration-tests/alter_table-test.cc +++ b/src/kudu/integration-tests/alter_table-test.cc @@ -286,8 +286,10 @@ class AlterTableTest : public KuduTest { kEnable = 0, kDisable }; - void VerifyTabletReplicaCount(int32_t replication_factor, VerifyRowCount verify_row_count) { - ASSERT_EVENTUALLY([&] { + void VerifyTabletReplicaCount(int32_t replication_factor, + VerifyRowCount verify_row_count, + const MonoDelta& timeout = MonoDelta::FromSeconds(30)) { + AssertEventually([&] { ASSERT_EQ(replication_factor, tablet_replica_->consensus()->CommittedConfig().peers().size()); scoped_refptr<TabletReplica> first_node_replica; @@ -322,7 +324,8 @@ class AlterTableTest : public KuduTest { ++actual_replica_count; } ASSERT_EQ(replication_factor, actual_replica_count); - }); + }, timeout); + NO_PENDING_FATALS(); } enum VerifyPattern { @@ -2392,7 +2395,7 @@ TEST_F(ReplicatedAlterTableTest, AlterReplicationFactorWhileWriting) { workload.StopAndJoin(); ASSERT_EVENTUALLY([&] { tablet_replica_ = LookupLeaderTabletReplica(); - NO_FATALS(VerifyTabletReplicaCount(3, VerifyRowCount::kEnable)); + NO_FATALS(VerifyTabletReplicaCount(3, VerifyRowCount::kEnable,MonoDelta::FromSeconds(60))); ASSERT_EQ(1, tablet_replica_->tablet()->metadata()->schema_version()); });