KYLIN-919 model name validate when edit model,add lowercase check Signed-off-by: honma <ho...@ebay.com>
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/4afd144a Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/4afd144a Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/4afd144a Branch: refs/heads/2.x-staging Commit: 4afd144af38f99c2fc7333b18f07f2880cd80434 Parents: 24d3825 Author: Zhong <jiazh...@lm-shc-16501192.corp.ebay.com> Authored: Wed Dec 2 15:02:03 2015 +0800 Committer: honma <ho...@ebay.com> Committed: Fri Dec 4 16:29:07 2015 +0800 ---------------------------------------------------------------------- webapp/app/js/controllers/modelSchema.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/4afd144a/webapp/app/js/controllers/modelSchema.js ---------------------------------------------------------------------- diff --git a/webapp/app/js/controllers/modelSchema.js b/webapp/app/js/controllers/modelSchema.js index 9e9f09c..682ce5e 100644 --- a/webapp/app/js/controllers/modelSchema.js +++ b/webapp/app/js/controllers/modelSchema.js @@ -166,9 +166,11 @@ KylinApp.controller('ModelSchemaCtrl', function ($scope, QueryService, UserServi var modelName = $scope.modelsManager.selectedModel.name.toUpperCase(); var models = $scope.modelsManager.modelNameList; - if ($scope.modelMode=="addNewModel"&&models.indexOf(modelName) != -1 || models.indexOf(modelName.toLowerCase()) !=-1) { - SweetAlert.swal('', "Model named [" + modelName + "] already exist!", 'warning'); - return false; + if ($scope.modelMode=="addNewModel") { + if(models.indexOf(modelName) != -1 || models.indexOf(modelName.toLowerCase()) !=-1){ + SweetAlert.swal('', "Model named [" + modelName + "] already exist!", 'warning'); + return false; + } } return true; }
