[2/2] maven-resolver git commit: [MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid input
[MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid input Project: http://git-wip-us.apache.org/repos/asf/maven-resolver/repo Commit: http://git-wip-us.apache.org/repos/asf/maven-resolver/commit/523f98ca Tree: http://git-wip-us.apache.org/repos/asf/maven-resolver/tree/523f98ca Diff: http://git-wip-us.apache.org/repos/asf/maven-resolver/diff/523f98ca Branch: refs/heads/MRESOLVER-4 Commit: 523f98ca621489e93220f9a32c20fa3a7cee174a Parents: 5fae685 Author: Michael OsipovAuthored: Mon Nov 7 22:06:19 2016 +0100 Committer: Michael Osipov Committed: Thu May 11 23:20:12 2017 +0200 -- .../aether/DefaultRepositorySystemSession.java | 8 +- .../org/eclipse/aether/DefaultSessionData.java | 17 +-- .../org/eclipse/aether/RepositoryEvent.java | 17 +-- .../aether/artifact/DefaultArtifactType.java| 13 +- .../aether/collection/CollectResult.java| 11 +- .../eclipse/aether/deployment/DeployResult.java | 11 +- .../aether/graph/DefaultDependencyNode.java | 6 +- .../org/eclipse/aether/graph/Dependency.java| 7 +- .../aether/installation/InstallResult.java | 11 +- .../aether/metadata/DefaultMetadata.java| 7 +- .../repository/AuthenticationContext.java | 21 ++-- .../aether/repository/LocalArtifactResult.java | 13 +- .../aether/repository/LocalMetadataResult.java | 13 +- .../aether/repository/RemoteRepository.java | 11 +- .../resolution/ArtifactDescriptorResult.java| 9 +- .../aether/resolution/ArtifactResult.java | 11 +- .../aether/resolution/DependencyResult.java | 9 +- .../aether/resolution/MetadataResult.java | 12 +- .../aether/resolution/VersionRangeResult.java | 9 +- .../aether/resolution/VersionResult.java| 11 +- .../eclipse/aether/transfer/TransferEvent.java | 41 ++- .../eclipse/aether/version/VersionRange.java| 12 +- .../repository/RemoteRepositoryBuilderTest.java | 2 +- .../basic/BasicRepositoryConnector.java | 13 +- .../basic/BasicRepositoryConnectorFactory.java | 34 ++--- .../aether/impl/DefaultServiceLocator.java | 25 +--- .../internal/impl/DefaultArtifactResolver.java | 49 ++-- .../impl/DefaultDependencyCollector.java| 19 +-- ...ultDependencyGraphTransformationContext.java | 12 +- .../aether/internal/impl/DefaultDeployer.java | 49 ++-- .../aether/internal/impl/DefaultInstaller.java | 25 +--- .../impl/DefaultLocalRepositoryProvider.java| 7 +- .../internal/impl/DefaultMetadataResolver.java | 37 ++ .../impl/DefaultRemoteRepositoryManager.java| 13 +- .../DefaultRepositoryConnectorProvider.java | 12 +- .../impl/DefaultRepositoryEventDispatcher.java | 7 +- .../impl/DefaultRepositoryLayoutProvider.java | 12 +- .../internal/impl/DefaultRepositorySystem.java | 123 --- .../impl/DefaultTransporterProvider.java| 12 +- .../impl/DefaultUpdateCheckManager.java | 19 +-- .../impl/EnhancedLocalRepositoryManager.java| 7 +- .../impl/SimpleLocalRepositoryManager.java | 6 +- .../impl/DefaultDependencyCollectorTest.java| 4 +- .../impl/DefaultUpdateCheckManagerTest.java | 2 +- .../spi/connector/layout/RepositoryLayout.java | 11 +- .../spi/connector/transport/TransportTask.java | 11 +- .../test/util/DependencyGraphParser.java| 2 +- ...estDependencyGraphTransformationContext.java | 12 +- .../test/util/TestVersionConstraint.java| 18 +-- .../wagon/PlexusWagonConfigurator.java | 10 +- .../transport/wagon/PlexusWagonProvider.java| 10 +- .../util/artifact/DelegatingArtifact.java | 11 +- .../aether/util/artifact/SubArtifact.java | 7 +- .../concurrency/RunnableErrorForwarder.java | 9 +- .../aether/util/filter/NotDependencyFilter.java | 9 +- .../graph/transformer/ConflictResolver.java | 25 +--- .../visitor/FilteringDependencyVisitor.java | 10 +- .../graph/visitor/TreeDependencyVisitor.java| 9 +- .../repository/ComponentAuthentication.java | 7 +- .../ConservativeAuthenticationSelector.java | 10 +- .../repository/ConservativeProxySelector.java | 10 +- .../util/repository/DefaultProxySelector.java | 7 +- .../util/repository/SecretAuthentication.java | 7 +- .../util/repository/StringAuthentication.java | 7 +- .../util/version/GenericVersionConstraint.java | 18 +-- .../aether/util/artifact/SubArtifactTest.java | 2 +- .../transformer/JavaScopeSelectorTest.java | 4 +- 67 files changed, 293 insertions(+), 702 deletions(-) -- http://git-wip-us.apache.org/repos/asf/maven-resolver/blob/523f98ca/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
[2/2] maven-resolver git commit: [MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid input
[MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid input Project: http://git-wip-us.apache.org/repos/asf/maven-resolver/repo Commit: http://git-wip-us.apache.org/repos/asf/maven-resolver/commit/362ce50e Tree: http://git-wip-us.apache.org/repos/asf/maven-resolver/tree/362ce50e Diff: http://git-wip-us.apache.org/repos/asf/maven-resolver/diff/362ce50e Branch: refs/heads/MRESOLVER-4 Commit: 362ce50e1fb3dc4a7e1eda65318d4ba6d9f0683f Parents: 5fae685 Author: Michael OsipovAuthored: Mon Nov 7 22:06:19 2016 +0100 Committer: Michael Osipov Committed: Thu May 11 23:04:10 2017 +0200 -- .../aether/DefaultRepositorySystemSession.java | 8 +- .../org/eclipse/aether/DefaultSessionData.java | 17 +-- .../org/eclipse/aether/RepositoryEvent.java | 17 +-- .../aether/artifact/DefaultArtifactType.java| 13 +- .../aether/collection/CollectResult.java| 11 +- .../eclipse/aether/deployment/DeployResult.java | 11 +- .../aether/graph/DefaultDependencyNode.java | 6 +- .../org/eclipse/aether/graph/Dependency.java| 7 +- .../aether/installation/InstallResult.java | 11 +- .../aether/metadata/DefaultMetadata.java| 7 +- .../repository/AuthenticationContext.java | 21 ++-- .../aether/repository/LocalArtifactResult.java | 13 +- .../aether/repository/LocalMetadataResult.java | 13 +- .../aether/repository/RemoteRepository.java | 11 +- .../resolution/ArtifactDescriptorResult.java| 9 +- .../aether/resolution/ArtifactResult.java | 11 +- .../aether/resolution/DependencyResult.java | 9 +- .../aether/resolution/MetadataResult.java | 12 +- .../aether/resolution/VersionRangeResult.java | 9 +- .../aether/resolution/VersionResult.java| 11 +- .../eclipse/aether/transfer/TransferEvent.java | 41 ++- .../eclipse/aether/version/VersionRange.java| 12 +- .../repository/RemoteRepositoryBuilderTest.java | 2 +- .../basic/BasicRepositoryConnector.java | 13 +- .../basic/BasicRepositoryConnectorFactory.java | 34 ++--- .../aether/impl/DefaultServiceLocator.java | 25 +--- .../internal/impl/DefaultArtifactResolver.java | 49 ++-- .../impl/DefaultDependencyCollector.java| 19 +-- ...ultDependencyGraphTransformationContext.java | 12 +- .../aether/internal/impl/DefaultDeployer.java | 49 ++-- .../aether/internal/impl/DefaultInstaller.java | 25 +--- .../impl/DefaultLocalRepositoryProvider.java| 7 +- .../internal/impl/DefaultMetadataResolver.java | 37 ++ .../impl/DefaultRemoteRepositoryManager.java| 13 +- .../DefaultRepositoryConnectorProvider.java | 12 +- .../impl/DefaultRepositoryEventDispatcher.java | 7 +- .../impl/DefaultRepositoryLayoutProvider.java | 12 +- .../internal/impl/DefaultRepositorySystem.java | 123 --- .../impl/DefaultTransporterProvider.java| 12 +- .../impl/DefaultUpdateCheckManager.java | 19 +-- .../impl/EnhancedLocalRepositoryManager.java| 7 +- .../impl/SimpleLocalRepositoryManager.java | 6 +- .../impl/DefaultDependencyCollectorTest.java| 4 +- .../impl/DefaultUpdateCheckManagerTest.java | 2 +- .../spi/connector/layout/RepositoryLayout.java | 11 +- .../spi/connector/transport/TransportTask.java | 11 +- .../test/util/DependencyGraphParser.java| 2 +- ...estDependencyGraphTransformationContext.java | 12 +- .../test/util/TestVersionConstraint.java| 18 +-- .../wagon/PlexusWagonConfigurator.java | 10 +- .../transport/wagon/PlexusWagonProvider.java| 10 +- .../util/artifact/DelegatingArtifact.java | 11 +- .../aether/util/artifact/SubArtifact.java | 7 +- .../concurrency/RunnableErrorForwarder.java | 9 +- .../aether/util/filter/NotDependencyFilter.java | 9 +- .../graph/transformer/ConflictResolver.java | 25 +--- .../visitor/FilteringDependencyVisitor.java | 10 +- .../graph/visitor/TreeDependencyVisitor.java| 9 +- .../repository/ComponentAuthentication.java | 7 +- .../ConservativeAuthenticationSelector.java | 10 +- .../repository/ConservativeProxySelector.java | 10 +- .../util/repository/DefaultProxySelector.java | 24 +++- .../util/repository/SecretAuthentication.java | 7 +- .../util/repository/StringAuthentication.java | 7 +- .../util/version/GenericVersionConstraint.java | 18 +-- .../aether/util/artifact/SubArtifactTest.java | 2 +- .../transformer/JavaScopeSelectorTest.java | 4 +- 67 files changed, 310 insertions(+), 702 deletions(-) -- http://git-wip-us.apache.org/repos/asf/maven-resolver/blob/362ce50e/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
[2/2] maven-resolver git commit: [MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid input
[MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid input o Updated to re-add missing validation. Project: http://git-wip-us.apache.org/repos/asf/maven-resolver/repo Commit: http://git-wip-us.apache.org/repos/asf/maven-resolver/commit/d2f5aa54 Tree: http://git-wip-us.apache.org/repos/asf/maven-resolver/tree/d2f5aa54 Diff: http://git-wip-us.apache.org/repos/asf/maven-resolver/diff/d2f5aa54 Branch: refs/heads/master Commit: d2f5aa54b14107eeffe230a331d472ae46d7ff5b Parents: 077281a Author: Christian SchulteAuthored: Mon Dec 12 23:33:20 2016 +0100 Committer: Christian Schulte Committed: Mon Dec 12 23:52:59 2016 +0100 -- .../org/eclipse/aether/internal/impl/DefaultRepositorySystem.java | 2 ++ 1 file changed, 2 insertions(+) -- http://git-wip-us.apache.org/repos/asf/maven-resolver/blob/d2f5aa54/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java -- diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java index 7555812..5787a61 100644 --- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java +++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java @@ -431,11 +431,13 @@ public class DefaultRepositorySystem requireNonNull( session, "repository system session cannot be null" ); invalidSession( session.getLocalRepositoryManager(), "local repository manager" ); invalidSession( session.getSystemProperties(), "system properties" ); +invalidSession( session.getUserProperties(), "user properties" ); invalidSession( session.getConfigProperties(), "config properties" ); invalidSession( session.getMirrorSelector(), "mirror selector" ); invalidSession( session.getProxySelector(), "proxy selector" ); invalidSession( session.getAuthenticationSelector(), "authentication selector" ); invalidSession( session.getArtifactTypeRegistry(), "artifact type registry" ); +invalidSession( session.getData(), "data" ); } private void invalidSession( Object obj, String name )
[2/2] maven-resolver git commit: [MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid input
[MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid input Go for brevity by statically importing Objects#requireNonNull Project: http://git-wip-us.apache.org/repos/asf/maven-resolver/repo Commit: http://git-wip-us.apache.org/repos/asf/maven-resolver/commit/68090ec0 Tree: http://git-wip-us.apache.org/repos/asf/maven-resolver/tree/68090ec0 Diff: http://git-wip-us.apache.org/repos/asf/maven-resolver/diff/68090ec0 Branch: refs/heads/master Commit: 68090ec04c401ee27b8f900a213f68a1796e4aee Parents: 7b3bf57 Author: Michael OsipovAuthored: Thu Nov 10 23:05:42 2016 +0100 Committer: Michael Osipov Committed: Thu Nov 10 23:05:42 2016 +0100 -- .../aether/DefaultRepositorySystemSession.java | 4 +-- .../org/eclipse/aether/DefaultSessionData.java | 8 +++--- .../org/eclipse/aether/RepositoryEvent.java | 6 ++--- .../aether/artifact/DefaultArtifactType.java| 6 ++--- .../aether/collection/CollectResult.java| 4 +-- .../eclipse/aether/deployment/DeployResult.java | 4 +-- .../aether/graph/DefaultDependencyNode.java | 4 +-- .../org/eclipse/aether/graph/Dependency.java| 4 +-- .../aether/installation/InstallResult.java | 4 +-- .../aether/metadata/DefaultMetadata.java| 4 +-- .../repository/AuthenticationContext.java | 8 +++--- .../aether/repository/LocalArtifactResult.java | 4 +-- .../aether/repository/LocalMetadataResult.java | 4 +-- .../aether/repository/RemoteRepository.java | 4 +-- .../resolution/ArtifactDescriptorResult.java| 4 +-- .../aether/resolution/ArtifactResult.java | 4 +-- .../aether/resolution/DependencyResult.java | 4 +-- .../aether/resolution/MetadataResult.java | 4 +-- .../aether/resolution/VersionRangeResult.java | 4 +-- .../aether/resolution/VersionResult.java| 4 +-- .../eclipse/aether/transfer/TransferEvent.java | 12 - .../eclipse/aether/version/VersionRange.java| 4 +-- .../basic/BasicRepositoryConnector.java | 6 ++--- .../basic/BasicRepositoryConnectorFactory.java | 10 +++ .../aether/impl/DefaultServiceLocator.java | 10 +++ .../internal/impl/DefaultArtifactResolver.java | 18 ++--- .../impl/DefaultDependencyCollector.java| 8 +++--- ...ultDependencyGraphTransformationContext.java | 6 ++--- .../aether/internal/impl/DefaultDeployer.java | 18 ++--- .../aether/internal/impl/DefaultInstaller.java | 10 +++ .../impl/DefaultLocalRepositoryProvider.java| 4 +-- .../internal/impl/DefaultMetadataResolver.java | 14 +- .../impl/DefaultRemoteRepositoryManager.java| 6 ++--- .../DefaultRepositoryConnectorProvider.java | 6 ++--- .../impl/DefaultRepositoryEventDispatcher.java | 4 +-- .../impl/DefaultRepositoryLayoutProvider.java | 6 ++--- .../internal/impl/DefaultRepositorySystem.java | 28 ++-- .../impl/DefaultTransporterProvider.java| 6 ++--- .../impl/DefaultUpdateCheckManager.java | 8 +++--- .../impl/EnhancedLocalRepositoryManager.java| 4 +-- .../impl/SimpleLocalRepositoryManager.java | 4 +-- .../spi/connector/layout/RepositoryLayout.java | 6 ++--- .../spi/connector/transport/TransportTask.java | 4 +-- ...estDependencyGraphTransformationContext.java | 6 ++--- .../test/util/TestVersionConstraint.java| 6 ++--- .../wagon/PlexusWagonConfigurator.java | 4 +-- .../transport/wagon/PlexusWagonProvider.java| 4 +-- .../util/artifact/DelegatingArtifact.java | 4 +-- .../aether/util/artifact/SubArtifact.java | 4 +-- .../concurrency/RunnableErrorForwarder.java | 4 +-- .../aether/util/filter/NotDependencyFilter.java | 4 +-- .../graph/transformer/ConflictResolver.java | 10 +++ .../visitor/FilteringDependencyVisitor.java | 4 +-- .../graph/visitor/TreeDependencyVisitor.java| 4 +-- .../repository/ComponentAuthentication.java | 4 +-- .../ConservativeAuthenticationSelector.java | 4 +-- .../repository/ConservativeProxySelector.java | 4 +-- .../util/repository/DefaultProxySelector.java | 4 +-- .../util/repository/SecretAuthentication.java | 4 +-- .../util/repository/StringAuthentication.java | 4 +-- .../util/version/GenericVersionConstraint.java | 6 ++--- 61 files changed, 189 insertions(+), 189 deletions(-) -- http://git-wip-us.apache.org/repos/asf/maven-resolver/blob/68090ec0/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java -- diff --git a/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java b/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java index fc529d6..13773df 100644
[2/2] maven-resolver git commit: [MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid input
[MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid input Project: http://git-wip-us.apache.org/repos/asf/maven-resolver/repo Commit: http://git-wip-us.apache.org/repos/asf/maven-resolver/commit/f4a0ce15 Tree: http://git-wip-us.apache.org/repos/asf/maven-resolver/tree/f4a0ce15 Diff: http://git-wip-us.apache.org/repos/asf/maven-resolver/diff/f4a0ce15 Branch: refs/heads/master Commit: f4a0ce151c3c3d7962e368567e4d7a1bffefcca4 Parents: 03d5748 Author: Michael OsipovAuthored: Mon Nov 7 22:06:19 2016 +0100 Committer: Michael Osipov Committed: Mon Nov 7 22:06:19 2016 +0100 -- .../aether/DefaultRepositorySystemSession.java | 8 +- .../org/eclipse/aether/DefaultSessionData.java | 17 +-- .../org/eclipse/aether/RepositoryEvent.java | 17 +-- .../aether/artifact/DefaultArtifactType.java| 13 +- .../aether/collection/CollectResult.java| 11 +- .../eclipse/aether/deployment/DeployResult.java | 11 +- .../aether/graph/DefaultDependencyNode.java | 6 +- .../org/eclipse/aether/graph/Dependency.java| 7 +- .../aether/installation/InstallResult.java | 11 +- .../aether/metadata/DefaultMetadata.java| 7 +- .../repository/AuthenticationContext.java | 21 ++-- .../aether/repository/LocalArtifactResult.java | 13 +- .../aether/repository/LocalMetadataResult.java | 13 +- .../aether/repository/RemoteRepository.java | 11 +- .../resolution/ArtifactDescriptorResult.java| 9 +- .../aether/resolution/ArtifactResult.java | 11 +- .../aether/resolution/DependencyResult.java | 9 +- .../aether/resolution/MetadataResult.java | 12 +- .../aether/resolution/VersionRangeResult.java | 9 +- .../aether/resolution/VersionResult.java| 11 +- .../eclipse/aether/transfer/TransferEvent.java | 41 ++- .../eclipse/aether/version/VersionRange.java| 12 +- .../repository/RemoteRepositoryBuilderTest.java | 2 +- .../basic/BasicRepositoryConnector.java | 13 +- .../basic/BasicRepositoryConnectorFactory.java | 34 ++ .../aether/impl/DefaultServiceLocator.java | 25 +--- .../internal/impl/DefaultArtifactResolver.java | 49 ++-- .../impl/DefaultDependencyCollector.java| 19 +-- ...ultDependencyGraphTransformationContext.java | 12 +- .../aether/internal/impl/DefaultDeployer.java | 49 ++-- .../aether/internal/impl/DefaultInstaller.java | 25 +--- .../impl/DefaultLocalRepositoryProvider.java| 7 +- .../internal/impl/DefaultMetadataResolver.java | 37 ++ .../impl/DefaultRemoteRepositoryManager.java| 13 +- .../DefaultRepositoryConnectorProvider.java | 12 +- .../impl/DefaultRepositoryEventDispatcher.java | 7 +- .../impl/DefaultRepositoryLayoutProvider.java | 12 +- .../internal/impl/DefaultRepositorySystem.java | 121 --- .../impl/DefaultTransporterProvider.java| 12 +- .../impl/DefaultUpdateCheckManager.java | 19 +-- .../impl/EnhancedLocalRepositoryManager.java| 7 +- .../impl/SimpleLocalRepositoryManager.java | 6 +- .../impl/DefaultDependencyCollectorTest.java| 4 +- .../impl/DefaultUpdateCheckManagerTest.java | 2 +- .../spi/connector/layout/RepositoryLayout.java | 11 +- .../spi/connector/transport/TransportTask.java | 11 +- .../test/util/DependencyGraphParser.java| 2 +- ...estDependencyGraphTransformationContext.java | 12 +- .../test/util/TestVersionConstraint.java| 18 +-- .../wagon/PlexusWagonConfigurator.java | 10 +- .../transport/wagon/PlexusWagonProvider.java| 10 +- .../util/artifact/DelegatingArtifact.java | 11 +- .../aether/util/artifact/SubArtifact.java | 7 +- .../concurrency/RunnableErrorForwarder.java | 9 +- .../aether/util/filter/NotDependencyFilter.java | 9 +- .../graph/transformer/ConflictResolver.java | 25 +--- .../visitor/FilteringDependencyVisitor.java | 10 +- .../graph/visitor/TreeDependencyVisitor.java| 9 +- .../repository/ComponentAuthentication.java | 7 +- .../ConservativeAuthenticationSelector.java | 10 +- .../repository/ConservativeProxySelector.java | 10 +- .../util/repository/DefaultProxySelector.java | 7 +- .../util/repository/SecretAuthentication.java | 7 +- .../util/repository/StringAuthentication.java | 7 +- .../util/version/GenericVersionConstraint.java | 18 +-- .../aether/util/artifact/SubArtifactTest.java | 2 +- .../transformer/JavaScopeSelectorTest.java | 4 +- 67 files changed, 290 insertions(+), 703 deletions(-) -- http://git-wip-us.apache.org/repos/asf/maven-resolver/blob/f4a0ce15/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java