[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17617: [Large Tensor] Fixed Spatial Transformer op

2020-02-18 Thread GitBox 
ChaiBapchya commented on a change in pull request #17617: [Large Tensor] Fixed 
Spatial Transformer op
URL: https://github.com/apache/incubator-mxnet/pull/17617#discussion_r381043388
 
 

 ##
 File path: src/operator/spatial_transformer.cc
 ##
 @@ -58,10 +58,10 @@ inline void BilinearSamplingForward(const Tensor &output,
   const DType top_left_x_w = 1.0 - (x_real - top_left_x);
   const index_t data_index = n * i_c * i_h * i_w + c * i_h * i_w +
  top_left_y * i_w + top_left_x;
-  index_t top_left_v = 0;
-  index_t top_right_v = 0;
-  index_t bottom_left_v = 0;
-  index_t bottom_right_v = 0;
+  DType top_left_v = 0;
 
 Review comment:
   why is this changed back to Dtype?
   It's the index position right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17617: [Large Tensor] Fixed Spatial Transformer op

2020-02-19 Thread GitBox 
ChaiBapchya commented on a change in pull request #17617: [Large Tensor] Fixed 
Spatial Transformer op
URL: https://github.com/apache/incubator-mxnet/pull/17617#discussion_r381501825
 
 

 ##
 File path: src/operator/spatial_transformer.cc
 ##
 @@ -58,10 +58,10 @@ inline void BilinearSamplingForward(const Tensor &output,
   const DType top_left_x_w = 1.0 - (x_real - top_left_x);
   const index_t data_index = n * i_c * i_h * i_w + c * i_h * i_w +
  top_left_y * i_w + top_left_x;
-  index_t top_left_v = 0;
-  index_t top_right_v = 0;
-  index_t bottom_left_v = 0;
-  index_t bottom_right_v = 0;
+  DType top_left_v = 0;
 
 Review comment:
   Cool. good catch.
   _v indicates the value at that particular index. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services