[GitHub] [incubator-mxnet] TaoLv commented on issue #17396: refactor: handle mshadow as cmake target

2020-02-10 Thread GitBox
TaoLv commented on issue #17396: refactor: handle mshadow as cmake target
URL: https://github.com/apache/incubator-mxnet/pull/17396#issuecomment-584466037
 
 
   Sorry, why there is no BLAS/MKL related instructions in the cmake file? They 
exist in the Makefile of mshadow. See, 
https://github.com/apache/incubator-mxnet/blob/master/3rdparty/mshadow/make/mshadow.mk#L74.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] TaoLv commented on issue #17396: refactor: handle mshadow as cmake target

2020-02-10 Thread GitBox
TaoLv commented on issue #17396: refactor: handle mshadow as cmake target
URL: https://github.com/apache/incubator-mxnet/pull/17396#issuecomment-584502676
 
 
   Okay, sorry for missing that. I was wondering how does mshadow cmake 
handling the BLAS build flags like MSHADOW_USE_MKL and how the MKL library 
statically linked like the logic in mshadow.mk. But seems it another problem 
now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] TaoLv commented on issue #17396: refactor: handle mshadow as cmake target

2020-02-11 Thread GitBox
TaoLv commented on issue #17396: refactor: handle mshadow as cmake target
URL: https://github.com/apache/incubator-mxnet/pull/17396#issuecomment-584970461
 
 
   @leezu, I tried to build mxnet from source code with cmake and found that 
`libmkl_rt.so` is linked. Previously in makefile, we support both statically 
and dynamically linking, and statically linking by default.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] TaoLv commented on issue #17396: refactor: handle mshadow as cmake target

2020-02-11 Thread GitBox
TaoLv commented on issue #17396: refactor: handle mshadow as cmake target
URL: https://github.com/apache/incubator-mxnet/pull/17396#issuecomment-584981511
 
 
   No, I didn't. So at least the default behavior is different from makefile.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] TaoLv commented on issue #17396: refactor: handle mshadow as cmake target

2020-02-12 Thread GitBox
TaoLv commented on issue #17396: refactor: handle mshadow as cmake target
URL: https://github.com/apache/incubator-mxnet/pull/17396#issuecomment-585530538
 
 
   Personally I will recommend static linking just as the default behavior of 
makefile. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services