[GitHub] [incubator-mxnet] Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector
Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-512506558 > @sandeep-krishnamurthy Looks ready! After a few more changes requested by Lin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector
Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-512461674 @sandeep-krishnamurthy Looks ready! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector
Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-512033689 > retrigger the build ... there is some julia error. Probably not because of your code changes. Also add link to the test cases that you covered cased covered are described in my tutorial at the end. Link: https://github.com/apache/incubator-mxnet/pull/15517 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector
Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-511013592 > Nice work, just a few comments, looks good. Thank you for the detailed advices! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector
Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-510702857 Created a separate PR for a new tutorial on how to usage. https://github.com/apache/incubator-mxnet/pull/15517 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector
Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-510654624 Just realized there were more than one Tensor structs. Added `shadow::` before `Tensor` so compiler would not be confused. https://github.com/apache/incubator-mxnet/pull/15490/commits/a41720d86aa69c3d7147f7ddfea2ea127079bb54#diff-9e7d5c2420ecc900c4a85a3c35d91bffR623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector
Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-510294519 @apeforest @anirudh2290 @access2rohit @larroy @sandeep-krishnamurthy , Hi guys, I completed this PR and it's ready for review. The only thing that I do not have yet is support for CSR NDArrays because I want to ask your opinion. I think I probably do not need to generate the whole matrix. Having something like this in my interactive print should be good enough? (this is the existing test::print)  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
