larroy edited a comment on issue #15516: Fix memory leak reported by ASAN in NNVM to ONNX conversion URL: https://github.com/apache/incubator-mxnet/pull/15516#issuecomment-511052670 Not really, in those cases you want a semantic name, even if you are wrapping your Cat in a pointer you want to name it: `unique_ptr<Cat> cat = make_unique<Cat>() ` And not `unique_ptr<Cat> unique_ptr = make_unique<Cat>()` Semantic naming is important, we have already type information from the compiler and we are in a statically typed language, no need to name a pointer _ptr. And definitely not "data" for the name of a variable, this is a code smell.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
