[GitHub] [incubator-mxnet] marcoabreu commented on issue #15525: Nightly tests / integration tests in PRs are not tested before merging
marcoabreu commented on issue #15525: Nightly tests / integration tests in PRs are not tested before merging URL: https://github.com/apache/incubator-mxnet/issues/15525#issuecomment-510999095 I'm certainly in favour of a context sensitive bot that gives certain comments if certain types of changes are detected. But enforcing directly isn't possible besides adding actual checks. For example, we asked people in the past to run make lint locally. I could give you statistics about how often linting fails in ci, but trust me that something that simple isn't even followed most of the time. So basically we can't request anything from people unless we enforce it, which I'm opposed to in this particular case This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #15525: Nightly tests / integration tests in PRs are not tested before merging
marcoabreu commented on issue #15525: Nightly tests / integration tests in PRs are not tested before merging URL: https://github.com/apache/incubator-mxnet/issues/15525#issuecomment-510985789 I'd love to have context sensitive validations. Unfortunately, this feature doesn't exist out of the box. In general I think that we consider master bleeding edge. Thus, it's okay to have less coverage for the sake of speed and costs. If a PR breaks something, we usually revert it and get back to the original author. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
