[GitHub] [incubator-mxnet] marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release` URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-536796521 Thanks everyone! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release` URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-536720694 Yeah that sounds like a good way to move forward. Could you add the issue as release requirement for the 1.6 release please? After that, we're good to move forward with this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release` URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-536691372 @ptrendx @DickJC123 could you chime in please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release` URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-536691164 I'd like to get an opinion from some Nvidia engineers first. So far, we are making assumptions about these kernels differing in such a significant matter that we run into limits. Since we have the advantage of having people with detailed knowledge about the ins and outs of GPUs, I'd like to have them consulted first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release` URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-536214423 Interesting, which ones are failing? Can we fix them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release` URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-536173608 There are in fact totally valid use cases to not use release compilation. So I wouldn't dismiss the other options. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release` URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-536097048 I know and that's fine. Unless you explicitly compile with release, you don't get release. But this PR is trying to hide an error and I think we should rather address the error it revealed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release` URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-535882845 Could you also provide the version of your toolchains? Nvcc, cuda, cudnn, gcc, etc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release` URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-535856037 @DickJC123 could you maybe assist on this matter? Also, could you provide detailed instructions (ideally a docker container) to reproduce this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
marcoabreu commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release` URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-535846442 Thanks for your contribution, but shouldn't we rather fix the bug instead of working around it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
