[GitHub] [incubator-mxnet] ptrendx commented on issue #16398: Aggregated adamw update

2019-10-16 Thread GitBox
ptrendx commented on issue #16398: Aggregated adamw update
URL: https://github.com/apache/incubator-mxnet/pull/16398#issuecomment-542786721
 
 
   Generally I would opt for cleaning the optimizers so that only the `multi_` 
versions of the optimizers code exist (so use the same code for both multi and 
single tensor versions). The next step would be to refactor common code for 
handling multiple tensors out.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] ptrendx commented on issue #16398: Aggregated adamw update

2019-10-08 Thread GitBox
ptrendx commented on issue #16398: Aggregated adamw update
URL: https://github.com/apache/incubator-mxnet/pull/16398#issuecomment-539718507
 
 
   @eric-haibin-lin FYI


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services