[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #16259: [mkldnn-v1.0] Add MKL-DNN deconv

2019-09-30 Thread GitBox 
rongzha1 commented on a change in pull request #16259: [mkldnn-v1.0] Add 
MKL-DNN  deconv
URL: https://github.com/apache/incubator-mxnet/pull/16259#discussion_r329850707
 
 

 ##
 File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
 ##
 @@ -658,6 +645,12 @@ struct MKLDNNPostEltwiseParam {
   float alpha = 0.f;
   float beta = 1.f;
 };
+void MKLDNNRun(mxnet::FComputeEx fn,
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #16259: [mkldnn-v1.0] Add MKL-DNN deconv

2019-09-30 Thread GitBox 
rongzha1 commented on a change in pull request #16259: [mkldnn-v1.0] Add 
MKL-DNN  deconv
URL: https://github.com/apache/incubator-mxnet/pull/16259#discussion_r329850734
 
 

 ##
 File path: src/operator/nn/mkldnn/mkldnn_base.cc
 ##
 @@ -570,6 +570,32 @@ bool MKLDNNStorageType(const nnvm::NodeAttrs &attrs,
   return dispatched;
 }
 
+inline static const std::vector GetMKLDNNInputArray(const 
std::vector &inputs) {
+  std::vector ret;
+  ret.reserve(inputs.size());
+  for (const auto &in : inputs) {
+if (in.IsView() && in.IsMKLDNNData()) {
+  ret.push_back(in.Reorder2Default());
+} else {
+  ret.push_back(in);
+}
+  }
+  return ret;
+}
+void MKLDNNRun(mxnet::FComputeEx fn,
 
 Review comment:
   done
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services