[GitHub] [incubator-mxnet] sxjscience commented on issue #10227: Flaky test: test_operator.test_layer_norm
sxjscience commented on issue #10227: Flaky test: test_operator.test_layer_norm URL: https://github.com/apache/incubator-mxnet/issues/10227#issuecomment-537614136 @ChaiBapchya I mean the test would be as strict as the original. Also, fixing the seed works in some randomness tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] sxjscience commented on issue #10227: Flaky test: test_operator.test_layer_norm
sxjscience commented on issue #10227: Flaky test: test_operator.test_layer_norm URL: https://github.com/apache/incubator-mxnet/issues/10227#issuecomment-537611501 @ChaiBapchya In theory it will not if our manual backward logic is correct. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] sxjscience commented on issue #10227: Flaky test: test_operator.test_layer_norm
sxjscience commented on issue #10227: Flaky test: test_operator.test_layer_norm URL: https://github.com/apache/incubator-mxnet/issues/10227#issuecomment-537601528 @ChaiBapchya Yep, would it be possible to just test a few seeds? Also, we could somehow remove the finite-difference test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] sxjscience commented on issue #10227: Flaky test: test_operator.test_layer_norm
sxjscience commented on issue #10227: Flaky test: test_operator.test_layer_norm URL: https://github.com/apache/incubator-mxnet/issues/10227#issuecomment-537597790 I guess we need to use 1E-3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
