[GitHub] [incubator-mxnet] yuxihu commented on issue #14477: Revert "Fix memory leak for size-zero ndarray"

2019-03-19 Thread GitBox 
yuxihu commented on issue #14477: Revert "Fix memory leak for size-zero ndarray"
URL: https://github.com/apache/incubator-mxnet/pull/14477#issuecomment-474706060
 
 
   > How did you confirm the flakiness was caused by your change?
   
   One of the failures was from the code path (Storage::Get()->Free(shandle)) 
after I removed the size > 0 check.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] yuxihu commented on issue #14477: Revert "Fix memory leak for size-zero ndarray"

2019-03-19 Thread GitBox 
yuxihu commented on issue #14477: Revert "Fix memory leak for size-zero ndarray"
URL: https://github.com/apache/incubator-mxnet/pull/14477#issuecomment-474691141
 
 
   @anirudh2290 @apeforest please help merge once CI passes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services