[GitHub] Prasad9 commented on issue #8484: MXNet-to-CoreML module: Fixed KeyError for Reshape

2017-11-02 Thread GitBox
Prasad9 commented on issue #8484: MXNet-to-CoreML module: Fixed KeyError for 
Reshape
URL: https://github.com/apache/incubator-mxnet/pull/8484#issuecomment-341361564
 
 
   @tqchen , @piiswrong , I am making use of MXNet 0.12.0 version. When I am 
saving the symbol file in JSON format, I get the output in this format for 
various types of layers:
   
   ```
 {
 "op": "Convolution", 
 "name": "convolution5", 
 "attr": {
   "kernel": "(3, 3)", 
   "num_filter": "16", 
   "stride": "(1, 1)"
 }, 
 "inputs": [[6, 0, 0], [7, 0, 0], [8, 0, 0]]
   }, 
{
 "op": "Activation", 
 "name": "activation8", 
 "attr": {"act_type": "relu"}, 
 "inputs": [[15, 0, 0]]
   }, 
   {
 "op": "FullyConnected", 
 "name": "fullyconnected5", 
 "attr": {"num_hidden": "2"}, 
 "inputs": [[16, 0, 0], [17, 0, 0], [18, 0, 0]]
   }, 
   {
 "op": "Reshape", 
 "name": "reshape1", 
 "attr": {"shape": "(0, 2)"}, 
 "inputs": [[19, 0, 0]]
   }, 
   {
 "op": "transpose", 
 "name": "transpose0", 
 "attr": {"axes": "(1, 0)"}, 
 "inputs": [[20, 0, 0]]
   }, 
   {
 "op": "SoftmaxOutput", 
 "name": "softmax", 
 "inputs": [[22, 0, 0], [23, 0, 0]]
   }
   ```
   So all these layers currently are making use of keyword `attr` while 
generating the symbol file in MXNet 0.12.0 version. I checked the 
[_layers.py](https://github.com/apache/incubator-mxnet/blob/master/tools/coreml/converter/_layers.py)
 file in various branches like dev, master, ci-test, mli-patch-1 etc and the 
code in all these branches for other layers (i.e. transpose, reshape, 
activation etc) seem to be using `attr` only. I am not getting why you want it 
to be replaced with `attrs`.
   
   Or else please do let me know if you are referring to some other `attr` 
which has to be replaced with `attrs`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Prasad9 commented on issue #8484: MXNet-to-CoreML module: Fixed KeyError for Reshape

2017-11-02 Thread GitBox
Prasad9 commented on issue #8484: MXNet-to-CoreML module: Fixed KeyError for 
Reshape
URL: https://github.com/apache/incubator-mxnet/pull/8484#issuecomment-341361564
 
 
   @tqchen , @piiswrong , I am making use of MXNet 0.12.0 version. When I am 
saving the symbol file in JSON format, I get the output in this format for 
various types of layers:
   
   ```
 {
 "op": "Convolution", 
 "name": "convolution5", 
 "attr": {
   "kernel": "(3, 3)", 
   "num_filter": "16", 
   "stride": "(1, 1)"
 }, 
 "inputs": [[6, 0, 0], [7, 0, 0], [8, 0, 0]]
   }, 
   {
 "op": "Activation", 
 "name": "activation7", 
 "attr": {"act_type": "relu"}, 
 "inputs": [[9, 0, 0]]
   }, 
{
 "op": "Activation", 
 "name": "activation8", 
 "attr": {"act_type": "relu"}, 
 "inputs": [[15, 0, 0]]
   }, 
   {
 "op": "FullyConnected", 
 "name": "fullyconnected5", 
 "attr": {"num_hidden": "2"}, 
 "inputs": [[16, 0, 0], [17, 0, 0], [18, 0, 0]]
   }, 
   {
 "op": "Reshape", 
 "name": "reshape1", 
 "attr": {"shape": "(0, 2)"}, 
 "inputs": [[19, 0, 0]]
   }, 
   {
 "op": "transpose", 
 "name": "transpose0", 
 "attr": {"axes": "(1, 0)"}, 
 "inputs": [[20, 0, 0]]
   }, 
   {
 "op": "SoftmaxOutput", 
 "name": "softmax", 
 "inputs": [[22, 0, 0], [23, 0, 0]]
   }
   ```
   So all these layers currently are making use of keyword `attr` while 
generating the symbol file in MXNet 0.12.0 version. I checked the 
[_layers.py](https://github.com/apache/incubator-mxnet/blob/master/tools/coreml/converter/_layers.py)
 file in various branches like dev, master, ci-test, mli-patch-1 etc and the 
code in all these branches for other layers (i.e. transpose, reshape, 
activation etc) seem to be using `attr` only. I am not getting why you want it 
to be replaced with `attrs`.
   
   Or else please do let me know if you are referring to some other `attr` 
which has to be replaced with `attrs`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Prasad9 commented on issue #8484: MXNet-to-CoreML module: Fixed KeyError for Reshape

2017-11-02 Thread GitBox
Prasad9 commented on issue #8484: MXNet-to-CoreML module: Fixed KeyError for 
Reshape
URL: https://github.com/apache/incubator-mxnet/pull/8484#issuecomment-341361564
 
 
   @tqchen , @piiswrong , I am making using of MXNet 0.12.0 version. When I am 
saving the symbol file in JSON format, I get the output in this format for 
various types of layers:
   
   ```
 {
 "op": "Convolution", 
 "name": "convolution5", 
 "attr": {
   "kernel": "(3, 3)", 
   "num_filter": "16", 
   "stride": "(1, 1)"
 }, 
 "inputs": [[6, 0, 0], [7, 0, 0], [8, 0, 0]]
   }, 
   {
 "op": "Activation", 
 "name": "activation7", 
 "attr": {"act_type": "relu"}, 
 "inputs": [[9, 0, 0]]
   }, 
{
 "op": "Activation", 
 "name": "activation8", 
 "attr": {"act_type": "relu"}, 
 "inputs": [[15, 0, 0]]
   }, 
   {
 "op": "FullyConnected", 
 "name": "fullyconnected5", 
 "attr": {"num_hidden": "2"}, 
 "inputs": [[16, 0, 0], [17, 0, 0], [18, 0, 0]]
   }, 
   {
 "op": "Reshape", 
 "name": "reshape1", 
 "attr": {"shape": "(0, 2)"}, 
 "inputs": [[19, 0, 0]]
   }, 
   {
 "op": "transpose", 
 "name": "transpose0", 
 "attr": {"axes": "(1, 0)"}, 
 "inputs": [[20, 0, 0]]
   }, 
   {
 "op": "SoftmaxOutput", 
 "name": "softmax", 
 "inputs": [[22, 0, 0], [23, 0, 0]]
   }
   ```
   So all this layers currently are making use of keyword `attr` while 
generating the symbol file in MXNet 0.12.0 version. I checked the 
[_layers.py](https://github.com/apache/incubator-mxnet/blob/master/tools/coreml/converter/_layers.py)
 in various branches like dev, master, ci-test, mli-patch-1, all the branches 
for other layers (i.e. transpose, softmax etc) seem to be using `attr` only. I 
am not getting why you want it to be replaced with `attrs`.
   
   Or else please do let me know if you are referring to some other `attr` 
which has to be replaced with `attrs`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services