[GitHub] aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update
aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-413400855 It was actually the switch to Python 3 in CI that overlapped on this PR. Docs has been building in Python 2 prior to last week. Anyways, I believe I fixed it. Here's my test run: http://jenkins.mxnet-ci.amazon-ml.com/job/test-website-build/22/console See #12195. It needs a review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update
aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-413332107 That switching to separate Python 2 and 3 in CI is breaking this. I'm working on a patch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update
aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-411168050 So assuming this passes CI, this PR is good to go. It passed a test here: http://jenkins.mxnet-ci.amazon-ml.com/job/test-website-build/15/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update
aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-410094736 @marcoabreu I don't know much about the PR checking logic. Can you point me to it? It seems like we could scan a PR and if it matches *.scala then you run `make scalapkg` then `scaladocs`. And do a similar match for each kind of doc, rather than run all docs for every update. Conversely, if I make a .md, .js, or .html change, we don't run the full suite of CI on that PR. If docs changes are a separate pipeline, wouldn't this be possible? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update
aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-409946754 @marcoabreu this does impact CI. The scripts I modified should work seamlessly with the current jobs and reduce the website build times by half. We should chat about regularly running docs builds for PRs. The new modes would allow us to configure it to run specific sets, so if you update a Python file you don't run scaladocs. Or those are run separately... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update
aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-409780226 @marcoabreu @ankkhedia @kpmurali @szha - Please review. @vandanavk / @cclauss - I made this compatible with the R docs changes in PR #11970 - this can stack or supersede as needed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
