[GitHub] alexandraj777 commented on a change in pull request #7673: Update docs/README link and folder name
alexandraj777 commented on a change in pull request #7673: Update docs/README link and folder name URL: https://github.com/apache/incubator-mxnet/pull/7673#discussion_r136378068 ## File path: docs/build_version_doc/build_all_version.sh ## @@ -24,7 +24,7 @@ tag_list="0.11.0.rc3 master" mxnet_url="https://github.com/apache/incubator-mxnet.git; -mxnet_folder="apache_mxnet" +mxnet_folder="mxnet" Review comment: Oh duh >.< This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexandraj777 commented on a change in pull request #7673: Update docs/README link and folder name
alexandraj777 commented on a change in pull request #7673: Update docs/README link and folder name URL: https://github.com/apache/incubator-mxnet/pull/7673#discussion_r136222738 ## File path: docs/build_version_doc/build_all_version.sh ## @@ -24,7 +24,7 @@ tag_list="0.11.0.rc3 master" mxnet_url="https://github.com/apache/incubator-mxnet.git; -mxnet_folder="apache_mxnet" +mxnet_folder="mxnet" Review comment: cc @piiswrong, I didn't know if this folder was purposely different from `mxnet` to avoid conflicts This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexandraj777 commented on a change in pull request #7673: Update docs/README link and folder name
alexandraj777 commented on a change in pull request #7673: Update docs/README link and folder name URL: https://github.com/apache/incubator-mxnet/pull/7673#discussion_r136221617 ## File path: docs/README.md ## @@ -2,13 +2,13 @@ A built version of document is available at http://mxnet.io -To build the documents locally, we need to first install [docker](docker.com). +To build the documents locally, we need to first install [docker](https://docker.com). Then use the following commands to clone and build the documents. ```bash git clone --recursive https://github.com/apache/incubator-mxnet.git -cd mxnet && make docs +cd incubator-mxnet && make docs Review comment: Yeah I'd be happy to This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexandraj777 commented on a change in pull request #7673: Update docs/README link and folder name
alexandraj777 commented on a change in pull request #7673: Update docs/README link and folder name URL: https://github.com/apache/incubator-mxnet/pull/7673#discussion_r136212216 ## File path: docs/README.md ## @@ -2,13 +2,13 @@ A built version of document is available at http://mxnet.io -To build the documents locally, we need to first install [docker](docker.com). +To build the documents locally, we need to first install [docker](https://docker.com). Then use the following commands to clone and build the documents. ```bash git clone --recursive https://github.com/apache/incubator-mxnet.git -cd mxnet && make docs +cd incubator-mxnet && make docs Review comment: @piiswrong excellent suggestion! Let me know if you've like me to remove this particular change so you can defer it to a larger discussion/pr. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
