[GitHub] anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator
anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#issuecomment-401504000 @piiswrong @reminisce please merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator
anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#issuecomment-401413402 @piiswrong can this be merged? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator
anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#issuecomment-400518945 @reminisce @piiswrong ping for review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator
anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#issuecomment-397020847 @reminisce @piiswrong ping for review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator
anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#issuecomment-397020847 @reminisce ping for review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator
anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#issuecomment-394521146 @piiswrong sure, but what about consistency? Isn't it a bit confusing for users if we have [gather_nd](http://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.gather_nd) [scatter_nd](http://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.scatter_nd) and then ``shape_array`` and ``size_array``. We should have some sort of naming policy so that the same naming conventions can also be used in the future. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator
anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#issuecomment-393278649 @piiswrong Yes, it will not solve the issue. We will also need changes to define the gradient of a shape operator. Currently shape and size have no gradient defined. Also we will need changes in nnvm to propagate this information during back-propagation. gather_nd is also available in symbol - http://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.gather_nd but I am open to other name suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator
anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#issuecomment-393278649 @piiswrong Yes, it will not solve the issue. We will also need changes to define the gradient of a shape operator. Currently shape and size have no gradient defined. Also we will need changes in nnvm to propagate this information during back-propagation. gather_nd is also available in symbol - http://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.gather_nd but I am open other name suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator
anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#issuecomment-393278649 @piiswrong Yes, it will not solve the issue. We will also need changes to define the gradient of a shape operator. Currently shape and size have no gradient defined. Also we will need changes in nnvm to propagate this information during back-propagation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator
anirudhacharya commented on issue #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#issuecomment-388440258 @piiswrong shape and size are already existing ndarray operations. I changed the names to prevent confusion. Some of the other names that come to mind are - shape_operator, tensor_shape, array_shape. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
