[GitHub] apeforest commented on issue #11356: [MXNET-560][WIP] Add temperature parameter in Softmax and SoftmaxOutput operator

2018-06-27 Thread GitBox 
apeforest commented on issue #11356: [MXNET-560][WIP] Add temperature parameter 
in Softmax and SoftmaxOutput operator
URL: https://github.com/apache/incubator-mxnet/pull/11356#issuecomment-400867500
 
 
   @eric-haibin-lin unit test added this time :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] apeforest commented on issue #11356: [MXNET-560][WIP] Add temperature parameter in Softmax and SoftmaxOutput operator

2018-06-21 Thread GitBox 
apeforest commented on issue #11356: [MXNET-560][WIP] Add temperature parameter 
in Softmax and SoftmaxOutput operator
URL: https://github.com/apache/incubator-mxnet/pull/11356#issuecomment-399229133
 
 
   @eric-haibin-lin Will do once I send out the PR for merge. Since this is my 
first contribution, I would like to get some initial review on my code change 
to make sure I am following the proper styles and convention in this community.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] apeforest commented on issue #11356: [MXNET-560][WIP] Add temperature parameter in Softmax and SoftmaxOutput operator

2018-06-21 Thread GitBox 
apeforest commented on issue #11356: [MXNET-560][WIP] Add temperature parameter 
in Softmax and SoftmaxOutput operator
URL: https://github.com/apache/incubator-mxnet/pull/11356#issuecomment-399202226
 
 
   [WIP] Only added temperature parameter to softmax but not SoftmaxOutput yet 
since the latter depends on operator change in another repo (MShadow). Please 
review the change for softmax function. Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services