[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-381775912 @ThomasDelteil I agree to your suggestion on making two buckets empty with `-1`. The previous test evaluates the accuracy by MSE and uses `assert` for guaranteeing high accuracy. However, the metric should be Perplexity for multiclass classification instead of MSE. Then it turns out the accuracy is not so good because this test requires RNN to forecast random sequence of words. We could not use `assert` for the accuracy. I will update my test with the comments soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-381775912 @ThomasDelteil I agree to your suggestion on making two buckets empty with `-1`. The previous test evaluates the accuracy by MSE and uses `asserts` for guaranteeing high accuracy. However, the metric should be Perplexity for multiclass classification instead of MSE. Then it turns out the accuracy is not so good because this test requires RNN to forecast random sequence of words. We could not use `asserts` for the accuracy. I will update my test with the comments soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-381460693 @ThomasDelteil Thanks to @asitstands, I could push a test code into my branch. Now I find that all checks have passed. Could you merge my branch into master? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-381074339 @asitstands Thanks. That must be helpful for me, but I am not sure what exactly I have to do for testing. I also need to modify `test_bucketing.py` to check whether my code can work for empty buckets, which have not been considered in `test_bucketing.py`. Then I think what I have to do are - Modify and execute `test_bucketing.py` locally - Report the result of the test here? - Pull request of new `test_bucketing.py` Is it correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-380967400 @ThomasDelteil I created a ticket and added the label [MXNET-316] to the title of my PR. Do you mean you need my test code? I am not familiar with sharing a test for now. But if you want, give me a bit of time for that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-380967400 @ThomasDelteil I created a ticket and added the label [MXNET-316] to the title of my PR. Sorry, I am not familiar with sharing a test for now. Give me a bit of time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-380967400 @ThomasDelteil Thank you for your testing. I created a ticket and added the label [MXNET-316] to the title of my PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-380967400 @ThomasDelteil Thank you for your comment. I created a ticket and added the label [MXNET-316] to the title of my PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
