[GitHub] lebeg commented on a change in pull request #10297: [MXNET-244] Fixes for cross compilation in ARM
lebeg commented on a change in pull request #10297: [MXNET-244] Fixes for cross
compilation in ARM
URL: https://github.com/apache/incubator-mxnet/pull/10297#discussion_r190845064
##
File path: ci/docker/runtime_functions.sh
##
@@ -40,19 +40,24 @@ build_jetson() {
pushd .
mv make/crosscompile.jetson.mk make/config.mk
make -j$(nproc)
-
export MXNET_LIBRARY_PATH=`pwd`/libmxnet.so
cd /work/mxnet/python
-python setup.py bdist_wheel --universal
+build_wheel
+popd
+}
-# Fix pathing issues in the wheel. We need to move libmxnet.so from the
data folder to the
-# mxnet folder, then repackage the wheel.
+build_wheel() {
+set -ex
+pushd .
+python setup.py bdist_wheel --universal
WHEEL=`readlink -f dist/*.whl`
TMPDIR=`mktemp -d`
unzip -d $TMPDIR $WHEEL
rm $WHEEL
cd $TMPDIR
mv *.data/data/mxnet/libmxnet.so mxnet
+cd $TMPDIR
+#zip -r $WHEEL $TMPDIR
Review comment:
Maybe choose one style? I think ```zip -r $WHEEL $TMPDIR``` is good
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] lebeg commented on a change in pull request #10297: [MXNET-244] Fixes for cross compilation in ARM
lebeg commented on a change in pull request #10297: [MXNET-244] Fixes for cross
compilation in ARM
URL: https://github.com/apache/incubator-mxnet/pull/10297#discussion_r190844837
##
File path: ci/docker/runtime_functions.sh
##
@@ -77,7 +82,7 @@ build_armv6() {
-DUSE_OPENCV=OFF \
-DUSE_OPENMP=OFF \
-DUSE_SIGNAL_HANDLER=ON \
--DCMAKE_BUILD_TYPE=Release \
+-DCMAKE_BUILD_TYPE=RelWithDebInfo \
Review comment:
I think this should stay Release, otherwise it's too big
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] lebeg commented on a change in pull request #10297: [MXNET-244] Fixes for cross compilation in ARM
lebeg commented on a change in pull request #10297: [MXNET-244] Fixes for cross compilation in ARM URL: https://github.com/apache/incubator-mxnet/pull/10297#discussion_r190845261 ## File path: ci/docker/Dockerfile.build.armv7 ## @@ -20,13 +20,13 @@ FROM dockcross/linux-armv7 -ENV ARCH armv71 +ENV ARCH armv7 ENV CC /usr/bin/arm-linux-gnueabihf-gcc ENV CXX /usr/bin/arm-linux-gnueabihf-g++ -RUN apt-get update && \ -apt-get install -y libopenblas-dev:armhf && \ -rm -rf /var/lib/apt/lists/* +RUN apt-get update +RUN apt-get install -y libopenblas-dev:armhf unzip Review comment: Let's build openblas ouself like for other arm platforms? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lebeg commented on a change in pull request #10297: [MXNET-244] Fixes for cross compilation in ARM
lebeg commented on a change in pull request #10297: [MXNET-244] Fixes for cross compilation in ARM URL: https://github.com/apache/incubator-mxnet/pull/10297#discussion_r190845478 ## File path: tests/python/unittest/test_ndarray.py ## @@ -711,9 +711,8 @@ def get_values(ensure_unique): k=dat_size*dat_size*dat_size*dat_size, is_ascend=False) assert_almost_equal(nd_ret_argsort, gt) -# test topk with a big shape -a = mx.nd.arange(0, 54686454, step=1, repeat=1) -assert_almost_equal(a.topk(k=54686454).asnumpy(), a.asnumpy()[::-1]) +a = mx.nd.arange(0, 1024, step=1, repeat=1) Review comment: This shouldn't be part of the change, right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
