[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add
tutorial tests to the CI
URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182685641
##
File path: docs/mxdoc.py
##
@@ -367,7 +367,8 @@ def add_buttons(app, docname, source):
# source[i] = '\n'.join(lines)
def setup(app):
-app.connect("builder-inited", build_mxnet)
+if os.getenv('MXNET_DOCS_BUILD_MXNET', '1') == '1':
Review comment:
Please document this env_var somewhere
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182684516 ## File path: ci/docker/Dockerfile.build.ubuntu_gpu ## @@ -44,8 +44,14 @@ COPY install/ubuntu_llvm.sh /work/ RUN /work/ubuntu_llvm.sh COPY install/ubuntu_caffe.sh /work/ RUN /work/ubuntu_caffe.sh +COPY install/ubuntu_onnx.sh /work/ +RUN /work/ubuntu_onnx.sh COPY install/ubuntu_adduser.sh /work/ Review comment: Please make sure adduser is the last executed script This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add
tutorial tests to the CI
URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182685486
##
File path: ci/docker/runtime_functions.sh
##
@@ -385,6 +386,28 @@ unittest_ubuntu_python2_gpu() {
nosetests-2.7 --verbose tests/python/gpu
}
+tutorialtest_ubuntu_python3_gpu() {
+set -ex
+cd /work/mxnet/docs
+export MXNET_DOCS_BUILD_MXNET=0
+make html
+export MXNET_STORAGE_FALLBACK_LOG_VERBOSE=0
+export PYTHONPATH=/work/mxnet/python/
+export MXNET_TUTORIAL_TEST_KERNEL=python3
+cd /work/mxnet/tests/tutorials && nosetests-3.4 test_tutorials.py
--nologcapture
+}
+
+tutorialtest_ubuntu_python2_gpu() {
+set -ex
+cd /work/mxnet/docs
+export MXNET_DOCS_BUILD_MXNET=0
+make html
+export MXNET_STORAGE_FALLBACK_LOG_VERBOSE=0
+export PYTHONPATH=/work/mxnet/python/
+export MXNET_TUTORIAL_TEST_KERNEL=python2
+cd /work/mxnet/tests/tutorials && nosetests-3.4 test_tutorials.py
--nologcapture
Review comment:
-> nosetests-2.7
why no log capture?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add
tutorial tests to the CI
URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182686436
##
File path: tests/tutorials/test_tutorials.py
##
@@ -0,0 +1,187 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#pylint: disable=no-member, too-many-locals, too-many-branches, no-self-use,
broad-except, lost-exception, too-many-nested-blocks, too-few-public-methods,
invalid-name
+"""
+This script converts all python tutorials into python script
+and tests whether there is any warning or error.
+After running python script, it will also convert markdown files
+to notebooks to make sure notebook execution has no error.
+"""
+import os
+import warnings
+import imp
+import shutil
+import time
+import argparse
+import traceback
+import nbformat
+from nbconvert.preprocessors import ExecutePreprocessor
+import sys
+
+
+TIME_OUT = 1800
+temp_dir = 'tmp_notebook'
+
+def _test_tutorial_nb(tutorial):
+"""Run tutorial jupyter notebook to catch any execution error.
+
+Parameters
+--
+tutorial : str
+tutorial name in folder/tutorial format
+"""
+
+tutorial_dir = os.path.join(os.path.dirname(__file__), '..', '..', 'docs',
'_build', 'html', 'tutorials')
+tutorial_path = os.path.join(*([tutorial_dir] + tutorial.split('/')))
+
+kernel = os.getenv('MXNET_TUTORIAL_TEST_KERNEL', None)
+no_cache = os.getenv('MXNET_TUTORIAL_TEST_NO_CACHE', False)
+
+working_dir = os.path.join(*([temp_dir] + tutorial.split('/')))
+
+if no_cache:
+print("Cleaning and setting up temp directory
'{}'".format(working_dir))
+shutil.rmtree(temp_dir, ignore_errors=True)
+
+errors = []
+notebook = None
+if not os.path.isdir(working_dir):
+os.makedirs(working_dir)
+try:
+notebook = nbformat.read(tutorial_path + '.ipynb', as_version=4)
+if kernel is not None:
+eprocessor = ExecutePreprocessor(timeout=TIME_OUT,
kernel_name=kernel)
Review comment:
Could you document what happens in case of a timeout? We already have a
timeout mechanism in jenkins in place
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add
tutorial tests to the CI
URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182686959
##
File path: tests/tutorials/test_tutorials.py
##
@@ -0,0 +1,187 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#pylint: disable=no-member, too-many-locals, too-many-branches, no-self-use,
broad-except, lost-exception, too-many-nested-blocks, too-few-public-methods,
invalid-name
+"""
+This script converts all python tutorials into python script
+and tests whether there is any warning or error.
+After running python script, it will also convert markdown files
+to notebooks to make sure notebook execution has no error.
+"""
+import os
+import warnings
+import imp
+import shutil
+import time
+import argparse
+import traceback
+import nbformat
+from nbconvert.preprocessors import ExecutePreprocessor
+import sys
+
+
+TIME_OUT = 1800
+temp_dir = 'tmp_notebook'
+
+def _test_tutorial_nb(tutorial):
+"""Run tutorial jupyter notebook to catch any execution error.
+
+Parameters
+--
+tutorial : str
+tutorial name in folder/tutorial format
+"""
+
+tutorial_dir = os.path.join(os.path.dirname(__file__), '..', '..', 'docs',
'_build', 'html', 'tutorials')
+tutorial_path = os.path.join(*([tutorial_dir] + tutorial.split('/')))
+
+kernel = os.getenv('MXNET_TUTORIAL_TEST_KERNEL', None)
+no_cache = os.getenv('MXNET_TUTORIAL_TEST_NO_CACHE', False)
+
+working_dir = os.path.join(*([temp_dir] + tutorial.split('/')))
+
+if no_cache:
+print("Cleaning and setting up temp directory
'{}'".format(working_dir))
+shutil.rmtree(temp_dir, ignore_errors=True)
+
+errors = []
+notebook = None
+if not os.path.isdir(working_dir):
+os.makedirs(working_dir)
+try:
+notebook = nbformat.read(tutorial_path + '.ipynb', as_version=4)
+if kernel is not None:
+eprocessor = ExecutePreprocessor(timeout=TIME_OUT,
kernel_name=kernel)
+else:
+eprocessor = ExecutePreprocessor(timeout=TIME_OUT)
+nb, stuff = eprocessor.preprocess(notebook, {'metadata': {'path':
working_dir}})
+print(stuff)
+except Exception as err:
+err_msg = str(err)
+errors.append(err_msg)
+finally:
+if notebook is not None:
+output_file = os.path.join(working_dir, "output.txt")
+nbformat.write(notebook, output_file)
+output_nb = open(output_file, mode='r')
+for line in output_nb:
+if "Warning:" in line:
+errors.append("Warning:\n"+line)
+if len(errors) > 0:
+print('\n'.join(errors))
+return False
+return True
+
+
+
+def test_basic_ndarray():
+ assert _test_tutorial_nb('basic/ndarray')
+
+def test_basic_ndarray_indexing():
+assert _test_tutorial_nb('basic/ndarray_indexing')
+
+def test_basic_symbol():
+assert _test_tutorial_nb('basic/symbol')
+
+def test_basic_module():
+assert _test_tutorial_nb('basic/module')
+
+def test_basic_data():
+assert _test_tutorial_nb('basic/data')
+
+def test_gluon_customop():
+assert _test_tutorial_nb('gluon/customop')
+
+def test_gluon_data_augmentation():
+assert _test_tutorial_nb('gluon/data_augmentation')
+
+def test_gluon_datasets():
+assert True
+# Investigating flakiness with docker
+#assert _test_tutorial_nb('gluon/datasets')
Review comment:
TODO: Enable
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add
tutorial tests to the CI
URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182686527
##
File path: tests/tutorials/test_tutorials.py
##
@@ -0,0 +1,187 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#pylint: disable=no-member, too-many-locals, too-many-branches, no-self-use,
broad-except, lost-exception, too-many-nested-blocks, too-few-public-methods,
invalid-name
+"""
+This script converts all python tutorials into python script
+and tests whether there is any warning or error.
+After running python script, it will also convert markdown files
+to notebooks to make sure notebook execution has no error.
+"""
+import os
+import warnings
+import imp
+import shutil
+import time
+import argparse
+import traceback
+import nbformat
+from nbconvert.preprocessors import ExecutePreprocessor
+import sys
+
+
+TIME_OUT = 1800
+temp_dir = 'tmp_notebook'
+
+def _test_tutorial_nb(tutorial):
+"""Run tutorial jupyter notebook to catch any execution error.
+
+Parameters
+--
+tutorial : str
+tutorial name in folder/tutorial format
+"""
+
+tutorial_dir = os.path.join(os.path.dirname(__file__), '..', '..', 'docs',
'_build', 'html', 'tutorials')
+tutorial_path = os.path.join(*([tutorial_dir] + tutorial.split('/')))
+
+kernel = os.getenv('MXNET_TUTORIAL_TEST_KERNEL', None)
+no_cache = os.getenv('MXNET_TUTORIAL_TEST_NO_CACHE', False)
+
+working_dir = os.path.join(*([temp_dir] + tutorial.split('/')))
+
+if no_cache:
+print("Cleaning and setting up temp directory
'{}'".format(working_dir))
+shutil.rmtree(temp_dir, ignore_errors=True)
+
+errors = []
+notebook = None
+if not os.path.isdir(working_dir):
+os.makedirs(working_dir)
+try:
+notebook = nbformat.read(tutorial_path + '.ipynb', as_version=4)
Review comment:
Please make a constant for that version and document it
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182684832 ## File path: ci/docker/install/ubuntu_scala.sh ## @@ -23,9 +23,8 @@ set -ex # install libraries for mxnet's scala package on ubuntu apt-get install -y software-properties-common -add-apt-repository -y ppa:webupd8team/java apt-get update -echo "oracle-java8-installer shared/accepted-oracle-license-v1-1 select true" | debconf-set-selections -apt-get install -y oracle-java8-installer -apt-get install -y oracle-java8-set-default -apt-get update && apt-get install -y maven \ No newline at end of file +sleep $[ ( $RANDOM % 10 ) + 1 ]s Review comment: Please remove this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add
tutorial tests to the CI
URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182686616
##
File path: tests/tutorials/test_tutorials.py
##
@@ -0,0 +1,187 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#pylint: disable=no-member, too-many-locals, too-many-branches, no-self-use,
broad-except, lost-exception, too-many-nested-blocks, too-few-public-methods,
invalid-name
+"""
+This script converts all python tutorials into python script
+and tests whether there is any warning or error.
+After running python script, it will also convert markdown files
+to notebooks to make sure notebook execution has no error.
+"""
+import os
+import warnings
+import imp
+import shutil
+import time
+import argparse
+import traceback
+import nbformat
+from nbconvert.preprocessors import ExecutePreprocessor
+import sys
+
+
+TIME_OUT = 1800
+temp_dir = 'tmp_notebook'
+
+def _test_tutorial_nb(tutorial):
+"""Run tutorial jupyter notebook to catch any execution error.
+
+Parameters
+--
+tutorial : str
+tutorial name in folder/tutorial format
+"""
+
+tutorial_dir = os.path.join(os.path.dirname(__file__), '..', '..', 'docs',
'_build', 'html', 'tutorials')
+tutorial_path = os.path.join(*([tutorial_dir] + tutorial.split('/')))
+
+kernel = os.getenv('MXNET_TUTORIAL_TEST_KERNEL', None)
+no_cache = os.getenv('MXNET_TUTORIAL_TEST_NO_CACHE', False)
Review comment:
Please document these env-vars
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add
tutorial tests to the CI
URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182686851
##
File path: tests/tutorials/test_tutorials.py
##
@@ -0,0 +1,187 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#pylint: disable=no-member, too-many-locals, too-many-branches, no-self-use,
broad-except, lost-exception, too-many-nested-blocks, too-few-public-methods,
invalid-name
+"""
+This script converts all python tutorials into python script
+and tests whether there is any warning or error.
+After running python script, it will also convert markdown files
+to notebooks to make sure notebook execution has no error.
+"""
+import os
+import warnings
+import imp
+import shutil
+import time
+import argparse
+import traceback
+import nbformat
+from nbconvert.preprocessors import ExecutePreprocessor
+import sys
+
+
+TIME_OUT = 1800
+temp_dir = 'tmp_notebook'
+
+def _test_tutorial_nb(tutorial):
+"""Run tutorial jupyter notebook to catch any execution error.
+
+Parameters
+--
+tutorial : str
+tutorial name in folder/tutorial format
+"""
+
+tutorial_dir = os.path.join(os.path.dirname(__file__), '..', '..', 'docs',
'_build', 'html', 'tutorials')
+tutorial_path = os.path.join(*([tutorial_dir] + tutorial.split('/')))
+
+kernel = os.getenv('MXNET_TUTORIAL_TEST_KERNEL', None)
+no_cache = os.getenv('MXNET_TUTORIAL_TEST_NO_CACHE', False)
+
+working_dir = os.path.join(*([temp_dir] + tutorial.split('/')))
+
+if no_cache:
+print("Cleaning and setting up temp directory
'{}'".format(working_dir))
+shutil.rmtree(temp_dir, ignore_errors=True)
+
+errors = []
+notebook = None
+if not os.path.isdir(working_dir):
+os.makedirs(working_dir)
+try:
+notebook = nbformat.read(tutorial_path + '.ipynb', as_version=4)
+if kernel is not None:
+eprocessor = ExecutePreprocessor(timeout=TIME_OUT,
kernel_name=kernel)
+else:
+eprocessor = ExecutePreprocessor(timeout=TIME_OUT)
+nb, stuff = eprocessor.preprocess(notebook, {'metadata': {'path':
working_dir}})
+print(stuff)
+except Exception as err:
+err_msg = str(err)
+errors.append(err_msg)
+finally:
+if notebook is not None:
+output_file = os.path.join(working_dir, "output.txt")
Review comment:
This filepath makes the tests non-parallelizable. Are you going to introduce
parallelization at a later point?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182685046 ## File path: ci/docker/install/ubuntu_tutorials.sh ## @@ -0,0 +1,26 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# build and install are separated so changes to build don't invalidate +# the whole docker cache for the image + +set -ex +apt-get install graphviz python-opencv +pip2 install jupyter matplotlib Pillow opencv-python scipy scikit-learn h5py==2.8.0rc1 graphviz +pip3 install jupyter matplotlib Pillow opencv-python scipy scikit-learn h5py==2.8.0rc1 graphviz Review comment: most of these dependencies are already installed in the python script. Please make sure to remove duplicates This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add
tutorial tests to the CI
URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182684619
##
File path: ci/build.py
##
@@ -157,6 +163,11 @@ def script_name() -> str:
help="Use nvidia docker",
action='store_true')
+parser.add_argument("--shm-size",
+help="Size of the shared memory allocated for the
container (e.g '1g')",
Review comment:
Could you elaborate what this is used for? With whom is the memory being
shared with?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add
tutorial tests to the CI
URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182685164
##
File path: ci/docker/runtime_functions.sh
##
@@ -349,6 +349,7 @@ sanity_check() {
tools/license_header.py check
make cpplint rcpplint jnilint
make pylint
+nosetests-3.4 tests/tutorials/test_sanity_tutorials.py
Review comment:
nice!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI
marcoabreu commented on a change in pull request #10608: [MXNET-292] Add tutorial tests to the CI URL: https://github.com/apache/incubator-mxnet/pull/10608#discussion_r182686000 ## File path: tests/tutorials/test_sanity_tutorials.py ## @@ -0,0 +1,81 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import glob +import os +import re + +# White list of non-downloadable tutorials Review comment: Could you elaborate what non-downloadable means in this context? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
