[GitHub] marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts for running the Broken link checker job
marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts
for running the Broken link checker job
URL: https://github.com/apache/incubator-mxnet/pull/11340#discussion_r197257589
##
File path: tests/nightly/broken_link_checker_test/JenkinsfileForBLC
##
@@ -53,9 +53,19 @@ try {
parallel 'BrokenLinkChecker: CPU': {
node('mxnetlinux-cpu') {
ws('workspace/brokenLinkChecker') {
- init_git()
- sh 'aws s3 cp s3://mxnet-ci-prod-slave-data/url_list.txt
./tests/nightly/broken_link_checker_test/url_list.txt'
- docker_run('ubuntu_blc', 'broken_link_checker', false)
+ try {
+ init_git()
+ sh 'aws s3 cp
s3://mxnet-ci-prod-slave-data/url_list.txt
./tests/nightly/broken_link_checker_test/url_list.txt'
+ docker_run('ubuntu_blc', 'broken_link_checker',
false)
+ } catch (caughtError) {
+ internalError = caughtError
+ } finally {
+ sh "echo Storing the new url_list.txt to S3
bucket"
+ sh 'aws s3 cp
./tests/nightly/broken_link_checker_test/url_list.txt
s3://mxnet-ci-prod-slave-data/url_list.txt'
Review comment:
Nit: intentation
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts for running the Broken link checker job
marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts
for running the Broken link checker job
URL: https://github.com/apache/incubator-mxnet/pull/11340#discussion_r197257539
##
File path: tests/nightly/broken_link_checker_test/JenkinsfileForBLC
##
@@ -53,9 +53,19 @@ try {
parallel 'BrokenLinkChecker: CPU': {
node('mxnetlinux-cpu') {
ws('workspace/brokenLinkChecker') {
- init_git()
- sh 'aws s3 cp s3://mxnet-ci-prod-slave-data/url_list.txt
./tests/nightly/broken_link_checker_test/url_list.txt'
- docker_run('ubuntu_blc', 'broken_link_checker', false)
+ try {
+ init_git()
+ sh 'aws s3 cp
s3://mxnet-ci-prod-slave-data/url_list.txt
./tests/nightly/broken_link_checker_test/url_list.txt'
+ docker_run('ubuntu_blc', 'broken_link_checker',
false)
+ } catch (caughtError) {
Review comment:
Just make it a try-finally - there's no need to catch the error here
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts for running the Broken link checker job
marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts
for running the Broken link checker job
URL: https://github.com/apache/incubator-mxnet/pull/11340#discussion_r197257428
##
File path: tests/nightly/broken_link_checker_test/JenkinsfileForBLC
##
@@ -53,9 +53,19 @@ try {
parallel 'BrokenLinkChecker: CPU': {
node('mxnetlinux-cpu') {
ws('workspace/brokenLinkChecker') {
- init_git()
- sh 'aws s3 cp s3://mxnet-ci-prod-slave-data/url_list.txt
./tests/nightly/broken_link_checker_test/url_list.txt'
- docker_run('ubuntu_blc', 'broken_link_checker', false)
+ try {
+ init_git()
Review comment:
Nit: Indentation
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts for running the Broken link checker job
marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts
for running the Broken link checker job
URL: https://github.com/apache/incubator-mxnet/pull/11340#discussion_r197222745
##
File path: tests/nightly/broken_link_checker_test/JenkinsfileForBLC
##
@@ -0,0 +1,82 @@
+// -*- mode: groovy -*-
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+//This is a Jenkinsfile for the broken link checker test.
+
+err = null
+
+def init_git() {
+ deleteDir()
+ retry(5) {
+try {
+ timeout(time: 15, unit: 'MINUTES') {
+checkout scm
+sh 'git submodule update --init --recursive'
+sh 'git clean -d -f'
+ }
+} catch (exc) {
+ deleteDir()
+ error "Failed to fetch source codes with ${exc}"
+ sleep 2
+}
+ }
+}
+
+def docker_run(platform, function_name, use_nvidia, shared_mem = '500m') {
+ def command = "ci/build.py --docker-registry ${env.DOCKER_CACHE_REGISTRY}
%USE_NVIDIA% --platform %PLATFORM% --shm-size %SHARED_MEM%
/work/runtime_functions.sh %FUNCTION_NAME%"
+ command = command.replaceAll('%USE_NVIDIA%', use_nvidia ? '--nvidiadocker' :
'')
+ command = command.replaceAll('%PLATFORM%', platform)
+ command = command.replaceAll('%FUNCTION_NAME%', function_name)
+ command = command.replaceAll('%SHARED_MEM%', shared_mem)
+
+ sh command
+}
+
+try {
+ stage('BLC'){
+parallel 'BrokenLinkChecker: CPU': {
+ node('mxnetlinux-cpu') {
+ws('workspace/brokenLinkChecker') {
+ init_git()
+ sh 'aws s3 cp s3://mxnet-ci-prod-slave-data/url_list.txt
./tests/nightly/broken_link_checker_test/url_list.txt'
+ docker_run('ubuntu_blc', 'broken_link_checker', false)
+}
+ }
+}
+ }
+} catch (caughtError) {
+ node("mxnetlinux-cpu") {
+sh "echo caught ${caughtError}"
+err = caughtError
+currentBuild.result = "FAILURE"
+ }
+} finally {
+ node("mxnetlinux-cpu") {
+ sh "echo Storing the new url_list.txt to S3 bucket"
+sh 'aws s3 cp ./tests/nightly/broken_link_checker_test/url_list.txt
s3://mxnet-ci-prod-slave-data/url_list.txt'
Review comment:
This will not work since the previous request left the node context. Just
make a try finally at the place where we run the code and expect it to fail
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts for running the Broken link checker job
marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts for running the Broken link checker job URL: https://github.com/apache/incubator-mxnet/pull/11340#discussion_r196617428 ## File path: tests/nightly/broken_link_checker_test/README.md ## @@ -0,0 +1,13 @@ +# Broken link checker test Review comment: Great! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts for running the Broken link checker job
marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts
for running the Broken link checker job
URL: https://github.com/apache/incubator-mxnet/pull/11340#discussion_r196617399
##
File path: tests/nightly/broken_link_checker_test/JenkinsfileForBLC
##
@@ -0,0 +1,74 @@
+// -*- mode: groovy -*-
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+//This is a Jenkinsfile for the broken link checker test.
+
+err = null
+
+def init_git() {
+ deleteDir()
+ retry(5) {
+try {
+ timeout(time: 15, unit: 'MINUTES') {
+checkout scm
+sh 'git submodule update --init --recursive'
+sh 'git clean -d -f'
+ }
+} catch (exc) {
+ deleteDir()
+ error "Failed to fetch source codes with ${exc}"
+ sleep 2
+}
+ }
+}
+
+
+try {
+ stage('BLC'){
+parallel 'BrokenLinkChecker: CPU': {
+ node('mxnetlinux-cpu') {
+ws('workspace/brokenLinkChecker') {
+ init_git()
+ withCredentials([usernamePassword(credentialsId: 'github-leleamol',
passwordVariable: 'APACHE_PASSWORD', usernameVariable: 'APACHE_USERNAME')]) {
+ sh 'aws s3 cp s3://mxnet-ci-prod-slave-data/url_list.txt
./tests/nightly/broken_link_checker_test/url_list.txt'
+ sh "ci/build.py --platform ubuntu_blc /work/runtime_functions.sh
broken_link_checker"
Review comment:
Please use the docker_run from the main Jenkinsfile. Otherwise, this run
will not use our docker cache and slow down the run.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts for running the Broken link checker job
marcoabreu commented on a change in pull request #11340: [MXNET-559] Scripts
for running the Broken link checker job
URL: https://github.com/apache/incubator-mxnet/pull/11340#discussion_r196617118
##
File path: tests/nightly/broken_link_checker_test/JenkinsfileForBLC
##
@@ -0,0 +1,74 @@
+// -*- mode: groovy -*-
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+//This is a Jenkinsfile for the broken link checker test.
+
+err = null
+
+def init_git() {
+ deleteDir()
+ retry(5) {
+try {
+ timeout(time: 15, unit: 'MINUTES') {
+checkout scm
+sh 'git submodule update --init --recursive'
+sh 'git clean -d -f'
+ }
+} catch (exc) {
+ deleteDir()
+ error "Failed to fetch source codes with ${exc}"
+ sleep 2
+}
+ }
+}
+
+
+try {
+ stage('BLC'){
+parallel 'BrokenLinkChecker: CPU': {
+ node('mxnetlinux-cpu') {
+ws('workspace/brokenLinkChecker') {
+ init_git()
+ withCredentials([usernamePassword(credentialsId: 'github-leleamol',
passwordVariable: 'APACHE_PASSWORD', usernameVariable: 'APACHE_USERNAME')]) {
Review comment:
Do we still need the credentials?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
