[GitHub] mbaijal commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master
mbaijal commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master URL: https://github.com/apache/incubator-mxnet/pull/8704#discussion_r153312149 ## File path: docs/build_version_doc/build_all_version.sh ## @@ -21,7 +21,7 @@ # Built files are stored in $built # Version numbers are stored in $tag_list. # Version numbers are ordered from latest to old and final one is master. -tag_list="0.12.0 0.11.0 master" +tag_list="1.0.0 0.12.0 0.11.0 master" Review comment: @szha I have reverted the tag to 0.12.1 in the two places mentioned. Does this look ok now? However I think this build script 'build_all_version.sh' is only for local testing it does not actually need the listed tag to be available on github. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mbaijal commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master
mbaijal commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master URL: https://github.com/apache/incubator-mxnet/pull/8704#discussion_r152447463 ## File path: docs/build_version_doc/build_all_version.sh ## @@ -21,7 +21,7 @@ # Built files are stored in $built # Version numbers are stored in $tag_list. # Version numbers are ordered from latest to old and final one is master. -tag_list="0.12.0 0.11.0 master" +tag_list="1.0.0 0.12.0 0.11.0 master" Review comment: @szha Could you please merge this into the 1.0.0 branch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mbaijal commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master
mbaijal commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master URL: https://github.com/apache/incubator-mxnet/pull/8704#discussion_r152108829 ## File path: docs/build_version_doc/build_all_version.sh ## @@ -21,7 +21,7 @@ # Built files are stored in $built # Version numbers are stored in $tag_list. # Version numbers are ordered from latest to old and final one is master. -tag_list="0.12.0 0.11.0 master" +tag_list="1.0.0 0.12.0 0.11.0 master" Review comment: Sure. @szha you wanted python/mxnet/libinfo.py updated with 1.0 correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
