[GitHub] pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.

2018-05-20 Thread GitBox
pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.
URL: https://github.com/apache/incubator-mxnet/pull/10979#issuecomment-390527207
 
 
   @zheng-da Exactly. The exception is thrown in here. 
   We have a local fix for `GetMKLDNNData` to get the target data format and we 
will submit the PR soon.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.

2018-05-16 Thread GitBox
pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.
URL: https://github.com/apache/incubator-mxnet/pull/10979#issuecomment-389707273
 
 
   @zheng-da  Could you add more descriptions (or change title) in order to 
make the PR readable?
   
   please try the case a3c, `const mkldnn::memory *NDArray::GetMKLDNNData` will 
return nullptr since two mem format is not equal.
   Do you think we need to fix this issue in this PR too? 
   
https://github.com/apache/incubator-mxnet/tree/master/example/reinforcement-learning/a3c
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.

2018-05-16 Thread GitBox
pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.
URL: https://github.com/apache/incubator-mxnet/pull/10979#issuecomment-389707273
 
 
   @zheng-da  Could you add more descriptions (or change title) in order to 
make the PR readable?
   
   please try the case a3c, GetMKLDNNData will return nullptr since two mem 
format is not equal.
   Do you think we need to fix this issue in this PR too? 
   
https://github.com/apache/incubator-mxnet/tree/master/example/reinforcement-learning/a3c
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.

2018-05-16 Thread GitBox
pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.
URL: https://github.com/apache/incubator-mxnet/pull/10979#issuecomment-389707273
 
 
   @zheng-da  Could you add more descriptions (or change title) in order to 
make the PR readable?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services