[GitHub] piiswrong commented on issue #8010: Revert "Many loss functions (#7605)"

2017-09-24 Thread git 
piiswrong commented on issue #8010: Revert "Many loss functions  (#7605)"
URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331689434
 
 
   That's fixing forward on untested code.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] piiswrong commented on issue #8010: Revert "Many loss functions (#7605)"

2017-09-23 Thread git 
piiswrong commented on issue #8010: Revert "Many loss functions  (#7605)"
URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331689206
 
 
   For one thing, the names are inconsistent.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] piiswrong commented on issue #8010: Revert "Many loss functions (#7605)"

2017-09-23 Thread git 
piiswrong commented on issue #8010: Revert "Many loss functions  (#7605)"
URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331688804
 
 
   Roll back is always better than fix forward. This is directly user facing 
top level API. It needs to be tested.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] piiswrong commented on issue #8010: Revert "Many loss functions (#7605)"

2017-09-23 Thread git 
piiswrong commented on issue #8010: Revert "Many loss functions  (#7605)"
URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331688229
 
 
   This is a large amount of untested user facing code. That's enough ground 
for a veto.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services