[GitHub] reminisce commented on issue #8246: Continued Work on Advanced Indexing
reminisce commented on issue #8246: Continued Work on Advanced Indexing URL: https://github.com/apache/incubator-mxnet/pull/8246#issuecomment-374781422 @cjolivier01 For assigning a value to a whole array, it still calls `_internal._full`. Are there any other places you expect to call `_full`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reminisce commented on issue #8246: Continued Work on Advanced Indexing
reminisce commented on issue #8246: Continued Work on Advanced Indexing URL: https://github.com/apache/incubator-mxnet/pull/8246#issuecomment-343993705 @meanmee This is a feature for 1.0 which is coming soon. Thanks for your interest. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reminisce commented on issue #8246: Continued Work on Advanced Indexing
reminisce commented on issue #8246: Continued Work on Advanced Indexing URL: https://github.com/apache/incubator-mxnet/pull/8246#issuecomment-343549343 @piiswrong @eric-haibin-lin @szha I added support for `__setitem__` and simplified basic and advanced indexing dispatching logic. Please review again. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reminisce commented on issue #8246: Continued Work on Advanced Indexing
reminisce commented on issue #8246: Continued Work on Advanced Indexing URL: https://github.com/apache/incubator-mxnet/pull/8246#issuecomment-338322812 @JeanKossaifi Thanks for the comment. This only implements `__getitem__` of `NDArray`. We will add support for `__setitem__` later and add it to the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
