slyforce opened a new pull request #13984: Python BucketingModule bind() with grad_req = 'add' URL: https://github.com/apache/incubator-mxnet/pull/13984 ## Description ## This pull request adds the possibility of changing the `grad_req` of `BucketingModule` to values other than the default `'write'` in the Python interface. Previously, `grad_req` would default to `'write'` every time the bucket is switched causing gradient accumulation not to work whenever a non-default bucket key was used. Also a new unit-test case has been added to test 1. the correct binding of sub-modules and 2. gradient accumulation with different `grad_req` values. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [x] BucketingModule now remembers `grad_req` from bind() call. , - [x] Unit-test for different values of `grad_req` for BucketingModule.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
