[GitHub] spidyDev commented on a change in pull request #10472: [MXNET-106] [ONNX_MXNet] Change parameter names in imported model
spidyDev commented on a change in pull request #10472: [MXNET-106] [ONNX_MXNet]
Change parameter names in imported model
URL: https://github.com/apache/incubator-mxnet/pull/10472#discussion_r180247510
##
File path: tests/python-pytest/onnx/onnx_test.py
##
@@ -214,8 +211,8 @@ def test_bvlc_reference_caffenet():
# run test for each test file
for input_data, output_data in zip(inputs, outputs):
# create module
-mod = mx.mod.Module(symbol=sym, data_names=['input_0'],
context=mx.cpu(), label_names=None)
-mod.bind(for_training=False, data_shapes=[('input_0',
input_data.shape)], label_shapes=None)
+mod = mx.mod.Module(symbol=sym, data_names=['data_0'],
context=mx.cpu(), label_names=None)
Review comment:
same as above
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] spidyDev commented on a change in pull request #10472: [MXNET-106] [ONNX_MXNet] Change parameter names in imported model
spidyDev commented on a change in pull request #10472: [MXNET-106] [ONNX_MXNet]
Change parameter names in imported model
URL: https://github.com/apache/incubator-mxnet/pull/10472#discussion_r180247544
##
File path: tests/python-pytest/onnx/onnx_test.py
##
@@ -214,8 +211,8 @@ def test_bvlc_reference_caffenet():
# run test for each test file
for input_data, output_data in zip(inputs, outputs):
# create module
-mod = mx.mod.Module(symbol=sym, data_names=['input_0'],
context=mx.cpu(), label_names=None)
-mod.bind(for_training=False, data_shapes=[('input_0',
input_data.shape)], label_shapes=None)
+mod = mx.mod.Module(symbol=sym, data_names=['data_0'],
context=mx.cpu(), label_names=None)
+mod.bind(for_training=False, data_shapes=[('data_0',
input_data.shape)], label_shapes=None)
Review comment:
same as above
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] spidyDev commented on a change in pull request #10472: [MXNET-106] [ONNX_MXNet] Change parameter names in imported model
spidyDev commented on a change in pull request #10472: [MXNET-106] [ONNX_MXNet]
Change parameter names in imported model
URL: https://github.com/apache/incubator-mxnet/pull/10472#discussion_r180247473
##
File path: tests/python-pytest/onnx/onnx_test.py
##
@@ -192,8 +189,8 @@ def test_bvlc_googlenet():
# run test for each test file
for input_data, output_data in zip(inputs, outputs):
# create module
-mod = mx.mod.Module(symbol=sym, data_names=['input_0'],
context=mx.cpu(), label_names=None)
-mod.bind(for_training=False, data_shapes=[('input_0',
input_data.shape)], label_shapes=None)
+mod = mx.mod.Module(symbol=sym, data_names=['data_0'],
context=mx.cpu(), label_names=None)
Review comment:
Can we fetch the data_names from sym ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] spidyDev commented on a change in pull request #10472: [MXNET-106] [ONNX_MXNet] Change parameter names in imported model
spidyDev commented on a change in pull request #10472: [MXNET-106] [ONNX_MXNet]
Change parameter names in imported model
URL: https://github.com/apache/incubator-mxnet/pull/10472#discussion_r180247574
##
File path: tests/python-pytest/onnx/onnx_test.py
##
@@ -236,8 +233,8 @@ def test_bvlc_rcnn_ilsvrc13():
# run test for each test file
for input_data, output_data in zip(inputs, outputs):
# create module
-mod = mx.mod.Module(symbol=sym, data_names=['input_0'],
context=mx.cpu(), label_names=None)
-mod.bind(for_training=False, data_shapes=[('input_0',
input_data.shape)], label_shapes=None)
+mod = mx.mod.Module(symbol=sym, data_names=['data_0'],
context=mx.cpu(), label_names=None)
Review comment:
same as above
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
