[GitHub] szha commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox 
szha commented on issue #10115: Compile MKLDNN in Mac.
URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373172868
 
 
   Given that our CI doesn't have mac yet, please verify the new logic locally.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] szha commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox 
szha commented on issue #10115: Compile MKLDNN in Mac.
URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373176486
 
 
   Does the current logic require re-building mkldnn at every `make`? Is 
caching the build artifact possible?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] szha commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox 
szha commented on issue #10115: Compile MKLDNN in Mac.
URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373179591
 
 
   This needs to be fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] szha commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox 
szha commented on issue #10115: Compile MKLDNN in Mac.
URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373238530
 
 
   clang build is different from building on mac. For example, clang build 
won't catch the processor detection problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services