[GitHub] szha commented on issue #10773: specify common arch for mkldnn build, so it can be reused on all arch
szha commented on issue #10773: specify common arch for mkldnn build, so it can be reused on all arch URL: https://github.com/apache/incubator-mxnet/pull/10773#issuecomment-401564711 Hi all. Since the script on which this patch was proposed no longer exist, I'm closing this PR. If this fix is still relevant or you'd like further discussion on the approach, feel free to open another PR/issue. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #10773: specify common arch for mkldnn build, so it can be reused on all arch
szha commented on issue #10773: specify common arch for mkldnn build, so it can be reused on all arch URL: https://github.com/apache/incubator-mxnet/pull/10773#issuecomment-386192015 the bottomline is, the current solution happens at build-time. build-time environment is different from run-time environment. if the integration code is not performance-critical, we should make sure the specified option is supported on any arch that mxnet supports. if it is, then a patch for run-time switching is necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #10773: specify common arch for mkldnn build, so it can be reused on all arch
szha commented on issue #10773: specify common arch for mkldnn build, so it can be reused on all arch URL: https://github.com/apache/incubator-mxnet/pull/10773#issuecomment-386184711 @TaoLv that means we need to at least compromise the performance of the pre-built binary, and I'd rather we don't go down that route. can we instead make a similar option to DYNAMIC_ARCH in openblas? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #10773: specify common arch for mkldnn build, so it can be reused on all arch
szha commented on issue #10773: specify common arch for mkldnn build, so it can be reused on all arch URL: https://github.com/apache/incubator-mxnet/pull/10773#issuecomment-386146093 Why is arch needed? cc'd @zheng-da This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
