[GitHub] szha commented on issue #8010: Revert "Many loss functions (#7605)"
szha commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331689320 Like I commented in the third comment, the naming has been fixed in #8007 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #8010: Revert "Many loss functions (#7605)"
szha commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331689054 Only when there's known bug in the code, at which time we should roll back the part with bugs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #8010: Revert "Many loss functions (#7605)"
szha commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331688529 Has there been known bugs or issues? If not, I'd suggest that a better path is forward, by applying the appropriate fixes. #7605 was opened a month ago and there has been plenty of time for you and other reviewers to look at and comment on that PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #8010: Revert "Many loss functions (#7605)"
szha commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331687530 For the record, I've been helping @smolix cleaning up the naming in #8007, cleaning doc in #7914. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #8010: Revert "Many loss functions (#7605)"
szha commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331687376 Shouldn't you at least talk to the contributor before reverting this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
