[GitHub] szha commented on issue #8475: Move OpenMP calculations into its own class
szha commented on issue #8475: Move OpenMP calculations into its own class URL: https://github.com/apache/incubator-mxnet/pull/8475#issuecomment-341876430 @cjolivier01 do you really consider it appropriate and suitable as committer the behavior of deleting other people's comment before reaching consensus? Personally I think this is offensive. I'd suggest that you raise discussion with @apache/mxnet-committers and make sure to get other people's consensus before deleting another comment. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #8475: Move OpenMP calculations into its own class
szha commented on issue #8475: Move OpenMP calculations into its own class URL: https://github.com/apache/incubator-mxnet/pull/8475#issuecomment-341774298 And still merging ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #8475: Move OpenMP calculations into its own class
szha commented on issue #8475: Move OpenMP calculations into its own class URL: https://github.com/apache/incubator-mxnet/pull/8475#issuecomment-341774298 And still merging ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #8475: Move OpenMP calculations into its own class
szha commented on issue #8475: Move OpenMP calculations into its own class URL: https://github.com/apache/incubator-mxnet/pull/8475#issuecomment-341575139 If there are conflicts when rebasing on a commit, the same conflict needs to be resolved when merging. Merged commits would also show up in the diff. Effectively, the burden of separating your changes from merged changes is shifted to the reviewers by the practice of clicking merges. It's easier for you and harder for others. It would be idea if there's a middle-ground that doesn't incur difficulty of reviewing. Unfortunately I'm not aware of one. Feel free to share if you know better. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
