[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-461953059 log_softmax return type https://github.com/apache/incubator-mxnet/pull/14098#pullrequestreview-201770450 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-456239673 In 2.0, the CAPI should not expose backend-specific types, such as `mkldnn::memory`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-439540998 @kohr-h yes, having 0th order tensor support is important. Regarding the approach, we may not want to implement it as an asscalar() call, since that's a blocking call. Instead, we should extend the tensor definition so that calculation involving such scalar can still be asynchronous. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-430826219 @anirudhacharya yes, because dataset interface has a `.transform` method that serves the same purpose but strictly more flexible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-413638378 #12197 in using integer types for index instead of float. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-410395720 #11953 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-408962256 Gluon RNN layer parameters are currently saved through unfused cells, causing the name to be something like "_unfused.0.l_cell.weight". This caused trouble in #11482 when I removed unfused cells. The workaround is to override _collect_params_with_prefix function to add the prefix. In 2.0, we should: - [ ] remove the _collect_params_with_prefix in Gluon RNN layer - [ ] write a converter for parameter formats - [ ] start versioning parameter files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-394520118 #11134 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-394519762 #11141 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-393338016 #10807 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-392667647 #11031 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-389740264 contrib.ctc_loss should make into supported operator. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-387964643 we should merge element wise ops with broadcast ops and dispatch the different implementation only based on the shape, so that symbol and ndarray +-*/ are consistent This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
