thatindiandude commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331689293 I think rudimentary tests aren't much too ask for. This would expose such bugs that currently aren't known. The idea that you can push untested code because a known bug doesn't exist contradicts test-driven development principles. On Sep 23, 2017 10:51 PM, "Sheng Zha" <notificati...@github.com> wrote: > Only when there's known bug in the code, at which time we should roll back > the part with bugs. > > ? > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331689054>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AB5oAAHWbp3K2WWDFGjLeHHJdcvYbH0pks5sle3ugaJpZM4Phxin> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
