[GitHub] zheng-da commented on issue #11047: Enhance mkldnn pooling to support full convention
zheng-da commented on issue #11047: Enhance mkldnn pooling to support full convention URL: https://github.com/apache/incubator-mxnet/pull/11047#issuecomment-392084012 the test can't really cover the cases we want. it didn't detect the bug before @ashokei disabled full convention. you can change its stride to (3, 3) or something to make sure `i_h +pad_top + pad_bottom - k_h` can't be divided by `stride_h `. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zheng-da commented on issue #11047: Enhance mkldnn pooling to support full convention
zheng-da commented on issue #11047: Enhance mkldnn pooling to support full convention URL: https://github.com/apache/incubator-mxnet/pull/11047#issuecomment-391801847 can you write unit tests for this? Could you also explain what is the difference between full and valid? I know it has something to do with padding, but I don't remember the details. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
