[mynewt-core] 01/01: Merge pull request #513 from wes3/lora_improv
This is an automated email from the ASF dual-hosted git repository. wes3 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 141e0ff058b70393c7286fdec72d74e36758f57a Merge: 9b94b71 4abf63f Author: wes3AuthorDate: Thu Aug 31 22:35:03 2017 -0700 Merge pull request #513 from wes3/lora_improv Lora improv apps/lora_app_shell/syscfg.yml |2 +- hw/drivers/lora/sx1276/src/sx1276.c | 78 +- net/lora/node/include/node/lora.h| 19 + net/lora/node/include/node/mac/LoRaMac.h |8 +- net/lora/node/src/lora_node.c| 35 +- net/lora/node/src/mac/LoRaMac.c | 1463 +++--- net/lora/node/src/utilities.c|4 +- net/lora/node/syscfg.yml | 16 + 8 files changed, 847 insertions(+), 778 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[GitHub] wes3 commented on issue #513: Lora improv
wes3 commented on issue #513: Lora improv URL: https://github.com/apache/mynewt-core/pull/513#issuecomment-326492382 I know what you mean re: some of the exported symbols. I can change them prior to release if folks think it is important. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-site] 01/01: Merge pull request #320 from runtime-bot/asf-site
This is an automated email from the ASF dual-hosted git repository. aditi pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/mynewt-site.git commit e1a3e1d5ae0615dcfacc1a84fc8a7db4974f585c Merge: 1d8d8a4 200eb26 Author: aditihilbertAuthorDate: Thu Aug 31 20:49:24 2017 -0700 Merge pull request #320 from runtime-bot/asf-site automated asf-site build latest/mkdocs/search_index.json | 83 ++-- latest/os/core_os/porting/port_bsp/index.html | 618 -- latest/os/tutorials/blinky_console/index.html | 10 +- mkdocs/search_index.json | 83 ++-- os/core_os/porting/port_bsp/index.html| 618 -- os/tutorials/blinky_console/index.html| 10 +- 6 files changed, 864 insertions(+), 558 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[GitHub] aditihilbert closed pull request #320: automated asf-site build
aditihilbert closed pull request #320: automated asf-site build URL: https://github.com/apache/mynewt-site/pull/320 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-site] branch asf-site updated (1d8d8a4 -> e1a3e1d)
This is an automated email from the ASF dual-hosted git repository. aditi pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/mynewt-site.git. from 1d8d8a4 Merge pull request #319 from runtime-bot/asf-site add 200eb26 asf-site update Fri Sep 1 03:39:56 UTC 2017 new e1a3e1d Merge pull request #320 from runtime-bot/asf-site The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: latest/mkdocs/search_index.json | 83 ++-- latest/os/core_os/porting/port_bsp/index.html | 618 -- latest/os/tutorials/blinky_console/index.html | 10 +- mkdocs/search_index.json | 83 ++-- os/core_os/porting/port_bsp/index.html| 618 -- os/tutorials/blinky_console/index.html| 10 +- 6 files changed, 864 insertions(+), 558 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[GitHub] ccollins476ad commented on issue #511: nimble: Port Bluetooth Mesh from Zephyr to Mynewt
ccollins476ad commented on issue #511: nimble: Port Bluetooth Mesh from Zephyr to Mynewt URL: https://github.com/apache/mynewt-core/pull/511#issuecomment-326463346 Looks really good. Wow, that is a lot of code! :) I have some review comments. I am not very familiar with the Bluetooth mesh spec, so I focused most of my attention on the Mynewt-specific parts of this PR. Also, I understand that a goal is to modify this code as little as possible to make it easier to accept upstream changes. I agree that this is a good idea. If some of my comments oppose this goal, then you should feel free to ignore them. Anyway, here are my comments: --- `net/nimble/host/mesh/include/mesh/glue.h:NET_BUF_SIMPLE()` This macro may yield NULL, so the resulting mbuf should be checked by the caller. If it is not practical to modify all the instances where this macro gets invoked, I would add an `assert()` to the macro. --- `net/nimble/host/mesh/src/glue.c:bt_gatt_get_mtu()` Is this function needed? If you remove it, then you can also remove the include of private header "../src/ble_hs_conn_priv.h" --- `net/nimble/host/mesh/src/glue.c:net_buf_simple_pull()` `net/nimble/host/mesh/src/glue.c:net_buf_simple_pull_le16()` `net/nimble/host/mesh/src/glue.c:net_buf_simple_pull_be16()` `net/nimble/host/mesh/src/glue.c:net_buf_simple_pull_be32()` These might not be safe. I see two possible issues: 1. source mbuf is too small 2. data is split over multiple mbufs in a chain. In both cases, these function read past the end of the mbuf buffer. I suggest calling `os_mbuf_pullup()` at the start of these functions. --- `net/nimble/host/mesh/src/glue.c:net_buf_simple_push()` `net/nimble/host/mesh/src/glue.c:net_buf_simple_push_u8()` `net/nimble/host/mesh/src/glue.c:net_buf_simple_push_le16()` `net/nimble/host/mesh/src/glue.c:net_buf_simple_push_be16()` These functions seem to duplicate the functionality of `os_mbuf_prepend()`. I suggest calling `os_mbuf_prepend()` within these functions. --- `net/nimble/host/mesh/src/glue.c:bt_pub_key_gen()` There is some dead code inside an `if (0)` at the top. --- `net/nimble/host/mesh/src/glue.c:net_buf_reserve()` I would use os_mbuf_adj() here instead of adjusting the data pointer manually, just to be sure the resulting mbuf is valid. --- `net/nimble/host/mesh/src/adv.h:BT_MESH_ADV()` This macro looks like a copy of `OS_MBUF_USRHDR()` with a cast. It might be better if this macro calls `OS_MBUF_USRHDR()` rather than duplicating the code. --- `net/nimble/host/mesh/src/beacon.c:secure_beacon_recv()` You might want to call `os_mbuf_pullup(buf, 21)` at the start of this function. --- `net/nimble/host/mesh/src/cfg.c:get_model()` Consider calling `os_mbuf_pullup(buf, 4)` at the start of this function. --- `net/nimble/host/mesh/src/mesh_priv.h` the `struct bt_mesh_net;` forward declaration seems unnecessary. --- `net/nimble/host/mesh/src/prov.c:bt_mesh_input_string()` Is `strncpy()` the correct function to use here? If `strlen(str) >= prov->output_size`, then `link.auth` won't be null-terminated. --- `net/nimble/host/mesh/src/prov.c:prov_data()` Does `msg` leak if `bt_mesh_session_key()` fails? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-site] 01/01: Merge pull request #318 from cwanda/doc_updates
This is an automated email from the ASF dual-hosted git repository. aditi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-site.git commit 6c745af882ca6bd1f2a2c277461cb894be36030b Merge: 4946a6c 6dcee7d Author: aditihilbertAuthorDate: Thu Aug 31 17:44:42 2017 -0700 Merge pull request #318 from cwanda/doc_updates Tell user to replace console/stub with console/full docs/os/tutorials/blinky_console.md | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[mynewt-site] 01/01: Merge pull request #316 from ccollins476ad/port-bsp
This is an automated email from the ASF dual-hosted git repository. aditi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-site.git commit 4946a6c4f981b5e6b7e3e9d70e6c6cfe0c370e1b Merge: aecd8c3 9bc44a0 Author: aditihilbertAuthorDate: Thu Aug 31 17:44:28 2017 -0700 Merge pull request #316 from ccollins476ad/port-bsp Update the "BSP Porting" page. docs/os/core_os/porting/port_bsp.md | 491 1 file changed, 336 insertions(+), 155 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[mynewt-site] branch master updated (aecd8c3 -> 4946a6c)
This is an automated email from the ASF dual-hosted git repository. aditi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-site.git. from aecd8c3 Merge pull request #315 from francois-berder/fix-supported-boards add 9bc44a0 Update the "BSP Porting" page. new 4946a6c Merge pull request #316 from ccollins476ad/port-bsp The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/os/core_os/porting/port_bsp.md | 491 1 file changed, 336 insertions(+), 155 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[mynewt-site] 01/01: Merge pull request #315 from francois-berder/fix-supported-boards
This is an automated email from the ASF dual-hosted git repository. aditi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-site.git commit aecd8c39556973456b6548b67794e3a7a148a3c1 Merge: c62341f 971b4fe Author: aditihilbertAuthorDate: Thu Aug 31 17:25:59 2017 -0700 Merge pull request #315 from francois-berder/fix-supported-boards Fix links for 6LoWPAN clicker and chipKIT wifire custom-theme/landing.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[mynewt-core] branch master updated (2c82c87 -> 9b94b71)
This is an automated email from the ASF dual-hosted git repository. fberder pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 2c82c87 Merge pull request #518 from MADApparel/master add 31ca0b8 pic32 i2c receive now waits for end of ack new 9b94b71 Merge pull request #515 from vsyn/pic32-i2c-ackfix The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: hw/mcu/microchip/pic32mx470f512h/src/hal_i2c.c | 2 +- hw/mcu/microchip/pic32mz2048efg100/src/hal_i2c.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[GitHub] francois-berder closed pull request #515: pic32 i2c receive now waits for end of ack
francois-berder closed pull request #515: pic32 i2c receive now waits for end of ack URL: https://github.com/apache/mynewt-core/pull/515 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] 01/01: Merge pull request #518 from MADApparel/master
This is an automated email from the ASF dual-hosted git repository. marko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 2c82c87352905785f7f13777d2364a03913ec48d Merge: e3c41b9 2b82c8c Author: mkiiskilaAuthorDate: Thu Aug 31 13:51:55 2017 -0700 Merge pull request #518 from MADApparel/master Added baud rates 1200, 2400, 4800 to nrf52xxx hw/mcu/nordic/nrf52xxx/src/hal_uart.c | 6 ++ 1 file changed, 6 insertions(+) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[GitHub] mkiiskila closed pull request #518: Added baud rates 1200, 2400, 4800 to nrf52xxx
mkiiskila closed pull request #518: Added baud rates 1200, 2400, 4800 to nrf52xxx URL: https://github.com/apache/mynewt-core/pull/518 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] branch master updated (e3c41b9 -> 2c82c87)
This is an automated email from the ASF dual-hosted git repository. marko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from e3c41b9 Merge pull request #499 from ccollins476ad/rm-nffs-area-max add 2b82c8c Added baud rates 1200, 2400, 4800 to nrf52xxx new 2c82c87 Merge pull request #518 from MADApparel/master The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: hw/mcu/nordic/nrf52xxx/src/hal_uart.c | 6 ++ 1 file changed, 6 insertions(+) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[GitHub] tnyqu opened a new pull request #518: Added baud rates 1200, 2400, 4800 to nrf52xxx
tnyqu opened a new pull request #518: Added baud rates 1200, 2400, 4800 to nrf52xxx URL: https://github.com/apache/mynewt-core/pull/518 Signed-off-by: Tony QuThis is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] 01/01: Merge pull request #499 from ccollins476ad/rm-nffs-area-max
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit e3c41b92a08a7ecd5c6ceb0cf6d9a01fee4c71aa Merge: a9ff0cc 7746be4 Author: ccollins476adAuthorDate: Thu Aug 31 12:26:33 2017 -0700 Merge pull request #499 from ccollins476ad/rm-nffs-area-max Convert some defines in `bsp.h` to syscfg settings apps/testbench/src/testbench.h | 11 --- boot/boot_serial/src/boot_serial.c | 21 - {fs/nffs => boot/boot_serial}/syscfg.yml | 34 -- boot/boot_serial/test/syscfg.yml | 2 ++ fs/nffs/src/nffs.c | 4 +-- fs/nffs/syscfg.yml | 6 hw/bsp/ada_feather_nrf52/include/bsp/bsp.h | 11 --- hw/bsp/ada_feather_nrf52/syscfg.yml| 1 + hw/bsp/arduino_primo_nrf52/include/bsp/bsp.h | 2 -- hw/bsp/bbc_microbit/include/bsp/bsp.h | 2 -- hw/bsp/ble400/include/bsp/bsp.h| 2 -- hw/bsp/bmd200/include/bsp/bsp.h| 2 -- hw/bsp/bmd300eval/include/bsp/bsp.h| 2 -- hw/bsp/ci40/include/bsp/bsp.h | 2 -- hw/bsp/frdm-k64f/include/bsp/bsp.h | 8 - hw/bsp/native-armv7/include/bsp/bsp.h | 2 -- hw/bsp/native-mips/include/bsp/bsp.h | 2 -- hw/bsp/native/include/bsp/bsp.h| 2 -- hw/bsp/nina-b1/include/bsp/bsp.h | 12 hw/bsp/nina-b1/syscfg.yml | 2 ++ hw/bsp/nrf51-arduino_101/include/bsp/bsp.h | 2 -- hw/bsp/nrf51-blenano/include/bsp/bsp.h | 2 -- hw/bsp/nrf51dk-16kbram/include/bsp/bsp.h | 2 -- hw/bsp/nrf51dk/include/bsp/bsp.h | 2 -- hw/bsp/nrf52-thingy/include/bsp/bsp.h | 11 --- hw/bsp/nrf52-thingy/syscfg.yml | 1 + hw/bsp/nrf52840pdk/include/bsp/bsp.h | 2 -- hw/bsp/nrf52dk/include/bsp/bsp.h | 11 --- hw/bsp/nrf52dk/syscfg.yml | 1 + hw/bsp/nucleo-f401re/include/bsp/bsp.h | 2 -- .../olimex_stm32-e407_devboard/include/bsp/bsp.h | 2 -- hw/bsp/pic32mx470_6lp_clicker/include/bsp/bsp.h| 2 -- hw/bsp/pic32mz2048_wi-fire/include/bsp/bsp.h | 2 -- hw/bsp/rb-blend2/include/bsp/bsp.h | 2 -- hw/bsp/rb-nano2/include/bsp/bsp.h | 2 -- hw/bsp/ruuvi_tag_revb2/include/bsp/bsp.h | 11 --- hw/bsp/ruuvi_tag_revb2/syscfg.yml | 1 + hw/bsp/sensorhub/include/bsp/bsp.h | 11 --- hw/bsp/sensorhub/syscfg.yml| 1 + hw/bsp/stm32f429discovery/include/bsp/bsp.h| 2 -- hw/bsp/stm32f4discovery/include/bsp/bsp.h | 2 -- hw/bsp/stm32f767-nucleo/include/bsp/bsp.h | 2 -- hw/bsp/stm32f7discovery/include/bsp/bsp.h | 2 -- hw/bsp/telee02/include/bsp/bsp.h | 11 --- hw/bsp/telee02/syscfg.yml | 1 + hw/bsp/usbmkw41z/include/bsp/bsp.h | 3 -- hw/bsp/vbluno51/include/bsp/bsp.h | 2 -- hw/bsp/vbluno52/include/bsp/bsp.h | 3 -- sys/config/src/config_init.c | 2 +- sys/config/syscfg.yml | 5 50 files changed, 62 insertions(+), 173 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[mynewt-core] branch master updated (a9ff0cc -> e3c41b9)
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from a9ff0cc Merge pull request #481 from ccollins476ad/oic-trans-security add 52ed569 Remove NFFS_AREA_MAX constant from bsp.h. add e8f6016 Make # areas in the config FCB configurable. add 7746be4 Move serial boot #defines out of bsp.h. new e3c41b9 Merge pull request #499 from ccollins476ad/rm-nffs-area-max The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: apps/testbench/src/testbench.h | 11 - boot/boot_serial/src/boot_serial.c | 21 ++ {net/lora/node => boot/boot_serial}/syscfg.yml | 48 +- boot/boot_serial/test/syscfg.yml | 2 + fs/nffs/src/nffs.c | 4 +- fs/nffs/syscfg.yml | 6 +++ hw/bsp/ada_feather_nrf52/include/bsp/bsp.h | 11 - hw/bsp/ada_feather_nrf52/syscfg.yml| 1 + hw/bsp/arduino_primo_nrf52/include/bsp/bsp.h | 2 - hw/bsp/bbc_microbit/include/bsp/bsp.h | 2 - hw/bsp/ble400/include/bsp/bsp.h| 2 - hw/bsp/bmd200/include/bsp/bsp.h| 2 - hw/bsp/bmd300eval/include/bsp/bsp.h| 2 - hw/bsp/ci40/include/bsp/bsp.h | 2 - hw/bsp/frdm-k64f/include/bsp/bsp.h | 8 hw/bsp/native-armv7/include/bsp/bsp.h | 2 - hw/bsp/native-mips/include/bsp/bsp.h | 2 - hw/bsp/native/include/bsp/bsp.h| 2 - hw/bsp/nina-b1/include/bsp/bsp.h | 12 -- hw/bsp/nina-b1/syscfg.yml | 2 + hw/bsp/nrf51-arduino_101/include/bsp/bsp.h | 2 - hw/bsp/nrf51-blenano/include/bsp/bsp.h | 2 - hw/bsp/nrf51dk-16kbram/include/bsp/bsp.h | 2 - hw/bsp/nrf51dk/include/bsp/bsp.h | 2 - hw/bsp/nrf52-thingy/include/bsp/bsp.h | 11 - hw/bsp/nrf52-thingy/syscfg.yml | 1 + hw/bsp/nrf52840pdk/include/bsp/bsp.h | 2 - hw/bsp/nrf52dk/include/bsp/bsp.h | 11 - hw/bsp/nrf52dk/syscfg.yml | 1 + hw/bsp/nucleo-f401re/include/bsp/bsp.h | 2 - .../olimex_stm32-e407_devboard/include/bsp/bsp.h | 2 - hw/bsp/pic32mx470_6lp_clicker/include/bsp/bsp.h| 2 - hw/bsp/pic32mz2048_wi-fire/include/bsp/bsp.h | 2 - hw/bsp/rb-blend2/include/bsp/bsp.h | 2 - hw/bsp/rb-nano2/include/bsp/bsp.h | 2 - hw/bsp/ruuvi_tag_revb2/include/bsp/bsp.h | 11 - hw/bsp/ruuvi_tag_revb2/syscfg.yml | 1 + hw/bsp/sensorhub/include/bsp/bsp.h | 11 - hw/bsp/sensorhub/syscfg.yml| 1 + hw/bsp/stm32f429discovery/include/bsp/bsp.h| 2 - hw/bsp/stm32f4discovery/include/bsp/bsp.h | 2 - hw/bsp/stm32f767-nucleo/include/bsp/bsp.h | 2 - hw/bsp/stm32f7discovery/include/bsp/bsp.h | 2 - hw/bsp/telee02/include/bsp/bsp.h | 11 - hw/bsp/telee02/syscfg.yml | 1 + hw/bsp/usbmkw41z/include/bsp/bsp.h | 3 -- hw/bsp/vbluno51/include/bsp/bsp.h | 2 - hw/bsp/vbluno52/include/bsp/bsp.h | 3 -- sys/config/src/config_init.c | 2 +- sys/config/syscfg.yml | 5 +++ 50 files changed, 57 insertions(+), 192 deletions(-) copy {net/lora/node => boot/boot_serial}/syscfg.yml (52%) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[GitHub] ccollins476ad closed pull request #499: Convert some defines in `bsp.h` to syscfg settings
ccollins476ad closed pull request #499: Convert some defines in `bsp.h` to syscfg settings URL: https://github.com/apache/mynewt-core/pull/499 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-newt] branch master updated (7734135 -> 020377b)
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git. from 7734135 newt - Fix empty build error. add 27027b2 Makefile for building debian package add f9e304d Add comment to indicate it is use to build deb package. new 020377b Merge pull request #91 from cwanda/deb_makefiles The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: Makefile | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 Makefile -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[mynewt-newt] 01/01: Merge pull request #91 from cwanda/deb_makefiles
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git commit 020377bd5a8f983bf99bc63e05b7ee261cd3f32f Merge: 7734135 f9e304d Author: ccollins476adAuthorDate: Thu Aug 31 12:07:32 2017 -0700 Merge pull request #91 from cwanda/deb_makefiles Makefile for building debian package Makefile | 10 ++ 1 file changed, 10 insertions(+) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[GitHub] ccollins476ad closed pull request #91: Makefile for building debian package
ccollins476ad closed pull request #91: Makefile for building debian package URL: https://github.com/apache/mynewt-newt/pull/91 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cwanda commented on issue #91: Makefile for building debian package
cwanda commented on issue #91: Makefile for building debian package URL: https://github.com/apache/mynewt-newt/pull/91#issuecomment-326391877 Thanks chris. I also updated the Makefile with comments for newtmgr This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] branch master updated (f18bb0b -> a9ff0cc)
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from f18bb0b Merge pull request #439 from ccollins476ad/mempool-sane add 53ba882 oic: Per-resource transport layer sec requirements new a9ff0cc Merge pull request #481 from ccollins476ad/oic-trans-security The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: net/oic/include/oic/oc_api.h | 4 net/oic/include/oic/oc_ri.h| 9 +-- net/oic/include/oic/port/oc_connectivity.h | 2 ++ net/oic/src/api/oc_ri.c| 38 +- net/oic/src/api/oc_server_api.c| 27 + net/oic/src/port/mynewt/adaptor.c | 30 +++ net/oic/src/port/mynewt/adaptor.h | 4 net/oic/src/port/mynewt/ble_adaptor.c | 27 + net/oic/syscfg.yml | 5 9 files changed, 138 insertions(+), 8 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[mynewt-core] 01/01: Merge pull request #481 from ccollins476ad/oic-trans-security
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit a9ff0cc96f45e4a4d6e3dabef8303c1913aad545 Merge: f18bb0b 53ba882 Author: ccollins476adAuthorDate: Thu Aug 31 11:32:05 2017 -0700 Merge pull request #481 from ccollins476ad/oic-trans-security oic: Per-resource transport layer sec requirements net/oic/include/oic/oc_api.h | 4 net/oic/include/oic/oc_ri.h| 9 +-- net/oic/include/oic/port/oc_connectivity.h | 2 ++ net/oic/src/api/oc_ri.c| 38 +- net/oic/src/api/oc_server_api.c| 27 + net/oic/src/port/mynewt/adaptor.c | 30 +++ net/oic/src/port/mynewt/adaptor.h | 4 net/oic/src/port/mynewt/ble_adaptor.c | 27 + net/oic/syscfg.yml | 5 9 files changed, 138 insertions(+), 8 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[GitHub] ccollins476ad closed pull request #481: oic: Per-resource transport layer sec requirements
ccollins476ad closed pull request #481: oic: Per-resource transport layer sec requirements URL: https://github.com/apache/mynewt-core/pull/481 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] 01/01: Merge pull request #439 from ccollins476ad/mempool-sane
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit f18bb0b9c432eb76e7d76253d485b252ede9eef3 Merge: 24eb7d7 63fc8f2 Author: ccollins476adAuthorDate: Thu Aug 31 11:31:42 2017 -0700 Merge pull request #439 from ccollins476ad/mempool-sane os_mempool_is_sane() debug function. kernel/os/include/os/os_mempool.h | 5 - kernel/os/src/os_mempool.c| 28 +++- 2 files changed, 31 insertions(+), 2 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[mynewt-core] 01/01: Merge pull request #517 from sjanc/static_check
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 24eb7d758f22e25b6bf35d4ed2255c1c2e616664 Merge: 5058a8d e72951d Author: Szymon JancAuthorDate: Thu Aug 31 20:30:58 2017 +0200 Merge pull request #517 from sjanc/static_check Random fixes for issues reported by static analysis .../test/src/testcases/boot_test_nv_bs_11.c| 1 + .../test/src/testcases/boot_test_nv_ns_01.c| 5 +- fs/disk/src/disk.c | 2 +- fs/fs/src/fs_file.c| 2 + fs/fs/src/fs_mount.c | 10 ++-- fs/nffs/src/nffs.c | 3 +- fs/nffs/src/nffs_priv.h| 1 - fs/nffs/test/src/nffs_test_debug.c | 25 - hw/drivers/nimble/native/src/ble_phy.c | 36 - hw/drivers/uart/uart_hal/src/uart_hal.c| 1 + hw/mcu/native/src/hal_uart.c | 1 + kernel/os/include/os/os_task.h | 1 - kernel/os/test/src/mutex_test.c| 6 +-- libc/baselibc/src/asprintf.c | 8 +-- net/ip/mn_socket/test/src/mn_sock_util.c | 6 +-- net/nimble/controller/test/src/ble_ll_csa2_test.c | 2 +- net/nimble/host/test/src/ble_att_svr_test.c| 59 +++--- net/nimble/host/test/src/ble_gap_test.c| 20 +--- net/nimble/host/test/src/ble_gatt_disc_c_test.c| 16 -- net/nimble/host/test/src/ble_gatt_disc_d_test.c| 8 +-- net/nimble/host/test/src/ble_gatt_disc_s_test.c| 15 -- net/nimble/host/test/src/ble_gatt_find_s_test.c| 6 ++- net/nimble/host/test/src/ble_gatt_read_test.c | 16 -- net/nimble/host/test/src/ble_gatt_write_test.c | 12 +++-- net/nimble/host/test/src/ble_hs_test_util.c| 15 -- net/nimble/host/test/src/ble_l2cap_test.c | 19 --- net/nimble/host/test/src/ble_sm_test_util.c| 3 +- sys/config/src/config.c| 10 ++-- sys/config/test-fcb/src/conf_test_fcb.c| 4 +- sys/flash_map/test/src/flash_map_test.c| 3 +- sys/log/full/src/log.c | 1 + sys/shell/src/shell.c | 6 +-- sys/shell/src/shell_os.c | 4 +- 33 files changed, 190 insertions(+), 137 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[mynewt-core] branch master updated (5058a8d -> 24eb7d7)
This is an automated email from the ASF dual-hosted git repository. janc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 5058a8d Merge pull request #502 from schilken/master add c3eaaeb nimble/test: Pass SM public key structure to ble_sm_dbg_set_sc_keys add f307b72 nimble/test: Check for ble_gap_conn_find return value add 1a43ed0 nimble/test: Assert all os_mbuf operations add bee5cf0 net/test: Fix use on uninitialized variable add 79b6aa7 nimble/tests: Fix possible NULL pointer dereference add bc9f046 ip/tests: Remove redundant NULL check add bea4737 tests: Fix invalid fa_sectors allocation add 54a29bc nimble/test: Fix setting channel map for CSA2 add 8fccf99 os/tests: Remove dead assignments and fix comments in mutex tests add 1d8db27 boot/tests: Add missing asserts for checking boot_set_pending succeed add 46766b4 nffs/tests: Fix use of uninitialized values add 7fbad11 nimble/test: Limit max characteristics when validating handling add 9052bf2 nimble/test: Fix max intervals in L2CAP tests add aeee057 nimble/test: Limit max characteristics when validating handling FIX add be714f8 shell: Fix parameter typy for get_destination_module add 6c918ac Remove not used oti_flags from struct os_task_info add 2ac5cf5 baselibc: Fix missing va_end in asprintf add d51a092 shell: Fix invalid check for string end add df916f4 fcb/test: Assert on flash_area_erase error add e173d64 fs/disk: Fix out of bound write add f6d9ff6 fs: Fix NULL pointer dereference in fs_ops_for add 6388f5f fs: Fix memory leak in fops_from_filename add e2d11b1 fs/nffs: Remove not needed initalization add 7ed69a9 fs/nffs: Remove padding from struct nffs_block add b31f411 log: Fix missing va_end call in log_printf add 7af6102 sys/config: Remove some dead code from conf_value_from_str add 6280847 uart_hal: Fix memory leak on uart_hal_init error path add 44326d3 Remove some dead code from native controller add a3a2df9 native/hal_uart: Fix fd leak on uart_open_dev error path add e72951d Remove some dead code from native controller FI new 24eb7d7 Merge pull request #517 from sjanc/static_check The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../test/src/testcases/boot_test_nv_bs_11.c| 1 + .../test/src/testcases/boot_test_nv_ns_01.c| 5 +- fs/disk/src/disk.c | 2 +- fs/fs/src/fs_file.c| 2 + fs/fs/src/fs_mount.c | 10 ++-- fs/nffs/src/nffs.c | 3 +- fs/nffs/src/nffs_priv.h| 1 - fs/nffs/test/src/nffs_test_debug.c | 25 - hw/drivers/nimble/native/src/ble_phy.c | 36 - hw/drivers/uart/uart_hal/src/uart_hal.c| 1 + hw/mcu/native/src/hal_uart.c | 1 + kernel/os/include/os/os_task.h | 1 - kernel/os/test/src/mutex_test.c| 6 +-- libc/baselibc/src/asprintf.c | 8 +-- net/ip/mn_socket/test/src/mn_sock_util.c | 6 +-- net/nimble/controller/test/src/ble_ll_csa2_test.c | 2 +- net/nimble/host/test/src/ble_att_svr_test.c| 59 +++--- net/nimble/host/test/src/ble_gap_test.c| 20 +--- net/nimble/host/test/src/ble_gatt_disc_c_test.c| 16 -- net/nimble/host/test/src/ble_gatt_disc_d_test.c| 8 +-- net/nimble/host/test/src/ble_gatt_disc_s_test.c| 15 -- net/nimble/host/test/src/ble_gatt_find_s_test.c| 6 ++- net/nimble/host/test/src/ble_gatt_read_test.c | 16 -- net/nimble/host/test/src/ble_gatt_write_test.c | 12 +++-- net/nimble/host/test/src/ble_hs_test_util.c| 15 -- net/nimble/host/test/src/ble_l2cap_test.c | 19 --- net/nimble/host/test/src/ble_sm_test_util.c| 3 +- sys/config/src/config.c| 10 ++-- sys/config/test-fcb/src/conf_test_fcb.c| 4 +- sys/flash_map/test/src/flash_map_test.c| 3 +- sys/log/full/src/log.c | 1 + sys/shell/src/shell.c | 6 +-- sys/shell/src/shell_os.c | 4 +- 33 files changed, 190 insertions(+), 137 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[GitHub] sjanc closed pull request #517: Random fixes for issues reported by static analysis
sjanc closed pull request #517: Random fixes for issues reported by static analysis URL: https://github.com/apache/mynewt-core/pull/517 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] 01/01: Merge pull request #502 from schilken/master
This is an automated email from the ASF dual-hosted git repository. marko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 5058a8d61f9da507393e62dc02d9e928319c5794 Merge: a054216 3ee1829 Author: mkiiskilaAuthorDate: Thu Aug 31 11:25:06 2017 -0700 Merge pull request #502 from schilken/master add bsp for calliope mini board hw/bsp/calliope_mini/README.md | 21 ++ hw/bsp/calliope_mini/boot-nrf51xxac.ld | 27 ++ hw/bsp/calliope_mini/bsp.yml | 69 + hw/bsp/calliope_mini/calliope_mini_debug.cmd | 22 ++ hw/bsp/calliope_mini/calliope_mini_debug.sh| 37 +++ hw/bsp/calliope_mini/calliope_mini_download.cmd| 22 ++ hw/bsp/calliope_mini/calliope_mini_download.sh | 42 hw/bsp/calliope_mini/include/bsp/bsp.h | 81 ++ hw/bsp/calliope_mini/include/bsp/cmsis_nvic.h | 30 +++ hw/bsp/calliope_mini/nrf51xxac.ld | 30 +++ hw/bsp/calliope_mini/pkg.yml | 89 +++ hw/bsp/calliope_mini/split-calliope_mini.ld| 185 ++ .../src/arch/cortex_m0/gcc_startup_nrf51.s | 280 + .../src/arch/cortex_m0/gcc_startup_nrf51_split.s | 182 ++ hw/bsp/calliope_mini/src/hal_bsp.c | 193 ++ hw/bsp/calliope_mini/src/sbrk.c| 57 + hw/bsp/calliope_mini/syscfg.yml| 116 + 17 files changed, 1483 insertions(+) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[GitHub] ccollins476ad commented on issue #517: Random fixes for issues reported by static analysis
ccollins476ad commented on issue #517: Random fixes for issues reported by static analysis URL: https://github.com/apache/mynewt-core/pull/517#issuecomment-326378964 Thanks for doing all this! I reviewed the following commits; they all look good to me. ``` b31f411d0928b0d098de7eeca1c3c83b5ae29ccb 7ed69a926e81ee0cfb111a630e411086d2b1f3fc e2d11b10248d1e8fd4287a02a60e2a27446f7635 6388f5f57359b201e5b16b0abc2120204be2d43d f6d9ff693a8adeb02afdbb2bc00459dc07641408 e173d6487190bd1de886178a0fca4fcbc196d608 df916f4ddd6781062497c304ab1213d2be5cab3d d51a09260bb79a760331f0f26e6a8649a4f3f50f 2ac5cf5f44d8a5abb1fe87ee36308d22d6138882 6c918ac99bfa1fd4c0f42eb8c2423b7b1827e18c be714f81b95c93e464af4e138a0438e299cd1248 aeee05761453b36f81426ce95de1e4c6ce70697d 9052bf21754420dffc97e0ae04332dff761f1ed9 7fbad114ee1a76234253457b6fef338b6751303f 46766b4caeec265890f8e6c351488a80c0710916 1d8db27caf074312f641e65eb467cb4af080cb1c 8fccf99ce51c5e1fed760ca92415736ce97e9116 54a29bc0f8ed14981f2f36c6b3c3876955c2a245 bea47376054dded44fd1942acf91292f2c56cc5e bc9f046aa14351ab69c545948f6e69813814ef1d 79b6aa7b60d8e598e19ad8332aeaa4da58ddee2b bee5cf055c9f57e19c88da9070dbfff9f21a0403 1a43ed04274fb24c1c7588b62925a23b229ebc08 f307b7226d0003c7bf8c0811ff196df1ff463ade c3eaaebdd640ebd48e25acfbc2f10836354b077b ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mkiiskila commented on a change in pull request #512: native; support setting hwid for native target via command line argum?
mkiiskila commented on a change in pull request #512: native; support setting hwid for native target via command line argum? URL: https://github.com/apache/mynewt-core/pull/512#discussion_r136407246 ## File path: hw/mcu/native/src/hal_hw_id.c ## @@ -22,20 +22,39 @@ #include "hal/hal_bsp.h" +#include "hal_native_priv.h" + #ifndef min #define min(a, b) ((a)<(b)?(a):(b)) #endif +static uint8_t hal_hw_id[HAL_BSP_MAX_ID_LEN]; +static uint8_t hal_hw_id_len; + /* * This can be used as the unique hardware identifier for the platform, as * it's supposed to be unique for this particular MCU. */ int hal_bsp_hw_id(uint8_t *id, int max_len) { +if (hal_hw_id_len) { +memcpy(id, hal_hw_id, hal_hw_id_len); Review comment: Yes, it should. Lemme fix that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad commented on a change in pull request #512: native; support setting hwid for native target via command line argum?
ccollins476ad commented on a change in pull request #512: native; support setting hwid for native target via command line argum? URL: https://github.com/apache/mynewt-core/pull/512#discussion_r136402094 ## File path: hw/mcu/native/src/hal_hw_id.c ## @@ -22,20 +22,39 @@ #include "hal/hal_bsp.h" +#include "hal_native_priv.h" + #ifndef min #define min(a, b) ((a)<(b)?(a):(b)) #endif +static uint8_t hal_hw_id[HAL_BSP_MAX_ID_LEN]; +static uint8_t hal_hw_id_len; + /* * This can be used as the unique hardware identifier for the platform, as * it's supposed to be unique for this particular MCU. */ int hal_bsp_hw_id(uint8_t *id, int max_len) { +if (hal_hw_id_len) { +memcpy(id, hal_hw_id, hal_hw_id_len); +return hal_hw_id_len; +} if (max_len > HAL_BSP_MAX_ID_LEN) { max_len = HAL_BSP_MAX_ID_LEN; } memset(id, 0x42, max_len); return max_len; } + +void +hal_bsp_set_hw_id(uint8_t *id, int len) Review comment: Just a suggestion: you could make `id` pointer to const. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad commented on a change in pull request #512: native; support setting hwid for native target via command line argum?
ccollins476ad commented on a change in pull request #512: native; support setting hwid for native target via command line argum? URL: https://github.com/apache/mynewt-core/pull/512#discussion_r136401640 ## File path: hw/mcu/native/src/hal_hw_id.c ## @@ -22,20 +22,39 @@ #include "hal/hal_bsp.h" +#include "hal_native_priv.h" + #ifndef min #define min(a, b) ((a)<(b)?(a):(b)) #endif +static uint8_t hal_hw_id[HAL_BSP_MAX_ID_LEN]; +static uint8_t hal_hw_id_len; + /* * This can be used as the unique hardware identifier for the platform, as * it's supposed to be unique for this particular MCU. */ int hal_bsp_hw_id(uint8_t *id, int max_len) { +if (hal_hw_id_len) { +memcpy(id, hal_hw_id, hal_hw_id_len); Review comment: Should this function make sure it doesn't copy more than `max_len` bytes here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] 01/01: Merge pull request #507 from mkiiskila/mynewt_829
This is an automated email from the ASF dual-hosted git repository. marko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit a05421621462a1666be09b4b7ee07dfe52a2e0ae Merge: 40b870a 0bc26a8 Author: mkiiskilaAuthorDate: Thu Aug 31 10:42:24 2017 -0700 Merge pull request #507 from mkiiskila/mynewt_829 boot_serial; access uart driver directly instead of going through console. apps/boot/pkg.yml | 1 - boot/boot_serial/src/boot_serial.c | 82 ++ boot/boot_serial/src/boot_serial_priv.h| 6 + boot/boot_serial/src/boot_uart.c | 171 + .../test/src/testcases/boot_serial_setup.c | 3 + apps/boot/pkg.yml => sys/console/stub/syscfg.yml | 28 ++-- 6 files changed, 205 insertions(+), 86 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[mynewt-core] branch master updated (40b870a -> a054216)
This is an automated email from the ASF dual-hosted git repository. marko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 40b870a Merge pull request #514 from ccollins476ad/nrf-timer-check add 6c819b1 boot_serial; access uart driver directly instead of going through console. add 0bc26a8 boot_serial; unittest was not opening UART. new a054216 Merge pull request #507 from mkiiskila/mynewt_829 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: apps/boot/pkg.yml | 1 - boot/boot_serial/src/boot_serial.c | 82 ++ boot/boot_serial/src/boot_serial_priv.h| 6 + boot/boot_serial/src/boot_uart.c | 171 + .../test/src/testcases/boot_serial_setup.c | 3 + .../console/stub}/syscfg.yml | 14 +- 6 files changed, 203 insertions(+), 74 deletions(-) create mode 100644 boot/boot_serial/src/boot_uart.c copy {compiler/arm-none-eabi-m4 => sys/console/stub}/syscfg.yml (72%) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[GitHub] mkiiskila commented on issue #507: boot_serial; access uart driver directly instead of going through console.
mkiiskila commented on issue #507: boot_serial; access uart driver directly instead of going through console. URL: https://github.com/apache/mynewt-core/pull/507#issuecomment-326368940 The serial bootloader opens the UART, and uses syscfg settings to figure out which one to open, baudrate etc. I could've placed these syscfg definitions to under boot/boot_serial instead, but it felt more natural to have them under console/stub. I wanted to use the same syscfg variable names (as these might be overwritten in bsp). console/stub gets used when building bootloader, so it sort of works naturally. Although the reason to have them there is a bit unnatural. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cwanda opened a new pull request #318: Tell user to replace console/stub with console/full
cwanda opened a new pull request #318: Tell user to replace console/stub with console/full URL: https://github.com/apache/mynewt-site/pull/318 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wes3 commented on issue #517: Random fixes for issues reported by static analysis
wes3 commented on issue #517: Random fixes for issues reported by static analysis URL: https://github.com/apache/mynewt-core/pull/517#issuecomment-326348303 I reviewed the following commits: 7af6102 through e72951d (inclusive) and 8fccf99. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh
cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh URL: https://github.com/apache/mynewt-site/pull/317#discussion_r136377719 ## File path: docs/network/ble/ble_intro.md ## @@ -51,5 +60,6 @@ Mynewt comes with two built-in projects that allow users to play with NimBLE, tr 1. **bletiny** : A simple shell application which provides a basic interface to the host-side of the BLE stack. 2. **bleprph**: A basic peripheral device with no user interface. It advertises automatically on startup, and resumes advertising whenever a connection is terminated. It supports a maximum of one connection. +3. **blemesh**: Sample application for BLE Mesh node with on/off model. Review comment: Change "Sample application" -> "A sample application" to make the list consistent. I am not familiar with BLE Mesh nodes. The literature indicates a server/client model. Does this application implement a server, client, or both? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh
cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh URL: https://github.com/apache/mynewt-site/pull/317#discussion_r136374719 ## File path: custom-theme/pages/ble.html ## @@ -42,6 +47,15 @@ Transmit Power Service +Bluetooth Mesh support + + Advertising and GATT beares Review comment: typo: "beares"->"bearers" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh
cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh URL: https://github.com/apache/mynewt-site/pull/317#discussion_r136372808 ## File path: docs/network/ble/ble_intro.md ## @@ -25,6 +24,16 @@ NimBLE complies with Bluetooth Core Specification 5.0 which makes it an ideal wi The Bluetooth 5 is backward compatible with previous Bluetooth version 4.2 which is also supported by Apache Mynewt. +### Bluetooth Mesh features + +Nimble supports Bluetooth Mesh which is great addition to IoT connectivity space and opens wide range of new possibilities for it. Review comment: Maybe reword: "Bluetooth Mesh is a great addition to and opens a wide range of new possibilities for the IoT connectivity space. NimBLE fully supports the following Bluetooth Mesh features:" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh
cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh URL: https://github.com/apache/mynewt-site/pull/317#discussion_r136372808 ## File path: docs/network/ble/ble_intro.md ## @@ -25,6 +24,16 @@ NimBLE complies with Bluetooth Core Specification 5.0 which makes it an ideal wi The Bluetooth 5 is backward compatible with previous Bluetooth version 4.2 which is also supported by Apache Mynewt. +### Bluetooth Mesh features + +Nimble supports Bluetooth Mesh which is great addition to IoT connectivity space and opens wide range of new possibilities for it. Review comment: Maybe reword: "Bluetooth Mesh opens a wide range of new possibilities for the IoT connectivity space. NimBLE fully supports the following Bluetooth Mesh features:" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh
cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh URL: https://github.com/apache/mynewt-site/pull/317#discussion_r136372808 ## File path: docs/network/ble/ble_intro.md ## @@ -25,6 +24,16 @@ NimBLE complies with Bluetooth Core Specification 5.0 which makes it an ideal wi The Bluetooth 5 is backward compatible with previous Bluetooth version 4.2 which is also supported by Apache Mynewt. +### Bluetooth Mesh features + +Nimble supports Bluetooth Mesh which is great addition to IoT connectivity space and opens wide range of new possibilities for it. Review comment: Maybe reword: "NimBLE supports Bluetooth Mesh. Bluetooth Mesh opens a wide range of new possibilities for the IoT connectivity space. NimBLE fully supports the following Bluetooth Mesh features:" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh
cwanda commented on a change in pull request #317: doc: Updates for BT5 and Mesh URL: https://github.com/apache/mynewt-site/pull/317#discussion_r136372808 ## File path: docs/network/ble/ble_intro.md ## @@ -25,6 +24,16 @@ NimBLE complies with Bluetooth Core Specification 5.0 which makes it an ideal wi The Bluetooth 5 is backward compatible with previous Bluetooth version 4.2 which is also supported by Apache Mynewt. +### Bluetooth Mesh features + +Nimble supports Bluetooth Mesh which is great addition to IoT connectivity space and opens wide range of new possibilities for it. Review comment: Maybe reword: "NimBLE supports Bluetooth Mesh. Bluetooth Mesh opens a wide range of new possibilities for the IoT connectivity space. NimBLE fully supports the following Bluetooth Mesh features: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sjanc commented on issue #517: Random fixes for issues reported by static analysis
sjanc commented on issue #517: Random fixes for issues reported by static analysis URL: https://github.com/apache/mynewt-core/pull/517#issuecomment-326306064 test this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sjanc opened a new pull request #517: Random fixes for issues reported by static analysis
sjanc opened a new pull request #517: Random fixes for issues reported by static analysis URL: https://github.com/apache/mynewt-core/pull/517 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rymanluk opened a new pull request #317: doc: Updates for BT5 and Mesh
rymanluk opened a new pull request #317: doc: Updates for BT5 and Mesh URL: https://github.com/apache/mynewt-site/pull/317 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sjanc commented on issue #513: Lora improv
sjanc commented on issue #513: Lora improv URL: https://github.com/apache/mynewt-core/pull/513#issuecomment-326221773 something is not right with second commit message :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services