[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2494: Fix STM32 HASH stream support

2021-02-20 Thread GitBox 


apache-mynewt-bot removed a comment on pull request #2494:
URL: https://github.com/apache/mynewt-core/pull/2494#issuecomment-782691098


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2494: Fix STM32 HASH stream support

2021-02-20 Thread GitBox 


apache-mynewt-bot commented on pull request #2494:
URL: https://github.com/apache/mynewt-core/pull/2494#issuecomment-782733316


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] janosbrodbeck edited a comment on issue #912: Controller: Assertion fail in ble_ll_scan.c with extended advertisings

2021-02-20 Thread GitBox 


janosbrodbeck edited a comment on issue #912:
URL: https://github.com/apache/mynewt-nimble/issues/912#issuecomment-780986566


   I'm not sure if this is correct but here is my .elf file of the application 
(nrf52840dk) and a dump of the memory (start: 0 end: 512000).
   
[memory_dump.zip](https://github.com/apache/mynewt-nimble/files/5999708/memory_dump.zip)
   
   (GitHub does not allow to attach .elf and .bin files)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] utzig merged pull request #2493: apps/rust_blinky: Support cargo release builds

2021-02-20 Thread GitBox 


utzig merged pull request #2493:
URL: https://github.com/apache/mynewt-core/pull/2493


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[mynewt-core] branch master updated: apps/rust_blinky: use cargo release profile when mynewt build profile is not debug

2021-02-20 Thread utzig 
This is an automated email from the ASF dual-hosted git repository.

utzig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
 new a2161f0  apps/rust_blinky: use cargo release profile when mynewt build 
profile is not debug
 new 5651eab  Merge pull request #2493 from 
stuffmatic/rust-blinky-build-profile-fix
a2161f0 is described below

commit a2161f059d7cd72d2d538914cac21368b9c7ffa2
Author: Per 
AuthorDate: Sat Feb 20 13:49:26 2021 +0100

apps/rust_blinky: use cargo release profile when mynewt build profile is 
not debug
---
 apps/rust_blinky/cargo_build.sh | 16 ++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/apps/rust_blinky/cargo_build.sh b/apps/rust_blinky/cargo_build.sh
index 2ae27a8..230d59a 100755
--- a/apps/rust_blinky/cargo_build.sh
+++ b/apps/rust_blinky/cargo_build.sh
@@ -17,6 +17,7 @@ set -eu
 # limitations under the License.
 #
 
+# Map mynewt architecture to cargo target
 if [[ ${MYNEWT_VAL_ARCH_NAME} == '"cortex_m0"' ]]; then
   TARGET="thumbv6m-none-eabi"
 elif [[ ${MYNEWT_VAL_ARCH_NAME} == '"cortex_m3"' ]]; then
@@ -32,5 +33,16 @@ else
   exit 1
 fi
 
-cargo build --target="${TARGET}" --target-dir="${MYNEWT_PKG_BIN_DIR}"
-cp "${MYNEWT_PKG_BIN_DIR}"/${TARGET}/debug/*.a "${MYNEWT_PKG_BIN_ARCHIVE}"
+# Map mynewt build profile to cargo build profile
+if [[ ${MYNEWT_BUILD_PROFILE} == 'debug' ]]; then
+  # mynewt debug profile -> cargo debug profile
+  CARGO_PROFILE="debug"
+  CARGO_ARGS=""
+else
+  # all other mynewt profiles -> cargo release profile
+  CARGO_PROFILE="release"
+  CARGO_ARGS="--release"
+fi
+
+cargo build --target="${TARGET}" --target-dir="${MYNEWT_PKG_BIN_DIR}" 
${CARGO_ARGS}
+cp "${MYNEWT_PKG_BIN_DIR}"/${TARGET}/${CARGO_PROFILE}/*.a 
"${MYNEWT_PKG_BIN_ARCHIVE}"

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2493: apps/rust_blinky: Support cargo release builds

2021-02-20 Thread GitBox 


apache-mynewt-bot commented on pull request #2493:
URL: https://github.com/apache/mynewt-core/pull/2493#issuecomment-782711035


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2493: apps/rust_blinky: Support cargo release builds

2021-02-20 Thread GitBox 


apache-mynewt-bot removed a comment on pull request #2493:
URL: https://github.com/apache/mynewt-core/pull/2493#issuecomment-782643114


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] utzig commented on a change in pull request #2493: apps/rust_blinky: Support cargo release builds

2021-02-20 Thread GitBox 


utzig commented on a change in pull request #2493:
URL: https://github.com/apache/mynewt-core/pull/2493#discussion_r579665741



##
File path: apps/rust_blinky/cargo_build.sh
##
@@ -32,5 +33,16 @@ else
   exit 1
 fi
 
-cargo build --target="${TARGET}" --target-dir="${MYNEWT_PKG_BIN_DIR}"
-cp "${MYNEWT_PKG_BIN_DIR}"/${TARGET}/debug/*.a "${MYNEWT_PKG_BIN_ARCHIVE}"
+# Map mynewt build profile to cargo build profile
+if [[ ${MYNEWT_BUILD_PROFILE} == 'debug' ]]; then
+  # mynewt debug profile -> cargo debug profile
+  CARGO_PROFILE="debug"
+  CARGO_ARGS=""
+else
+  # all other mynewt profiles -> cargo release profile
+  CARGO_PROFILE="release"
+  CARGO_ARGS=" --release"
+fi
+
+cargo build --target="${TARGET}" 
--target-dir="${MYNEWT_PKG_BIN_DIR}"${CARGO_ARGS}

Review comment:
   This would look better if there was a space between 
`${MYNEWT_PKG_BIN_DIR}"` and `${CARGO_ARGS}`, and of course, no space inside 
`CARGO_ARGS`, any reason for doing it this way?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2494: Fix STM32 HASH stream support

2021-02-20 Thread GitBox 


apache-mynewt-bot removed a comment on pull request #2494:
URL: https://github.com/apache/mynewt-core/pull/2494#issuecomment-782690314


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/drivers/hash/hash_stm32/src/hash_stm32.c
   
   
   ```diff
   @@ -70,7 +70,7 @@

static int
stm32_hash_update(struct hash_dev *hash, void *ctx, uint16_t algo,
   -const void *inbuf, uint32_t inlen)
   +  const void *inbuf, uint32_t inlen)
{
uint32_t *u32p;
uint8_t *u8p;
   ```
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2494: Fix STM32 HASH stream support

2021-02-20 Thread GitBox 


apache-mynewt-bot commented on pull request #2494:
URL: https://github.com/apache/mynewt-core/pull/2494#issuecomment-782691098


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2494: Fix STM32 HASH stream support

2021-02-20 Thread GitBox 


apache-mynewt-bot commented on pull request #2494:
URL: https://github.com/apache/mynewt-core/pull/2494#issuecomment-782690314


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/drivers/hash/hash_stm32/src/hash_stm32.c
   
   
   ```diff
   @@ -70,7 +70,7 @@

static int
stm32_hash_update(struct hash_dev *hash, void *ctx, uint16_t algo,
   -const void *inbuf, uint32_t inlen)
   +  const void *inbuf, uint32_t inlen)
{
uint32_t *u32p;
uint8_t *u8p;
   ```
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] utzig opened a new pull request #2494: Fix STM32 HASH stream support

2021-02-20 Thread GitBox 


utzig opened a new pull request #2494:
URL: https://github.com/apache/mynewt-core/pull/2494


   apps: hash_test: add single byte multi-write test - Expand string stream 
test to also run on SHA-224 (when available). Add new single byte multi-write 
test, where a single "a" is written 256 times, running on both SHA-224 and 
SHA-256 (where available).
   
   hw: drivers: hash_stm32: fix stream support - The STM32 HASH HW is 
configured to work on a word (32-bit) write, and the only write that can be 
less than 4-bytes is the last write (_finish()). To be compatible with streams 
that are non word-boundary sized, a new pad (aka state) was added that caches 
writes that are less than 4 byte, so only words are ever written in an 
_update(), and _finish() flushes the remaining bytes that were less than 
4-bytes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2493: apps/rust_blinky: Support cargo release builds

2021-02-20 Thread GitBox 


apache-mynewt-bot commented on pull request #2493:
URL: https://github.com/apache/mynewt-core/pull/2493#issuecomment-782643114


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] stuffmatic opened a new pull request #2493: apps/rust_blinky: Support cargo release builds

2021-02-20 Thread GitBox 


stuffmatic opened a new pull request #2493:
URL: https://github.com/apache/mynewt-core/pull/2493


   This PR makes 
[cargo_build.sh](https://github.com/apache/mynewt-core/blob/master/apps/rust_blinky/cargo_build.sh)
 use a cargo build profile (debug or release) based on the mynewt build 
profile. Previously, the cargo debug profile was always used.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org